AST: Fix lost GenericSignatureErrors in getPlaceholderRequirementSignature()

slavapestov · slavapestov · commit bf3f4a6d79ea · 2025-06-17T17:51:25.000-04:00
diff --git a/lib/AST/GenericSignature.cpp b/lib/AST/GenericSignature.cpp
@@ -1436,7 +1436,8 @@ RequirementSignature RequirementSignature::getPlaceholderRequirementSignature(
                        });
 
   return RequirementSignature(ctx.AllocateCopy(requirements),
-                              ArrayRef<ProtocolTypeAlias>());
+                              ArrayRef<ProtocolTypeAlias>(),
+                              errors);
 }
 
 void RequirementSignature::getRequirementsWithInverses(
diff --git a/validation-test/compiler_crashers_2_fixed/b93e9e54c72f13c9.swift b/validation-test/compiler_crashers_2_fixed/b93e9e54c72f13c9.swift
@@ -1,5 +1,5 @@
 // {"signature":"swift::rewriting::RewriteSystem::processTypeDifference(swift::rewriting::TypeDifference const&, unsigned int, unsigned int, swift::rewriting::RewritePath const&)"}
-// RUN: not --crash %target-swift-frontend -typecheck %s
+// RUN: not %target-swift-frontend -typecheck %s
 class a < b class c<b, h> : a<(b, h)> protocol d {
   associatedtype b : c<e, f> associatedtype e associatedtype f associatedtype b
       : a<g>

Original file line number	Diff line number	Diff line change
`@@ -1436,7 +1436,8 @@ RequirementSignature RequirementSignature::getPlaceholderRequirementSignature(`
`1436`	`1436`	`});`
`1437`	`1437`
`1438`	`1438`	`return RequirementSignature(ctx.AllocateCopy(requirements),`
`1439`		`- ArrayRef<ProtocolTypeAlias>());`
	`1439`	`+ ArrayRef<ProtocolTypeAlias>(),`
	`1440`	`+ errors);`
`1440`	`1441`	`}`
`1441`	`1442`
`1442`	`1443`	`void RequirementSignature::getRequirementsWithInverses(`