Merge remote-tracking branch 'origin/main' into rebranch

Author: swift-ci

lib/Sema/PreCheckTarget.cpp

@@ -1315,8 +1315,9 @@ class PreCheckTarget final : public ASTWalker {
           lastInnerParenLoc = PE->getLParenLoc();
           parent = nextParent;
         }
-
-        if (isa<ApplyExpr>(parent) || isa<UnresolvedMemberExpr>(parent)) {
+        
+        if (isa<ApplyExpr>(parent) || isa<UnresolvedMemberExpr>(parent) ||
+            isa<MacroExpansionExpr>(parent)) {
           // If outermost paren is associated with a call or
           // a member reference, it might be valid to have `&`
           // before all of the parens.

test/Macros/Inputs/syntax_macro_definitions.swift

@@ -240,6 +240,15 @@ public class TupleMacro: ExpressionMacro {
   }
 }
 
+public class VoidExpressionMacro: ExpressionMacro {
+  public static func expansion(
+    of macro: some FreestandingMacroExpansionSyntax,
+    in context: some MacroExpansionContext
+  ) -> ExprSyntax {
+    return "()"
+  }
+}
+
 enum CustomError: Error, CustomStringConvertible {
   case message(String)
 

test/Macros/top_level_freestanding.swift

@@ -145,3 +145,23 @@ struct S {
 #checkGeneric<String>()
 #checkGeneric2<String, Int>()
 #checkGenericHashableCodable<String, Int>()
+
+// Check that inout parameters are allowed in expression macros
+
+@freestanding(expression) macro functionCallWithInoutParam(_ v: inout Int)
+  = #externalMacro(module: "MacroDefinition", type: "VoidExpressionMacro")
+
+@freestanding(expression) macro functionCallWithTwoInoutParams(_ u: inout Int, _ v: inout Int)
+  = #externalMacro(module: "MacroDefinition", type: "VoidExpressionMacro")
+
+@freestanding(expression) macro functionCallWithInoutParamPlusOthers(
+  string: String, double: Double, _ v: inout Int)
+  = #externalMacro(module: "MacroDefinition", type: "VoidExpressionMacro")
+
+func testFunctionCallWithInoutParam() {
+  var a = 0
+  var b = 0
+  #functionCallWithInoutParam(&a)
+  #functionCallWithTwoInoutParams(&a, &b)
+  #functionCallWithInoutParamPlusOthers(string: "", double: 1.0, &a)
+}

utils/build.ps1

@@ -2576,7 +2576,8 @@ function Test-Foundation {
       -Src $SourceCache\swift-corelibs-foundation `
       -Bin "$BinaryCache\$($BuildPlatform.Triple)\FoundationTests" `
       -Platform $BuildPlatform `
-      -Configuration $FoundationTestConfiguration
+      -Configuration $FoundationTestConfiguration `
+      -j 1
   }
 }