Update clean_benchmarks.py #1317
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to f8e939d in 38 seconds. Click for details.
- Reviewed
79lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. scripts/clean_benchmarks.py:14
- Draft comment:
Consider renaming the 'confirm' option (and its help text) for clarity. Its behavior (skipping confirmation when true) may be non-intuitive. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. scripts/clean_benchmarks.py:34
- Draft comment:
The confirmation prompt is issued for each file/folder deletion. Consider a bulk confirmation option for improved user experience when many items are present. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. scripts/clean_benchmarks.py:33
- Draft comment:
Catching a generic Exception may mask specific issues. Consider handling particular exceptions (e.g., FileNotFoundError, PermissionError) for more precise error reporting. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_9JWBkEJ5klGq4mCq
You can customize 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Enhance
clean_benchmarks.pywith Typer CLI, confirmation prompts, and error handling for cleaning benchmark directories.clean_benchmarks.py.cleancommand withconfirmoption to skip confirmation prompts.confirmis set toTrue.This description was created by
for f8e939d. You can customize this summary. It will automatically update as commits are pushed.