Skip to content

Suggestion: warn on using EqualExportedValues for proto messages #282

@alfa-alex

Description

@alfa-alex

This might not be suitable for everyone, but the ability to turn on this functionality would be nice:

Currently, assert.EqualExportedValues is often used to compare proto messages for equality. With the new Opaque API of proto, all fields will be unexported, so this assertion will assert nothing.

The problem is that people might migrate from the open to the opaque API without noticing that they still have these assertions in their tests. So having testifylint warn you about it is a useful feature in my opinion.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions