Skip to content

Commit 4636557

Browse files
author
Anuar Talipov
committed
Fix errors while merging.
1 parent 63b1178 commit 4636557

File tree

2 files changed

+0
-15
lines changed

2 files changed

+0
-15
lines changed

tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_container.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import {
2222
filter,
2323
map,
2424
shareReplay,
25-
shareReplay,
2625
startWith,
2726
take,
2827
} from 'rxjs/operators';
@@ -34,7 +33,6 @@ import {
3433
getColorGroupRegexString,
3534
getRunIdsForExperiment,
3635
getRunGroupBy,
37-
getRunGroupBy,
3836
getRuns,
3937
} from '../../store/runs_selectors';
4038
import {groupRuns} from '../../store/utils';
@@ -50,11 +48,8 @@ const INPUT_CHANGE_DEBOUNCE_INTERVAL_MS = 500;
5048
[colorRunPairList]="colorRunPairList$ | async"
5149
[selectedGroupBy]="groupByRegexType$ | async"
5250
(onSave)="onSave()"
53-
[selectedGroupBy]="groupByRegexType$ | async"
54-
(onSave)="onSave()"
5551
(regexInputOnChange)="onRegexInputOnChange($event)"
5652
(regexTypeOnChange)="onRegexTypeOnChange($event)"
57-
(regexTypeOnChange)="onRegexTypeOnChange($event)"
5853
></regex-edit-dialog-component>`,
5954
styles: [
6055
`
@@ -70,7 +65,6 @@ const INPUT_CHANGE_DEBOUNCE_INTERVAL_MS = 500;
7065
export class RegexEditDialogContainer {
7166
private readonly experimentIds: string[];
7267
private readonly expNameByExpId: Record<string, string>;
73-
private readonly expNameByExpId: Record<string, string>;
7468
private readonly runIdToEid$: Observable<Record<string, string>>;
7569
private readonly allRuns$: Observable<Run[]>;
7670
private readonly tentativeRegexString$: Subject<string> =
@@ -127,7 +121,6 @@ export class RegexEditDialogContainer {
127121
darkModeEanbled,
128122
]) => {
129123
const groupBy = {
130-
key: regexType,
131124
key: regexType,
132125
regexString,
133126
};
@@ -170,7 +163,6 @@ export class RegexEditDialogContainer {
170163
) {
171164
this.experimentIds = data.experimentIds;
172165
this.expNameByExpId = data.expNameByExpId;
173-
this.expNameByExpId = data.expNameByExpId;
174166

175167
this.runIdToEid$ = combineLatest(
176168
this.experimentIds.map((experimentId) => {

tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_test.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ describe('regex_edit_dialog', () => {
8383
) {
8484
TestBed.overrideProvider(MAT_DIALOG_DATA, {
8585
useValue: {experimentIds, expNameByExpId},
86-
useValue: {experimentIds, expNameByExpId},
8786
});
8887

8988
store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
@@ -183,14 +182,8 @@ describe('regex_edit_dialog', () => {
183182
const matSelect = fixture.debugElement.query(By.css('mat-select'));
184183
matSelect.triggerEventHandler('selectionChange', {value: 'regex_by_exp'});
185184

186-
console.log('hello');
187-
188-
const matSelect = fixture.debugElement.query(By.css('mat-select'));
189-
matSelect.triggerEventHandler('selectionChange', {value: 'regex_by_exp'});
190-
191185
const input = fixture.debugElement.query(By.css('input'));
192186
const keyArgs: SendKeyArgs = {
193-
key: 'test',
194187
key: 'test',
195188
prevString: '',
196189
type: KeyType.CHARACTER,

0 commit comments

Comments
 (0)