improve opbeat and some istabul ignores

Author: Amoki

lib/helpers/hydrater.js

@@ -52,12 +52,9 @@ module.exports = function(hydraterFunction, childs, logger, errLogger) {
           if(!cleaner.called) {
             cleaner.called = true;
             if(err) {
-              var extra = {
-                stdout: stdout,
-                stderr: stderr,
-              };
-              extra.task = JSON.stringify(task);
-              extra.task = JSON.parse(extra.task);
+              var extra = JSON.parse(JSON.stringify(task));
+              extra.stdout = stdout;
+              extra.stderr = stderr;
 
               logError(err, extra);
               child.reset();
@@ -197,9 +194,7 @@ module.exports = function(hydraterFunction, childs, logger, errLogger) {
       async.waterfall([
         function logErrors(cb) {
           if(err) {
-            var extra = {};
-            extra.task = JSON.stringify(task);
-            extra.task = JSON.parse(extra.task);
+            var extra = JSON.parse(JSON.stringify(task));
             logError(err, extra);
             errLogger("ERR hydrating " + ((task.file_path) ? task.file_path : task.document.id), err.toString());
           }
@@ -226,10 +221,9 @@ module.exports = function(hydraterFunction, childs, logger, errLogger) {
           }
         }
       ], function(internalErr) {
+        /* istanbul ignore next */
         if(internalErr) {
-          var extra = {};
-          extra.task = JSON.stringify(task);
-          extra.task = JSON.parse(extra.task);
+          var extra = JSON.parse(JSON.stringify(task));
           logError(internalErr, extra);
           errLogger("INTERNAL ERR", internalErr);
         }

lib/index.js

@@ -26,6 +26,7 @@ module.exports.createServer = function(config) {
 
   utils.logError.config = config;
 
+  /* istanbul ignore next */
   if(config.opbeat && config.opbeat.secretToken) {
     var opbeat = require('opbeat');
     utils.logError.opbeat = opbeat(config.opbeat);