feat(eslint-config): unify react function component style

Author: rozsival

packages/eslint-config/src/nextjs/config.ts

@@ -22,27 +22,19 @@ export const config = (apps = ['.']): Linter.Config[] => [
     },
   },
   {
-    files: apps.map((app) => [`${app}/src/app/**/*.{ts,tsx}`, `${app}/src/pages/**/*.{ts,tsx}`]).flat(),
-    rules: {
-      'react/function-component-definition': [
-        // Allow components as function declarations in Next.js App and Page components for shorthand default exports
-        'error',
-        {
-          namedComponents: ['arrow-function', 'function-declaration'],
-          unnamedComponents: 'function-expression',
-        },
-      ],
-    },
-  },
-  {
-    files: apps.map((app) => [`${app}/app/**/layout.tsx`, `${app}/src/**/layouts/**/*.tsx`]).flat(),
+    files: apps.map((app) => [`${app}/src/**/layout.tsx`, `${app}/src/**/layouts/**/*.tsx`]).flat(),
     rules: {
       '@next/next/no-head-element': 'off', // Allow <head/> element in Next.js App layouts
     },
   },
   {
     files: apps
-      .map((app) => [`${app}/src/**/layouts/**/*.tsx`, `${app}/src/pages/_app.tsx`, `${app}/src/pages/_document.tsx`])
+      .map((app) => [
+        `${app}/src/**/layout.tsx`,
+        `${app}/src/**/layouts/**/*.tsx`,
+        `${app}/src/pages/_app.tsx`,
+        `${app}/src/pages/_document.tsx`,
+      ])
       .flat(),
     rules: {
       'react/jsx-props-no-spreading': 'off', // Allow spreading props in Next.js App layouts, _app.tsx and _document.tsx

packages/eslint-config/src/react/rules/common.ts

@@ -5,7 +5,7 @@ export const common: Linter.RulesRecord = {
     // Prefer arrow functions for React components and avoid unnamed components with function expressions
     'error',
     {
-      namedComponents: ['arrow-function'],
+      namedComponents: ['arrow-function', 'function-declaration'],
       unnamedComponents: 'function-expression',
     },
   ],