Merge pull request #37 from Apokee/topic/fix_configuration_reverting

Fix configuration reverting

Author: dbent

CHANGES.md

@@ -1,4 +1,6 @@
 ## v0.4.1-alpha
+##### Fixes
+- Fix for configuration settings reverting to default after two reloads of KSP.
 
 ## v0.4.0
 ##### New

Source/HotSpot/Configuration/ContextMenu/MetricNode.cs

@@ -5,40 +5,23 @@ namespace HotSpot.Configuration.ContextMenu
 {
     internal sealed class MetricNode
     {
-        private readonly bool _origEnable;
-        private readonly Unit _origUnit;
-
         public Metric Name { get; }
         public bool Enable { get; set; }
         public Unit Unit { get; set; }
 
         private MetricNode(Metric name, bool enable, Unit unit)
         {
-            _origEnable = enable;
-            _origUnit = unit;
-
             Name = name;
             Enable = enable;
             Unit = unit;
         }
 
         public bool Save(ConfigNode node)
         {
-            var save = false;
-
-            if (_origEnable != Enable)
-            {
-                node.AddValue("%enable", Enable);
-                save = true;
-            }
-
-            if (_origUnit != Unit)
-            {
-                node.AddValue("%unit", Unit);
-                save = true;
-            }
+            node.AddValue("%enable", Enable);
+            node.AddValue("%unit", Unit);
 
-            return save;
+            return true;
         }
 
         public static MetricNode TryParse(ConfigNode node)

Source/HotSpot/Configuration/Overlay/MetricNode.cs

@@ -7,8 +7,6 @@ namespace HotSpot.Configuration.Overlay
 {
     internal sealed class MetricNode
     {
-        private readonly string _origScheme;
-
         private readonly Dictionary<string, SchemeNode> _schemesDictionary;
 
         public Metric Name { get; }
@@ -17,8 +15,6 @@ internal sealed class MetricNode
 
         private MetricNode(Metric name, string scheme, SchemeNode[] schemes)
         {
-            _origScheme = scheme;
-
             Name = name;
             Scheme = scheme;
             Schemes = schemes;
@@ -32,15 +28,9 @@ public SchemeNode GetActiveScheme()
 
         public bool Save(ConfigNode node)
         {
-            var save = false;
-
-            if (_origScheme != Scheme)
-            {
-                node.AddValue("%scheme", Scheme);
-                save = true;
-            }
+            node.AddValue("%scheme", Scheme);
 
-            return save;
+            return true;
         }
 
         public static MetricNode TryParse(ConfigNode node)

Source/HotSpot/Configuration/OverlayNode.cs

@@ -10,17 +10,13 @@ internal sealed class OverlayNode
     {
         private readonly Dictionary<string, MetricNode> _metricsDictionary;
 
-        private readonly string _origMetric;
-
         public bool Enable { get; }
         public bool EnableScreenMessage { get; }
         public Metric Metric { get; set; }
         public MetricNode[] Metrics { get; }
 
         private OverlayNode(bool enable, bool enableScreenMessage, Metric metric, MetricNode[] metrics)
         {
-            _origMetric = metric.Name;
-
             Enable = enable;
             EnableScreenMessage = enableScreenMessage;
             Metric = metric;
@@ -35,13 +31,7 @@ public MetricNode GetActiveMetric()
 
         public bool Save(ConfigNode node)
         {
-            var save = false;
-
-            if (_origMetric != Metric.Name)
-            {
-                node.AddValue("%metric", Metric.Name);
-                save = true;
-            }
+            node.AddValue("%metric", Metric.Name);
 
             foreach (var metric in Metrics)
             {
@@ -50,11 +40,10 @@ public bool Save(ConfigNode node)
                 if (metric.Save(metricNode))
                 {
                     node.AddNode(metricNode);
-                    save = true;
                 }
             }
 
-            return save;
+            return true;
         }
 
         public static OverlayNode GetDefault()