Merge pull request #18 from ApolloAuto/xiaoxq-patch-1

quning18 · web-flow · commit c24806f4f11f · 2017-08-31T17:14:11.000-07:00
Fix use-after-free bug of DataType value.
diff --git a/ros/roscpp_core/roscpp_traits/include/ros/protobuffer_traits.h b/ros/roscpp_core/roscpp_traits/include/ros/protobuffer_traits.h
@@ -69,7 +69,7 @@ struct MD5Sum<T, typename boost::enable_if<boost::is_base_of< ::google::protobuf
 {
   static const char* value() 
   {
-    std::string data_type(DataType<T>::value(), strlen(DataType<T>::value()));
+    std::string data_type(DataType<T>::value());
     if (type_md5_map.count(data_type) == 0) 
     {
       type_md5_map[data_type] = ros::md5::MD5(data_type).toStr();

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ struct MD5Sum<T, typename boost::enable_if<boost::is_base_of< ::google::protobuf`
`69`	`69`	`{`
`70`	`70`	`static const char* value()`
`71`	`71`	`{`
`72`		`- std::string data_type(DataType<T>::value(), strlen(DataType<T>::value()));`
	`72`	`+ std::string data_type(DataType<T>::value());`
`73`	`73`	`if (type_md5_map.count(data_type) == 0)`
`74`	`74`	`{`
`75`	`75`	`type_md5_map[data_type] = ros::md5::MD5(data_type).toStr();`