Enable all plugins by default, if not explicitly configured.

Author: prochnowc

Hosting/src/AppCoreNet.Extensions.Hosting.Plugins/PluginManager.cs

@@ -155,6 +155,10 @@ bool IsPluginEnabled(string pluginName)
 #pragma warning restore CS0612 // Type or member is obsolete
                 return false;
 
+            // if there is no explicit config, all plugins are enabled
+            if (_options.Enabled.Count == 0)
+                return true;
+
             if (!_options.Enabled.TryGetValue(pluginName, out bool enabled))
                 enabled = allPluginsEnabled;
 

Hosting/test/AppCoreNet.Extensions.Hosting.Plugins.Tests/PluginFacilityResolverTests.cs

@@ -27,7 +27,6 @@ public void RegistersFacilitiesWithExtensions()
                     {
                         o.Assemblies.Add(PluginPaths.TestPlugin);
                         o.Assemblies.Add(PluginPaths.TestPlugin2);
-                        o.Enabled["*"] = true;
                     });
 
         services.AddFacilitiesFrom(
@@ -67,7 +66,6 @@ public void RegistersFacilities()
                     {
                         o.Assemblies.Add(PluginPaths.TestPlugin);
                         o.Assemblies.Add(PluginPaths.TestPlugin2);
-                        o.Enabled["*"] = true;
                     });
 
         services.AddFacilitiesFrom(s => s.Plugins());
@@ -93,7 +91,6 @@ public void RegistersFacilityWithServices()
                     o =>
                     {
                         o.Assemblies.Add(PluginPaths.TestPlugin);
-                        o.Enabled["*"] = true;
                     });
 
         services.AddFacilitiesFrom(s => s.Plugins());

Hosting/test/AppCoreNet.Extensions.Hosting.Plugins.Tests/PluginManagerTests.cs

@@ -22,7 +22,6 @@ public void ResolveAllPublicInstancesFromPlugins()
         var pluginOptions = new PluginOptions
         {
             Assemblies = { PluginPaths.TestPlugin, PluginPaths.TestPlugin2 },
-            Enabled = { { "*", true } },
         };
 
         var manager = new PluginManager(new DefaultActivator(), Options.Create(pluginOptions));
@@ -49,7 +48,6 @@ public void ResolveAllInstancesFromPlugins()
         {
             ResolvePrivateTypes = true,
             Assemblies = { PluginPaths.TestPlugin, PluginPaths.TestPlugin2 },
-            Enabled = { { "*", true } },
         };
 
         var manager = new PluginManager(new DefaultActivator(), Options.Create(pluginOptions));
@@ -82,7 +80,6 @@ public void GetAllPlugins()
         var options = new PluginOptions();
         options.Assemblies.Add(PluginPaths.TestPlugin);
         options.Assemblies.Add(PluginPaths.TestPlugin2);
-        options.Enabled["*"] = true;
 
         var manager = new PluginManager(new DefaultActivator(), Options.Create(options));
         manager.Plugins.Select(p => p.Info)
@@ -195,6 +192,20 @@ public void DoesNotLoadExplicitlyDisabled()
                .HaveCount(1);
     }
 
+    [Fact]
+    public void LoadsAllPluginsWithoutExplicitConfig()
+    {
+        var options = new PluginOptions();
+        options.Assemblies.Add(PluginPaths.TestPlugin);
+        options.Assemblies.Add(PluginPaths.TestPlugin2);
+
+        var manager = new PluginManager(new DefaultActivator(), Options.Create(options));
+        manager.LoadPlugins();
+
+        manager.Plugins.Should()
+               .HaveCount(2);
+    }
+
     [Fact]
     public void LoadsAllPlugins()
     {

Hosting/test/AppCoreNet.Extensions.Hosting.Plugins.Tests/PluginServiceDescriptorResolverTests.cs

@@ -26,7 +26,6 @@ public void RegistersServices()
                     {
                         o.Assemblies.Add(PluginPaths.TestPlugin);
                         o.Assemblies.Add(PluginPaths.TestPlugin2);
-                        o.Enabled["*"] = true;
                     });
 
         services.TryAddEnumerableFrom<IStartupTask>(s => s.Plugins());