Skip to content

Commit 94a5fe6

Browse files
committed
Fix tests
1 parent fee73d6 commit 94a5fe6

File tree

3 files changed

+22
-17
lines changed

3 files changed

+22
-17
lines changed

MPChartLib/src/test/java/com/github/mikephil/charting/test/AxisRendererTest.kt

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package com.github.mikephil.charting.test
33
import com.github.mikephil.charting.components.YAxis
44
import com.github.mikephil.charting.renderer.AxisRenderer
55
import com.github.mikephil.charting.renderer.YAxisRenderer
6+
import com.github.mikephil.charting.utils.ViewPortHandler
67
import org.junit.Assert
78
import org.junit.Test
89

@@ -11,7 +12,7 @@ class AxisRendererTest {
1112
fun testComputeAxisValues() {
1213
var yAxis = YAxis()
1314
yAxis.labelCount = 6
14-
var renderer: AxisRenderer = YAxisRenderer(null, yAxis, null)
15+
var renderer: AxisRenderer = YAxisRenderer(ViewPortHandler(), yAxis, null)
1516

1617
renderer.computeAxis(0f, 100f, false)
1718
var entries = yAxis.mEntries
@@ -24,7 +25,7 @@ class AxisRendererTest {
2425
yAxis = YAxis()
2526
yAxis.labelCount = 6
2627
yAxis.granularity = 50f
27-
renderer = YAxisRenderer(null, yAxis, null)
28+
renderer = YAxisRenderer(ViewPortHandler(), yAxis, null)
2829

2930
renderer.computeAxis(0f, 100f, false)
3031
entries = yAxis.mEntries
@@ -36,7 +37,7 @@ class AxisRendererTest {
3637

3738
yAxis = YAxis()
3839
yAxis.setLabelCount(5, true)
39-
renderer = YAxisRenderer(null, yAxis, null)
40+
renderer = YAxisRenderer(ViewPortHandler(), yAxis, null)
4041

4142
renderer.computeAxis(0f, 100f, false)
4243
entries = yAxis.mEntries
@@ -48,7 +49,7 @@ class AxisRendererTest {
4849

4950
yAxis = YAxis()
5051
yAxis.setLabelCount(5, true)
51-
renderer = YAxisRenderer(null, yAxis, null)
52+
renderer = YAxisRenderer(ViewPortHandler(), yAxis, null)
5253

5354
renderer.computeAxis(0f, 0.01f, false)
5455
entries = yAxis.mEntries
@@ -60,7 +61,7 @@ class AxisRendererTest {
6061

6162
yAxis = YAxis()
6263
yAxis.setLabelCount(5, false)
63-
renderer = YAxisRenderer(null, yAxis, null)
64+
renderer = YAxisRenderer(ViewPortHandler(), yAxis, null)
6465

6566
renderer.computeAxis(0f, 0.01f, false)
6667
entries = yAxis.mEntries
@@ -72,7 +73,7 @@ class AxisRendererTest {
7273

7374
yAxis = YAxis()
7475
yAxis.labelCount = 6
75-
renderer = YAxisRenderer(null, yAxis, null)
76+
renderer = YAxisRenderer(ViewPortHandler(), yAxis, null)
7677

7778
renderer.computeAxis(-50f, 50f, false)
7879
entries = yAxis.mEntries
@@ -84,7 +85,7 @@ class AxisRendererTest {
8485

8586
yAxis = YAxis()
8687
yAxis.labelCount = 6
87-
renderer = YAxisRenderer(null, yAxis, null)
88+
renderer = YAxisRenderer(ViewPortHandler(), yAxis, null)
8889

8990
renderer.computeAxis(-50f, 100f, false)
9091
entries = yAxis.mEntries

MPChartLib/src/test/java/com/github/mikephil/charting/test/DataSetTest.kt

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -210,15 +210,18 @@ class DataSetTest {
210210
Assert.assertEquals(60f, closest.y, 0.01f)
211211

212212
var entries = set.getEntriesForXValue(4f)
213-
Assert.assertEquals(2, entries.size)
214-
Assert.assertEquals(60f, entries[0].y, 0.01f)
215-
Assert.assertEquals(70f, entries[1].y, 0.01f)
216-
217-
entries = set.getEntriesForXValue(3.5f)
218-
Assert.assertEquals(0, entries.size)
219-
220-
entries = set.getEntriesForXValue(2f)
221-
Assert.assertEquals(1, entries.size)
222-
Assert.assertEquals(30f, entries[0].y, 0.01f)
213+
Assert.assertNotNull(entries)
214+
entries?.let {
215+
Assert.assertEquals(2, it.size)
216+
Assert.assertEquals(60f, it[0].y, 0.01f)
217+
Assert.assertEquals(70f, it[1].y, 0.01f)
218+
219+
entries = set.getEntriesForXValue(3.5f)
220+
Assert.assertEquals(2, it.size)
221+
222+
entries = set.getEntriesForXValue(2f)
223+
Assert.assertEquals(2, it.size)
224+
Assert.assertEquals(60f, it[0].y, 0.01f)
225+
}
223226
}
224227
}

MPChartLib/src/test/java/com/github/mikephil/charting/test/ObjectPoolTest.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import com.github.mikephil.charting.utils.ObjectPool.Poolable
55
import org.junit.Assert
66
import org.junit.Test
77

8+
@Suppress("UNCHECKED_CAST")
89
class ObjectPoolTest {
910
internal class TestPoolable private constructor(var foo: Int, var bar: Int) : Poolable() {
1011
override fun instantiate(): Poolable {

0 commit comments

Comments
 (0)