Skip to content

Conversation

@daniel-marcus-kroger
Copy link

@daniel-marcus-kroger daniel-marcus-kroger commented Apr 11, 2025

This adds the ability to shade ranges on the Y axis, very similar to limit lines.

In order to demonstrate the functionality, I have also updated the demo chart.

image

@hannesa2
Copy link
Collaborator

Nice !
Unfortunately the screenshot compare job failed on missing CLASSIC_TOKEN
image

To enable this, it would be nice, if you can add such a variable in your fork
image

To do this, you need in your github user Settings->Developer settings this
image

and then please rerun the action

@hannesa2
Copy link
Collaborator

I made a pull request with your commit #345 in the upstream repo, because here the screenshot compare is working.
Either I merge this #345 where I'm the owner of the pull request or you do #341 (comment) and we merge this one. It's your decison

@hannesa2
Copy link
Collaborator

I see that in your original version labels are fine
image

@hannesa2 hannesa2 force-pushed the master branch 2 times, most recently from a96d26d to d07bee7 Compare April 18, 2025 08:53
@hannesa2
Copy link
Collaborator

merged with #345
Thanks a lot !

@hannesa2 hannesa2 closed this Apr 18, 2025
@hannesa2
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants