Enable vertical limit range shading #345
Conversation
|
Looks good |
hannesa2
force-pushed
the
limit-range
branch
4 times, most recently
from
5778cf8 to
7c3981c
Compare
|
Thank you very much, it's good to see how the screenshot compare testing works! More than happy to have this version merged! |
hannesa2
force-pushed
the
limit-range
branch
9 times, most recently
from
408711a to
559e3c5
Compare
|
@hannesa2 , it looks like this PR has the renderer code converted to Kotlin (looks nice!) but is resulting in some failures on API level 9, if I am reading the completely black rectangle correctly. Is there anything you'd like me to do to help shore this up? |
hannesa2
force-pushed
the
limit-range
branch
2 times, most recently
from
dae3fcf to
8ad7321
Compare
|
Unfortunately I didn't merged as it was working properly and I merged some Kotlin conversions in advance. This was not good. But it's now like it is. Black screenshot means that there is a crash. I fixed the crash now |
hannesa2
force-pushed
the
limit-range
branch
3 times, most recently
from
fc69e03 to
80ef8b7
Compare
|
Hmm, but I see it
Any help is welcome @daniel-marcus-kroger |
|
@hannesa2 My apologies for the delayed reply, I was out of the office for a couple of days. It looks like you got everything working. I will make sure to use the new Kotlin versions if I implement this for vertical region shading, and that will hopefully be much easier to merge! |
It's a follow up of #341 with screenshot compare
@daniel-marcus-kroger