chore: to string

Author: appflowy

collab-database/src/fields/type_option/relation_type_option.rs

@@ -48,6 +48,6 @@ impl TypeOptionCellReader for RelationTypeOption {
 impl TypeOptionCellWriter for RelationTypeOption {
   fn convert_json_to_cell(&self, json_value: Value) -> Cell {
     let cell_data = serde_json::from_value::<RelationCellData>(json_value).unwrap_or_default();
-    Cell::from(&cell_data)
+    Cell::from(cell_data)
   }
 }

collab-database/src/template/check_list_parse.rs

@@ -6,8 +6,6 @@ use crate::template::entity::CELL_DATA;
 use crate::template::util::TypeOptionCellData;
 use collab::util::AnyMapExt;
 use serde::{Deserialize, Serialize};
-use std::fmt;
-use std::fmt::{Display, Formatter};
 
 #[derive(Default, Clone, Debug, Serialize, Deserialize)]
 pub struct ChecklistCellData {
@@ -16,9 +14,14 @@ pub struct ChecklistCellData {
   pub selected_option_ids: Vec<String>,
 }
 
-impl Display for ChecklistCellData {
-  fn fmt(&self, f: &mut Formatter) -> fmt::Result {
-    write!(f, "{:?}", self)
+impl ToString for ChecklistCellData {
+  fn to_string(&self) -> String {
+    let selected_options: Vec<String> = self
+      .selected_options()
+      .iter()
+      .map(|option| option.name.clone())
+      .collect();
+    selected_options.join(", ")
   }
 }
 

collab-database/src/template/relation_parse.rs

@@ -37,12 +37,11 @@ impl From<&Cell> for RelationCellData {
   }
 }
 
-impl From<&RelationCellData> for Cell {
-  fn from(value: &RelationCellData) -> Self {
+impl From<RelationCellData> for Cell {
+  fn from(value: RelationCellData) -> Self {
     let data = Any::Array(Arc::from(
       value
         .row_ids
-        .clone()
         .into_iter()
         .map(|id| Any::String(Arc::from(id.to_string())))
         .collect::<Vec<_>>(),
@@ -67,3 +66,20 @@ impl From<&str> for RelationCellData {
     RelationCellData { row_ids: ids }
   }
 }
+
+impl From<String> for RelationCellData {
+  fn from(s: String) -> Self {
+    RelationCellData::from(s.as_str())
+  }
+}
+
+impl ToString for RelationCellData {
+  fn to_string(&self) -> String {
+    self
+      .row_ids
+      .iter()
+      .map(|id| id.to_string())
+      .collect::<Vec<_>>()
+      .join(", ")
+  }
+}