chore: turn on yrs gc by default (#414)

* chore: turn on yrs gc by default

* chore: fix tests for revisiomn

Author: Horusiath

collab/src/core/collab.rs

@@ -264,7 +264,7 @@ impl CollabOptions {
       object_id,
       data_source: None,
       client_id,
-      skip_gc: true,
+      skip_gc: false,
     }
   }
 

collab/tests/edit_test/revision_test.rs

@@ -1,5 +1,5 @@
 use collab::core::collab::{CollabOptions, DataSource, default_client_id};
-use collab::core::origin::CollabOrigin;
+use collab::core::origin::{CollabClient, CollabOrigin};
 use collab::entity::EncoderVersion;
 use collab::preclude::Collab;
 use serde_json::json;
@@ -8,7 +8,11 @@ use yrs::updates::decoder::Decode;
 
 #[tokio::test]
 async fn create_restore_revision() {
-  let mut collab = Collab::new(1, "1", "1", default_client_id());
+  let mut collab = Collab::new_with_options(
+    CollabOrigin::Client(CollabClient::new(1, "1".to_string())),
+    CollabOptions::new("1".into(), default_client_id()).with_gc(false),
+  )
+  .unwrap();
   collab.insert("key", "value1");
   let state1 = collab
     .encode_collab_v1(|_| Ok::<_, anyhow::Error>(()))
@@ -37,7 +41,11 @@ async fn create_restore_revision() {
 
 #[tokio::test]
 async fn remove_revision_cleanups_deleted_data() {
-  let mut collab = Collab::new(1, "1", "1", default_client_id());
+  let mut collab = Collab::new_with_options(
+    CollabOrigin::Client(CollabClient::new(1, "1".to_string())),
+    CollabOptions::new("1".into(), default_client_id()).with_gc(false),
+  )
+  .unwrap();
   collab.insert("key", "value1");
   let r1 = collab.create_named_revision("r1").unwrap();
   collab.insert("key", "value2");
@@ -70,7 +78,11 @@ async fn remove_revision_cleanups_deleted_data() {
 
 #[tokio::test]
 async fn remove_revision_should_eventually_remove_revision_data() {
-  let mut collab = Collab::new(1, "1", "1", default_client_id());
+  let mut collab = Collab::new_with_options(
+    CollabOrigin::Client(CollabClient::new(1, "1".to_string())),
+    CollabOptions::new("1".into(), default_client_id()).with_gc(false),
+  )
+  .unwrap();
   collab.insert("key", "value1");
   let r1 = collab.create_named_revision("revision1").unwrap();
   collab.insert("key", "value2");
@@ -101,7 +113,11 @@ async fn remove_revision_should_eventually_remove_revision_data() {
 
 #[tokio::test]
 async fn cleaning_all_revisions_doesnt_leave_garbage() {
-  let mut collab = Collab::new(1, "1", "1", default_client_id());
+  let mut collab = Collab::new_with_options(
+    CollabOrigin::Client(CollabClient::new(1, "1".to_string())),
+    CollabOptions::new("1".into(), default_client_id()).with_gc(false),
+  )
+  .unwrap();
   collab.insert("key", "value1");
   let r1 = collab.create_named_revision("revision1").unwrap();
   collab.insert("key", "value2");
@@ -128,14 +144,22 @@ async fn cleaning_all_revisions_doesnt_leave_garbage() {
 
 #[tokio::test]
 async fn remote_updates_can_be_cleaned_up() {
-  let mut c1 = Collab::new(1, "1", "1", default_client_id());
+  let mut c1 = Collab::new_with_options(
+    CollabOrigin::Client(CollabClient::new(1, "1".to_string())),
+    CollabOptions::new("1".into(), default_client_id()).with_gc(false),
+  )
+  .unwrap();
   c1.insert("key", "value1");
   let r1 = c1.create_named_revision("revision1").unwrap();
   c1.insert("key", "value2");
   let _r2 = c1.create_named_revision("revision2").unwrap();
   c1.insert("key", "value3");
 
-  let mut c2 = Collab::new(1, "1", "2", default_client_id());
+  let mut c2 = Collab::new_with_options(
+    CollabOrigin::Client(CollabClient::new(1, "2".to_string())),
+    CollabOptions::new("1".into(), default_client_id()).with_gc(false),
+  )
+  .unwrap();
   let state = c1.encode_collab_v2();
   c2.apply_update(Update::decode_v2(&state.doc_state).unwrap())
     .unwrap();