fix: avoid infinite recusion due to cyclic dependency

Author: khorshuheng

collab-folder/src/folder.rs

@@ -1,5 +1,5 @@
 use std::borrow::{Borrow, BorrowMut};
-use std::collections::HashMap;
+use std::collections::{HashMap, HashSet};
 use std::ops::{Deref, DerefMut};
 use std::sync::Arc;
 
@@ -406,7 +406,9 @@ impl Folder {
   /// * `Vec<View>`: A vector of `View` objects that includes the parent view and all of its child views.
   pub fn get_view_recursively(&self, view_id: &str) -> Vec<View> {
     let txn = self.collab.transact();
-    self.body.get_view_recursively_with_txn(&txn, view_id)
+    self
+      .body
+      .get_view_recursively_with_txn(&txn, view_id, &mut HashSet::default())
   }
 }
 
@@ -596,7 +598,15 @@ impl FolderBody {
   /// # Returns
   ///
   /// * `Vec<View>`: A vector of `View` objects that includes the parent view and all of its child views.
-  pub fn get_view_recursively_with_txn<T: ReadTxn>(&self, txn: &T, view_id: &str) -> Vec<View> {
+  pub fn get_view_recursively_with_txn<T: ReadTxn>(
+    &self,
+    txn: &T,
+    view_id: &str,
+    visited: &mut HashSet<String>,
+  ) -> Vec<View> {
+    if !visited.insert(view_id.to_string()) {
+        return vec![];
+    }
     match self.views.get_view_with_txn(txn, view_id) {
       None => vec![],
       Some(parent_view) => {
@@ -605,7 +615,7 @@ impl FolderBody {
           .children
           .items
           .iter()
-          .flat_map(|child| self.get_view_recursively_with_txn(txn, &child.id))
+          .flat_map(|child| self.get_view_recursively_with_txn(txn, &child.id, visited))
           .collect::<Vec<_>>();
         views.extend(child_views);
         views
@@ -643,7 +653,7 @@ impl FolderBody {
       .map(|view| view.as_ref().clone())
       .collect::<Vec<View>>();
     for view in self.views.get_views_belong_to(txn, workspace_id) {
-      views.extend(self.get_view_recursively_with_txn(txn, &view.id));
+      views.extend(self.get_view_recursively_with_txn(txn, &view.id, &mut HashSet::default()));
     }
     views.extend(orphan_views);