Revert "chore: return update when open folder (#439)" (#440)

This reverts commit b20ee27.

Author: appflowy

collab/src/folder/folder.rs

@@ -92,73 +92,36 @@ pub struct Folder {
   pub body: FolderBody,
 }
 
-/// Result of opening a folder, including any migration update produced while initializing.
-pub struct FolderOpenResult {
-  pub folder: Folder,
-  /// Encoded Yrs update v1 representing changes made during initialization (if any).
-  pub update: Option<Vec<u8>>,
-}
-
-pub struct FolderBodyOpenResult {
-  pub body: FolderBody,
-  pub update: Option<Vec<u8>>,
-}
-
 impl Folder {
-  pub fn open(collab: Collab, notifier: Option<FolderNotify>) -> Result<Self, CollabError> {
-    Self::open_with_update(collab, notifier).map(|result| result.folder)
-  }
-
-  pub fn open_with_update(
-    mut collab: Collab,
-    notifier: Option<FolderNotify>,
-  ) -> Result<FolderOpenResult, CollabError> {
-    let open_result = FolderBody::open(&mut collab, notifier)?;
-    let folder = Folder {
-      collab,
-      body: open_result.body,
-    };
+  pub fn open(mut collab: Collab, notifier: Option<FolderNotify>) -> Result<Self, CollabError> {
+    let body = FolderBody::open(&mut collab, notifier)?;
+    let folder = Folder { collab, body };
     if folder.get_workspace_id().is_none() {
       // When the folder is opened, the workspace id must be present.
       Err(CollabError::FolderMissingRequiredData(
         "missing workspace id".into(),
       ))
     } else {
-      Ok(FolderOpenResult {
-        folder,
-        update: open_result.update,
-      })
+      Ok(folder)
     }
   }
 
   pub fn create(mut collab: Collab, notifier: Option<FolderNotify>, data: FolderData) -> Self {
-    let result = FolderBody::open_with(&mut collab, notifier, Some(data));
-    Folder {
-      collab,
-      body: result.body,
-    }
+    let body = FolderBody::open_with(&mut collab, notifier, Some(data));
+    Folder { collab, body }
   }
 
   pub fn from_collab_doc_state(
     origin: CollabOrigin,
     collab_doc_state: DataSource,
     workspace_id: &str,
     client_id: ClientID,
-  ) -> Result<FolderOpenResult, CollabError> {
-    Self::from_collab_doc_state_with_update(origin, collab_doc_state, workspace_id, client_id)
-  }
-
-  pub fn from_collab_doc_state_with_update(
-    origin: CollabOrigin,
-    collab_doc_state: DataSource,
-    workspace_id: &str,
-    client_id: ClientID,
-  ) -> Result<FolderOpenResult, CollabError> {
+  ) -> Result<Self, CollabError> {
     let workspace_uuid = Uuid::parse_str(workspace_id)
       .map_err(|_| CollabError::Internal(anyhow!("Invalid workspace id format")))?;
     let options = CollabOptions::new(workspace_uuid, client_id).with_data_source(collab_doc_state);
     let collab = Collab::new_with_options(origin, options)?;
-    Self::open_with_update(collab, None)
+    Self::open(collab, None)
   }
 
   pub fn close(&self) {
@@ -1253,10 +1216,7 @@ pub struct FolderBody {
 }
 
 impl FolderBody {
-  pub fn open(
-    collab: &mut Collab,
-    notifier: Option<FolderNotify>,
-  ) -> Result<FolderBodyOpenResult, CollabError> {
+  pub fn open(collab: &mut Collab, notifier: Option<FolderNotify>) -> Result<Self, CollabError> {
     CollabType::Folder.validate_require_data(collab)?;
     Ok(Self::open_with(collab, notifier, None))
   }
@@ -1265,8 +1225,7 @@ impl FolderBody {
     collab: &mut Collab,
     notifier: Option<FolderNotify>,
     folder_data: Option<FolderData>,
-  ) -> FolderBodyOpenResult {
-    let sv = collab.transact().state_vector();
+  ) -> Self {
     let mut txn = collab.context.transact_mut();
     // create the folder
     let root = collab.data.get_or_init_map(&mut txn, FOLDER);
@@ -1333,23 +1292,12 @@ impl FolderBody {
         }
       }
     }
-    let update = {
-      let encoded = txn.encode_diff_v1(&sv);
-      if encoded.is_empty() {
-        None
-      } else {
-        Some(encoded)
-      }
-    };
-    FolderBodyOpenResult {
-      body: Self {
-        root,
-        views,
-        section,
-        meta,
-        notifier,
-      },
-      update,
+    Self {
+      root,
+      views,
+      section,
+      meta,
+      notifier,
     }
   }
 
@@ -1684,7 +1632,6 @@ mod tests {
 
   use crate::core::collab::default_client_id;
   use crate::core::{collab::CollabOptions, origin::CollabOrigin};
-
   use crate::folder::{
     Folder, FolderData, RepeatedViewIdentifier, SectionItem, SpaceInfo, UserId, View,
     ViewIdentifier, ViewLayout, Workspace,

collab/src/folder/folder_diff.rs

@@ -32,8 +32,7 @@ impl Folder {
       encoded_collab.into(),
       &workspace_id,
       client_id,
-    )?
-    .folder;
+    )?;
     let cloned_container = other.body.views.container.clone();
     let sub = {
       let changes = changes.clone();