Skip to content

Commit a6104a3

Browse files
committed
chore: fix test
1 parent 0285345 commit a6104a3

File tree

2 files changed

+41
-14
lines changed

2 files changed

+41
-14
lines changed

cypress/e2e/page/share-page.cy.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { setupCommonExceptionHandlers } from '../../support/exception-handlers';
33
import { v4 as uuidv4 } from 'uuid';
44
import { AuthTestUtils } from '../../support/auth-utils';
55
import { TestTool } from '../../support/page-utils';
6-
import { PageSelectors, WorkspaceSelectors, waitForReactUpdate } from '../../support/selectors';
6+
import { PageSelectors, WorkspaceSelectors, ShareSelectors, waitForReactUpdate } from '../../support/selectors';
77

88
describe('Share Page Test', () => {
99
const { apiUrl, gotrueUrl } = TestConfig;
@@ -57,31 +57,31 @@ describe('Share Page Test', () => {
5757

5858
// 5. Open share dialog
5959
cy.task('log', 'Opening share dialog');
60-
cy.get('[data-testid="share-button"]').first().click({ force: true });
60+
ShareSelectors.shareButton().click();
6161
waitForReactUpdate(500);
6262

6363
// 6. Input user B's email
6464
cy.task('log', `Inviting ${userBEmail} to the page`);
65-
cy.get('[data-testid="share-input"]').type(userBEmail);
65+
ShareSelectors.shareInput().type(userBEmail);
6666
waitForReactUpdate(500);
6767

6868
// 7. Select permission level
69-
cy.get('[data-testid="permission-dropdown"]').click();
70-
cy.get('[data-testid="permission-can-edit"]').click();
69+
ShareSelectors.permissionDropdown().click();
70+
ShareSelectors.permissionCanEdit().click();
7171
waitForReactUpdate(500);
7272

7373
// 8. Click invite button
74-
cy.get('[data-testid="share-invite-button"]').click();
74+
ShareSelectors.shareInviteButton().click();
7575
cy.wait(2000); // Wait for invitation to be sent
7676

7777
// 9. Verify user B appears in the share list
7878
cy.task('log', 'Verifying user B appears in share list');
79-
cy.get('[data-testid="share-member-list"]').should('contain', userBEmail);
79+
ShareSelectors.shareMemberList().should('contain', userBEmail);
8080

8181
// 10. Sign out as user A
8282
cy.task('log', 'Signing out as user A');
8383
WorkspaceSelectors.dropdownTrigger().click();
84-
cy.get('[data-testid="logout-button"]').click();
84+
ShareSelectors.logoutButton().click();
8585
cy.wait(2000);
8686

8787
// 11. Sign in as user B
@@ -98,15 +98,15 @@ describe('Share Page Test', () => {
9898

9999
// 13. Look for the shared page in the sidebar
100100
cy.task('log', 'Looking for shared page');
101-
cy.get('[data-testid="shared-with-me-section"]').click();
101+
ShareSelectors.sharedWithMeSection().click();
102102
cy.wait(1000);
103103
cy.contains(pageTitle).should('exist');
104104
cy.task('log', 'Shared page found');
105105

106106
// 14. Sign out as user B
107107
cy.task('log', 'Signing out as user B');
108108
WorkspaceSelectors.dropdownTrigger().click();
109-
cy.get('[data-testid="logout-button"]').click();
109+
ShareSelectors.logoutButton().click();
110110
cy.wait(2000);
111111

112112
// 15. Sign back in as user A
@@ -127,20 +127,20 @@ describe('Share Page Test', () => {
127127

128128
// 18. Open share dialog again
129129
cy.task('log', 'Opening share dialog to remove user B');
130-
cy.get('[data-testid="share-button"]').click();
130+
ShareSelectors.shareButton().click();
131131
waitForReactUpdate(500);
132132

133133
// 19. Remove user B's access
134134
cy.task('log', 'Removing user B access');
135-
cy.get(`[data-testid="remove-member-${userBEmail}"]`).click();
135+
ShareSelectors.removeMemberButton(userBEmail).click();
136136
cy.wait(2000);
137137

138138
// 20. Verify user B is removed from the share list
139139
cy.task('log', 'Verifying user B is removed from share list');
140-
cy.get('[data-testid="share-member-list"]').should('not.contain', userBEmail);
140+
ShareSelectors.shareMemberList().should('not.contain', userBEmail);
141141

142142
// 21. Close the share dialog
143-
cy.get('[data-testid="share-dialog-close"]').click();
143+
ShareSelectors.shareDialogClose().click();
144144
cy.task('log', 'Test completed successfully');
145145
});
146146
});

cypress/support/selectors.ts

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,33 @@ export const ShareSelectors = {
160160

161161
// Visit Site button
162162
visitSiteButton: () => cy.get(byTestId('visit-site-button')),
163+
164+
// Share input field
165+
shareInput: () => cy.get(byTestId('share-input')),
166+
167+
// Permission dropdown
168+
permissionDropdown: () => cy.get(byTestId('permission-dropdown')),
169+
170+
// Permission options
171+
permissionCanEdit: () => cy.get(byTestId('permission-can-edit')),
172+
173+
// Share invite button
174+
shareInviteButton: () => cy.get(byTestId('share-invite-button')),
175+
176+
// Share member list
177+
shareMemberList: () => cy.get(byTestId('share-member-list')),
178+
179+
// Share dialog close button
180+
shareDialogClose: () => cy.get(byTestId('share-dialog-close')),
181+
182+
// Remove member button (dynamic)
183+
removeMemberButton: (email: string) => cy.get(byTestId(`remove-member-${email}`)),
184+
185+
// Shared with me section
186+
sharedWithMeSection: () => cy.get(byTestId('shared-with-me-section')),
187+
188+
// Logout button
189+
logoutButton: () => cy.get(byTestId('logout-button')),
163190
};
164191

165192
/**

0 commit comments

Comments
 (0)