Skip to content

Commit 56e68d1

Browse files
authored
Merge pull request #1097 from AppFlowy-IO/refactor/appflowy_overlay
Refactor/appflowy overlay
2 parents 4a39c69 + d35727b commit 56e68d1

35 files changed

+483
-418
lines changed

frontend/app_flowy/lib/plugins/board/presentation/card/board_select_option_cell.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import 'package:app_flowy/plugins/board/application/card/board_select_option_cel
22
import 'package:app_flowy/plugins/grid/application/cell/cell_service/cell_service.dart';
33
import 'package:app_flowy/plugins/grid/presentation/widgets/cell/select_option_cell/extension.dart';
44
import 'package:app_flowy/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart';
5-
import 'package:appflowy_popover/popover.dart';
5+
import 'package:appflowy_popover/appflowy_popover.dart';
66
import 'package:flowy_infra_ui/flowy_infra_ui.dart';
77
import 'package:flutter/material.dart';
88
import 'package:flutter_bloc/flutter_bloc.dart';

frontend/app_flowy/lib/plugins/board/presentation/card/card.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'package:app_flowy/plugins/board/application/card/card_bloc.dart';
22
import 'package:app_flowy/plugins/board/application/card/card_data_controller.dart';
33
import 'package:app_flowy/plugins/grid/presentation/widgets/row/row_action_sheet.dart';
4-
import 'package:appflowy_popover/popover.dart';
4+
import 'package:appflowy_popover/appflowy_popover.dart';
55
import 'package:flowy_infra/image.dart';
66
import 'package:flowy_infra/theme.dart';
77
import 'package:flowy_infra_ui/flowy_infra_ui.dart';

frontend/app_flowy/lib/plugins/board/presentation/toolbar/board_setting.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import 'package:app_flowy/plugins/grid/application/field/field_controller.dart';
44
import 'package:app_flowy/plugins/grid/presentation/layout/sizes.dart';
55
import 'package:app_flowy/plugins/grid/presentation/widgets/toolbar/grid_group.dart';
66
import 'package:app_flowy/plugins/grid/presentation/widgets/toolbar/grid_property.dart';
7-
import 'package:appflowy_popover/popover.dart';
7+
import 'package:appflowy_popover/appflowy_popover.dart';
88
import 'package:easy_localization/easy_localization.dart';
99
import 'package:flowy_infra/image.dart';
1010
import 'package:flowy_infra/theme.dart';

frontend/app_flowy/lib/plugins/board/presentation/toolbar/board_toolbar.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import 'package:app_flowy/plugins/grid/application/field/field_controller.dart';
2-
import 'package:appflowy_popover/popover.dart';
2+
import 'package:appflowy_popover/appflowy_popover.dart';
33
import 'package:flowy_infra/image.dart';
44
import 'package:flowy_infra/theme.dart';
55
import 'package:flowy_infra_ui/flowy_infra_ui.dart';
@@ -65,7 +65,7 @@ class _SettingButtonState extends State<_SettingButton> {
6565
return AppFlowyPopover(
6666
controller: popoverController,
6767
constraints: BoxConstraints.loose(const Size(260, 400)),
68-
triggerActions: PopoverTriggerActionFlags.click,
68+
triggerActions: PopoverTriggerFlags.click,
6969
child: FlowyIconButton(
7070
hoverColor: theme.hover,
7171
width: 22,

frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_cell.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import 'package:flutter/widgets.dart';
44
import 'package:flutter_bloc/flutter_bloc.dart';
55
import 'package:app_flowy/startup/startup.dart';
66
import 'package:app_flowy/plugins/grid/application/prelude.dart';
7-
import 'package:appflowy_popover/popover.dart';
7+
import 'package:appflowy_popover/appflowy_popover.dart';
88

99
import '../cell_builder.dart';
1010
import 'date_editor.dart';

frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_editor.dart

Lines changed: 16 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'package:app_flowy/generated/locale_keys.g.dart';
22
import 'package:app_flowy/plugins/grid/application/cell/date_cal_bloc.dart';
33
import 'package:app_flowy/plugins/grid/application/field/type_option/type_option_context.dart';
4-
import 'package:appflowy_popover/popover.dart';
4+
import 'package:appflowy_popover/appflowy_popover.dart';
55
import 'package:easy_localization/easy_localization.dart';
66
import 'package:flowy_infra/image.dart';
77
import 'package:flowy_infra/theme.dart';
@@ -300,8 +300,7 @@ class _DateTypeOptionButton extends StatelessWidget {
300300
selector: (state) => state.dateTypeOptionPB,
301301
builder: (context, dateTypeOptionPB) {
302302
return AppFlowyPopover(
303-
triggerActions:
304-
PopoverTriggerActionFlags.hover | PopoverTriggerActionFlags.click,
303+
triggerActions: PopoverTriggerFlags.hover | PopoverTriggerFlags.click,
305304
offset: const Offset(20, 0),
306305
constraints: BoxConstraints.loose(const Size(140, 100)),
307306
child: FlowyButton(
@@ -340,36 +339,30 @@ class _CalDateTimeSettingState extends State<_CalDateTimeSetting> {
340339
@override
341340
Widget build(BuildContext context) {
342341
List<Widget> children = [
343-
Popover(
342+
AppFlowyPopover(
344343
mutex: _popoverMutex,
345-
triggerActions:
346-
PopoverTriggerActionFlags.hover | PopoverTriggerActionFlags.click,
344+
asBarrier: true,
345+
triggerActions: PopoverTriggerFlags.hover | PopoverTriggerFlags.click,
347346
offset: const Offset(20, 0),
348347
popupBuilder: (BuildContext context) {
349-
return OverlayContainer(
350-
constraints: BoxConstraints.loose(const Size(460, 440)),
351-
child: DateFormatList(
352-
selectedFormat: widget.dateTypeOptionPB.dateFormat,
353-
onSelected: (format) =>
354-
widget.onEvent(DateCalEvent.setDateFormat(format)),
355-
),
348+
return DateFormatList(
349+
selectedFormat: widget.dateTypeOptionPB.dateFormat,
350+
onSelected: (format) =>
351+
widget.onEvent(DateCalEvent.setDateFormat(format)),
356352
);
357353
},
358354
child: const DateFormatButton(),
359355
),
360-
Popover(
356+
AppFlowyPopover(
361357
mutex: _popoverMutex,
362-
triggerActions:
363-
PopoverTriggerActionFlags.hover | PopoverTriggerActionFlags.click,
358+
asBarrier: true,
359+
triggerActions: PopoverTriggerFlags.hover | PopoverTriggerFlags.click,
364360
offset: const Offset(20, 0),
365361
popupBuilder: (BuildContext context) {
366-
return OverlayContainer(
367-
constraints: BoxConstraints.loose(const Size(460, 440)),
368-
child: TimeFormatList(
369-
selectedFormat: widget.dateTypeOptionPB.timeFormat,
370-
onSelected: (format) =>
371-
widget.onEvent(DateCalEvent.setTimeFormat(format)),
372-
),
362+
return TimeFormatList(
363+
selectedFormat: widget.dateTypeOptionPB.timeFormat,
364+
onSelected: (format) =>
365+
widget.onEvent(DateCalEvent.setTimeFormat(format)),
373366
);
374367
},
375368
child: TimeFormatButton(timeFormat: widget.dateTypeOptionPB.timeFormat),

frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_cell.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import 'package:app_flowy/startup/startup.dart';
22
import 'package:app_flowy/plugins/grid/application/prelude.dart';
3-
import 'package:appflowy_popover/popover.dart';
3+
import 'package:appflowy_popover/appflowy_popover.dart';
44

55
import 'package:flowy_infra/theme.dart';
66
import 'package:flowy_infra_ui/flowy_infra_ui.dart';

frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/select_option_cell/select_option_editor.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'dart:collection';
22
import 'package:app_flowy/plugins/grid/application/cell/cell_service/cell_service.dart';
33
import 'package:app_flowy/plugins/grid/application/cell/select_option_editor_bloc.dart';
4-
import 'package:appflowy_popover/popover.dart';
4+
import 'package:appflowy_popover/appflowy_popover.dart';
55

66
import 'package:flowy_infra/image.dart';
77
import 'package:flowy_infra/theme.dart';
@@ -243,6 +243,7 @@ class _SelectOptionCellState extends State<_SelectOptionCell> {
243243
return AppFlowyPopover(
244244
controller: _popoverController,
245245
offset: const Offset(20, 0),
246+
asBarrier: true,
246247
constraints: BoxConstraints.loose(const Size(200, 300)),
247248
mutex: widget.popoverMutex,
248249
child: SizedBox(

frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/url_cell/url_cell.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import 'dart:async';
22
import 'package:app_flowy/generated/locale_keys.g.dart';
33
import 'package:app_flowy/plugins/grid/application/cell/url_cell_bloc.dart';
44
import 'package:app_flowy/workspace/presentation/home/toast.dart';
5-
import 'package:appflowy_popover/popover.dart';
5+
import 'package:appflowy_popover/appflowy_popover.dart';
66
import 'package:easy_localization/easy_localization.dart';
77
import 'package:flowy_infra/image.dart';
88
import 'package:flowy_infra/theme.dart';
@@ -220,7 +220,7 @@ class _EditURLAccessoryState extends State<_EditURLAccessory>
220220
constraints: BoxConstraints.loose(const Size(300, 160)),
221221
controller: _popoverController,
222222
direction: PopoverDirection.bottomWithLeftAligned,
223-
triggerActions: PopoverTriggerActionFlags.click,
223+
triggerActions: PopoverTriggerFlags.click,
224224
offset: const Offset(0, 20),
225225
child: svgWidget("editor/edit", color: theme.iconColor),
226226
popupBuilder: (BuildContext popoverContext) {

frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/field_cell.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import 'package:app_flowy/plugins/grid/application/field/field_cell_bloc.dart';
22
import 'package:app_flowy/plugins/grid/application/field/field_service.dart';
3-
import 'package:appflowy_popover/popover.dart';
3+
import 'package:appflowy_popover/appflowy_popover.dart';
44
import 'package:flowy_infra/image.dart';
55
import 'package:flowy_infra/theme.dart';
66
import 'package:flowy_infra_ui/flowy_infra_ui.dart';
@@ -33,7 +33,7 @@ class GridFieldCell extends StatelessWidget {
3333
final button = AppFlowyPopover(
3434
constraints: BoxConstraints.loose(const Size(240, 840)),
3535
direction: PopoverDirection.bottomWithLeftAligned,
36-
triggerActions: PopoverTriggerActionFlags.click,
36+
triggerActions: PopoverTriggerFlags.click,
3737
offset: const Offset(0, 10),
3838
popupBuilder: (BuildContext context) {
3939
return GridFieldCellActionSheet(

0 commit comments

Comments
 (0)