fix: analyze problem

LucasXu0 · LucasXu0 · commit 5b482248ec30 · 2022-09-16T15:03:11.000+08:00
diff --git a/frontend/app_flowy/packages/appflowy_editor/CHANGELOG.md b/frontend/app_flowy/packages/appflowy_editor/CHANGELOG.md
@@ -1,8 +1,8 @@
 ## 0.0.5
-* Support customize the hotkey for a shortcut on different platform.
+* Support customize the hotkeys for a shortcut on different platforms.
 * Support customize a theme.
 * Support localizations.
-* Support insert numbered list.
+* Support insert numbered lists.
 * Fix some bugs.
 
 ## 0.0.4
diff --git a/frontend/app_flowy/packages/appflowy_editor/lib/l10n/intl_zh_CN.arb b/frontend/app_flowy/packages/appflowy_editor/lib/l10n/intl_zh_CN.arb
@@ -1,35 +1,35 @@
 {
   "@@locale": "zh-CN",
-  "bold": "加粗",
+  "bold": "",
   "@bold": {},
-  "bulletedList": "无序列表",
+  "bulletedList": "",
   "@bulletedList": {},
-  "checkbox": "复选框",
+  "checkbox": "",
   "@checkbox": {},
-  "embedCode": "内嵌代码",
+  "embedCode": "",
   "@embedCode": {},
-  "heading1": "标题 1",
+  "heading1": "",
   "@heading1": {},
-  "heading2": "标题 2",
+  "heading2": "",
   "@heading2": {},
-  "heading3": "标题 3",
+  "heading3": "",
   "@heading3": {},
-  "highlight": "高亮",
+  "highlight": "",
   "@highlight": {},
-  "image": "图片",
+  "image": "",
   "@image": {},
-  "italic": "斜体",
+  "italic": "",
   "@italic": {},
-  "link": "链接",
+  "link": "",
   "@link": {},
-  "numberedList": "有序列表",
+  "numberedList": "",
   "@numberedList": {},
-  "quote": "引用",
+  "quote": "",
   "@quote": {},
-  "strikethrough": "删除线",
+  "strikethrough": "",
   "@strikethrough": {},
-  "text": "文字",
+  "text": "",
   "@text": {},
-  "underline": "下划线",
+  "underline": "",
   "@underline": {}
 }
diff --git a/frontend/app_flowy/packages/appflowy_editor/lib/src/l10n/intl/messages_zh-CN.dart b/frontend/app_flowy/packages/appflowy_editor/lib/src/l10n/intl/messages_zh-CN.dart
@@ -22,21 +22,21 @@ class MessageLookup extends MessageLookupByLibrary {
 
   final messages = _notInlinedMessages(_notInlinedMessages);
   static Map<String, Function> _notInlinedMessages(_) => <String, Function>{
-        "bold": MessageLookupByLibrary.simpleMessage("加粗"),
-        "bulletedList": MessageLookupByLibrary.simpleMessage("无序列表"),
-        "checkbox": MessageLookupByLibrary.simpleMessage("复选框"),
-        "embedCode": MessageLookupByLibrary.simpleMessage("内嵌代码"),
-        "heading1": MessageLookupByLibrary.simpleMessage("标题 1"),
-        "heading2": MessageLookupByLibrary.simpleMessage("标题 2"),
-        "heading3": MessageLookupByLibrary.simpleMessage("标题 3"),
-        "highlight": MessageLookupByLibrary.simpleMessage("高亮"),
-        "image": MessageLookupByLibrary.simpleMessage("图片"),
-        "italic": MessageLookupByLibrary.simpleMessage("斜体"),
-        "link": MessageLookupByLibrary.simpleMessage("链接"),
-        "numberedList": MessageLookupByLibrary.simpleMessage("有序列表"),
-        "quote": MessageLookupByLibrary.simpleMessage("引用"),
-        "strikethrough": MessageLookupByLibrary.simpleMessage("删除线"),
-        "text": MessageLookupByLibrary.simpleMessage("文字"),
-        "underline": MessageLookupByLibrary.simpleMessage("下划线")
+        "bold": MessageLookupByLibrary.simpleMessage(""),
+        "bulletedList": MessageLookupByLibrary.simpleMessage(""),
+        "checkbox": MessageLookupByLibrary.simpleMessage(""),
+        "embedCode": MessageLookupByLibrary.simpleMessage(""),
+        "heading1": MessageLookupByLibrary.simpleMessage(""),
+        "heading2": MessageLookupByLibrary.simpleMessage(""),
+        "heading3": MessageLookupByLibrary.simpleMessage(""),
+        "highlight": MessageLookupByLibrary.simpleMessage(""),
+        "image": MessageLookupByLibrary.simpleMessage(""),
+        "italic": MessageLookupByLibrary.simpleMessage(""),
+        "link": MessageLookupByLibrary.simpleMessage(""),
+        "numberedList": MessageLookupByLibrary.simpleMessage(""),
+        "quote": MessageLookupByLibrary.simpleMessage(""),
+        "strikethrough": MessageLookupByLibrary.simpleMessage(""),
+        "text": MessageLookupByLibrary.simpleMessage(""),
+        "underline": MessageLookupByLibrary.simpleMessage("")
       };
 }
diff --git a/frontend/app_flowy/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/page_up_down_handler.dart b/frontend/app_flowy/packages/appflowy_editor/lib/src/service/internal_key_event_handlers/page_up_down_handler.dart
@@ -1,5 +1,4 @@
 import 'package:flutter/material.dart';
-import 'package:flutter/services.dart';
 import 'package:appflowy_editor/src/service/shortcut_event/shortcut_event_handler.dart';
 
 ShortcutEventHandler pageUpHandler = (editorState, _) {
diff --git a/frontend/app_flowy/packages/appflowy_editor/pubspec.yaml b/frontend/app_flowy/packages/appflowy_editor/pubspec.yaml
@@ -23,6 +23,7 @@ dependencies:
   url_launcher: ^6.1.5
   logging: ^1.0.2
   intl_utils: ^2.7.0
+  intl:
   flutter_localizations:
     sdk: flutter
 
diff --git a/frontend/app_flowy/packages/appflowy_editor/test/render/rich_text/checkbox_text_test.dart b/frontend/app_flowy/packages/appflowy_editor/test/render/rich_text/checkbox_text_test.dart
@@ -4,7 +4,6 @@ import 'package:appflowy_editor/src/render/rich_text/default_selectable.dart';
 import 'package:appflowy_editor/src/extensions/text_node_extensions.dart';
 import 'package:flutter_test/flutter_test.dart';
 import '../../infra/test_editor.dart';
-import 'package:appflowy_editor/src/extensions/attributes_extension.dart';
 
 void main() async {
   setUpAll(() {
diff --git a/frontend/app_flowy/packages/appflowy_editor/test/render/rich_text/toolbar_rich_text_test.dart b/frontend/app_flowy/packages/appflowy_editor/test/render/rich_text/toolbar_rich_text_test.dart
@@ -5,7 +5,6 @@ import 'package:appflowy_editor/src/render/toolbar/toolbar_item_widget.dart';
 import 'package:appflowy_editor/src/render/toolbar/toolbar_widget.dart';
 import 'package:flutter_test/flutter_test.dart';
 import '../../infra/test_editor.dart';
-import 'package:appflowy_editor/src/extensions/attributes_extension.dart';
 
 void main() async {
   setUpAll(() {
diff --git a/frontend/app_flowy/packages/appflowy_editor/test/service/internal_key_event_handlers/backspace_handler_test.dart b/frontend/app_flowy/packages/appflowy_editor/test/service/internal_key_event_handlers/backspace_handler_test.dart
@@ -5,7 +5,6 @@ import 'package:flutter_test/flutter_test.dart';
 import 'package:network_image_mock/network_image_mock.dart';
 import '../../infra/test_editor.dart';
 import 'package:appflowy_editor/src/document/built_in_attribute_keys.dart';
-import 'package:appflowy_editor/src/extensions/attributes_extension.dart';
 
 void main() async {
   setUpAll(() {
diff --git a/frontend/app_flowy/packages/appflowy_editor/test/service/internal_key_event_handlers/white_space_handler_test.dart b/frontend/app_flowy/packages/appflowy_editor/test/service/internal_key_event_handlers/white_space_handler_test.dart
@@ -4,7 +4,6 @@ import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';
 import '../../infra/test_editor.dart';
 import 'package:appflowy_editor/src/document/built_in_attribute_keys.dart';
-import 'package:appflowy_editor/src/extensions/attributes_extension.dart';
 
 void main() async {
   setUpAll(() {

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`import 'package:flutter/material.dart';`
`2`		`-import 'package:flutter/services.dart';`
`3`	`2`	`import 'package:appflowy_editor/src/service/shortcut_event/shortcut_event_handler.dart';`
`4`	`3`
`5`	`4`	`ShortcutEventHandler pageUpHandler = (editorState, _) {`