feat: support editing name when creating a new page on mobile (#6501)

* feat: support editing name when creating a new page on mobile

* chore: add defaultName in layout extension

* test: add cover title test on mobile

* fix: cover title test on mobile

* feat: add integration runner 4

* chore: update translations

* chore: disable subpage feature

Author: LucasXu0

.github/actions/flutter_integration_test/action.yml

@@ -52,7 +52,7 @@ runs:
         sudo wget -qO /etc/apt/trusted.gpg.d/dart_linux_signing_key.asc https://dl-ssl.google.com/linux/linux_signing_key.pub
         sudo wget -qO /etc/apt/sources.list.d/dart_stable.list https://storage.googleapis.com/download.dartlang.org/linux/debian/dart_stable.list
         sudo apt-get update
-        sudo apt-get install -y dart curl build-essential libssl-dev clang cmake ninja-build pkg-config libgtk-3-dev keybinder-3.0 libnotify-dev network-manager libmpv-dev mpv
+        sudo apt-get install -y dart curl build-essential libssl-dev clang cmake ninja-build pkg-config libgtk-3-dev keybinder-3.0 libnotify-dev network-manager
       shell: bash
 
     - name: Enable Flutter Desktop
@@ -75,4 +75,4 @@ runs:
         sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 &
         sudo apt-get install network-manager
         flutter test ${{ inputs.test_path }} -d Linux --coverage
-      shell: bash
+      shell: bash

.github/workflows/flutter_ci.yaml

@@ -39,7 +39,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        os: [ ubuntu-latest ]
+        os: [ubuntu-latest]
         include:
           - os: ubuntu-latest
             flutter_profile: development-linux-x86_64
@@ -73,7 +73,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        os: [ windows-2019 ]
+        os: [windows-2019]
         include:
           - os: windows-2019
             flutter_profile: development-windows-x86
@@ -100,7 +100,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        os: [ macos-latest ]
+        os: [macos-latest]
         include:
           - os: macos-latest
             flutter_profile: development-mac-x86_64
@@ -122,12 +122,12 @@ jobs:
           flutter_profile: ${{ matrix.flutter_profile }}
 
   unit_test:
-    needs: [ prepare-linux ]
+    needs: [prepare-linux]
     if: github.event.pull_request.draft != true
     strategy:
       fail-fast: false
       matrix:
-        os: [ ubuntu-latest ]
+        os: [ubuntu-latest]
         include:
           - os: ubuntu-latest
             flutter_profile: development-linux-x86_64
@@ -173,7 +173,7 @@ jobs:
             sudo wget -qO /etc/apt/trusted.gpg.d/dart_linux_signing_key.asc https://dl-ssl.google.com/linux/linux_signing_key.pub
             sudo wget -qO /etc/apt/sources.list.d/dart_stable.list https://storage.googleapis.com/download.dartlang.org/linux/debian/dart_stable.list
             sudo apt-get update
-            sudo apt-get install -y dart curl build-essential libssl-dev clang cmake ninja-build pkg-config libgtk-3-dev keybinder-3.0 libnotify-dev libmpv-dev mpv
+            sudo apt-get install -y dart curl build-essential libssl-dev clang cmake ninja-build pkg-config libgtk-3-dev keybinder-3.0 libnotify-dev
           fi
         shell: bash
 
@@ -216,11 +216,11 @@ jobs:
         shell: bash
 
   cloud_integration_test:
-    needs: [ prepare-linux ]
+    needs: [prepare-linux]
     strategy:
       fail-fast: false
       matrix:
-        os: [ ubuntu-latest ]
+        os: [ubuntu-latest]
         include:
           - os: ubuntu-latest
             flutter_profile: development-linux-x86_64
@@ -292,7 +292,7 @@ jobs:
           sudo wget -qO /etc/apt/trusted.gpg.d/dart_linux_signing_key.asc https://dl-ssl.google.com/linux/linux_signing_key.pub
           sudo wget -qO /etc/apt/sources.list.d/dart_stable.list https://storage.googleapis.com/download.dartlang.org/linux/debian/dart_stable.list
           sudo apt-get update
-          sudo apt-get install -y dart curl build-essential libssl-dev clang cmake ninja-build pkg-config libgtk-3-dev keybinder-3.0 libnotify-dev libmpv-dev mpv
+          sudo apt-get install -y dart curl build-essential libssl-dev clang cmake ninja-build pkg-config libgtk-3-dev keybinder-3.0 libnotify-dev
         shell: bash
 
       - name: Enable Flutter Desktop
@@ -325,12 +325,12 @@ jobs:
 
   # split the integration tests into different machines to minimize the time
   integration_test_1:
-    needs: [ prepare-linux ]
+    needs: [prepare-linux]
     if: github.event.pull_request.draft != true
     strategy:
       fail-fast: false
       matrix:
-        os: [ ubuntu-latest ]
+        os: [ubuntu-latest]
         include:
           - os: ubuntu-latest
             target: "x86_64-unknown-linux-gnu"
@@ -339,12 +339,6 @@ jobs:
       - name: Checkout source code
         uses: actions/checkout@v4
 
-      - name: Install video dependency
-        run: |
-          sudo apt-get update
-          sudo apt-get -y install libmpv-dev mpv
-        shell: bash
-
       - name: Flutter Integration Test 1
         uses: ./.github/actions/flutter_integration_test
         with:
@@ -355,12 +349,12 @@ jobs:
           rust_target: ${{ matrix.target }}
 
   integration_test_2:
-    needs: [ prepare-linux ]
+    needs: [prepare-linux]
     if: github.event.pull_request.draft != true
     strategy:
       fail-fast: false
       matrix:
-        os: [ ubuntu-latest ]
+        os: [ubuntu-latest]
         include:
           - os: ubuntu-latest
             target: "x86_64-unknown-linux-gnu"
@@ -369,12 +363,6 @@ jobs:
       - name: Checkout source code
         uses: actions/checkout@v4
 
-      - name: Install video dependency
-        run: |
-          sudo apt-get update
-          sudo apt-get -y install libmpv-dev mpv
-        shell: bash
-
       - name: Flutter Integration Test 2
         uses: ./.github/actions/flutter_integration_test
         with:
@@ -385,12 +373,12 @@ jobs:
           rust_target: ${{ matrix.target }}
 
   integration_test_3:
-    needs: [ prepare-linux ]
+    needs: [prepare-linux]
     if: github.event.pull_request.draft != true
     strategy:
       fail-fast: false
       matrix:
-        os: [ ubuntu-latest ]
+        os: [ubuntu-latest]
         include:
           - os: ubuntu-latest
             target: "x86_64-unknown-linux-gnu"
@@ -399,12 +387,6 @@ jobs:
       - name: Checkout source code
         uses: actions/checkout@v4
 
-      - name: Install video dependency
-        run: |
-          sudo apt-get update
-          sudo apt-get -y install libmpv-dev mpv
-        shell: bash
-
       - name: Flutter Integration Test 3
         uses: ./.github/actions/flutter_integration_test
         with:
@@ -413,3 +395,27 @@ jobs:
           rust_toolchain: ${{ env.RUST_TOOLCHAIN }}
           cargo_make_version: ${{ env.CARGO_MAKE_VERSION }}
           rust_target: ${{ matrix.target }}
+
+  integration_test_4:
+    needs: [prepare-linux]
+    if: github.event.pull_request.draft != true
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest]
+        include:
+          - os: ubuntu-latest
+            target: "x86_64-unknown-linux-gnu"
+    runs-on: ${{ matrix.os }}
+    steps:
+      - name: Checkout source code
+        uses: actions/checkout@v4
+
+      - name: Flutter Integration Test 4
+        uses: ./.github/actions/flutter_integration_test
+        with:
+          test_path: integration_test/desktop_runner_4.dart
+          flutter_version: ${{ env.FLUTTER_VERSION }}
+          rust_toolchain: ${{ env.RUST_TOOLCHAIN }}
+          cargo_make_version: ${{ env.CARGO_MAKE_VERSION }}
+          rust_target: ${{ matrix.target }}

.github/workflows/release.yml

@@ -368,7 +368,7 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y build-essential libsqlite3-dev libssl-dev clang cmake ninja-build pkg-config libgtk-3-dev
           sudo apt-get install keybinder-3.0
-          sudo apt-get install -y  alien libnotify-dev libmpv-dev mpv
+          sudo apt-get install -y alien libnotify-dev
           source $HOME/.cargo/env
           cargo install --force cargo-make
           cargo install --force duckscript_cli

frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner.dart renamed to frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_1.dart

@@ -24,7 +24,7 @@ import 'document_with_outline_block_test.dart' as document_with_outline_block;
 import 'document_with_toggle_list_test.dart' as document_with_toggle_list_test;
 import 'edit_document_test.dart' as document_edit_test;
 
-void startTesting() {
+void main() {
   IntegrationTestWidgetsFlutterBinding.ensureInitialized();
 
   // Document integration tests
@@ -47,4 +47,6 @@ void startTesting() {
   document_more_actions_test.main();
   document_with_file_test.main();
   document_shortcuts_test.main();
+
+  // Don't add new tests here. Add them to document_test_runner_2.dart
 }

frontend/appflowy_flutter/integration_test/desktop/document/document_test_runner_2.dart

@@ -0,0 +1,14 @@
+import 'package:integration_test/integration_test.dart';
+
+import 'document_app_lifecycle_test.dart' as document_app_lifecycle_test;
+import 'document_title_test.dart' as document_title_test;
+
+void main() {
+  IntegrationTestWidgetsFlutterBinding.ensureInitialized();
+
+  // Document integration tests
+  document_title_test.main();
+  // Disable subPage test temporarily, enable it in version 0.7.2
+  // document_sub_page_test.main();
+  document_app_lifecycle_test.main();
+}

frontend/appflowy_flutter/integration_test/desktop_runner_1.dart

@@ -1,6 +1,6 @@
 import 'package:integration_test/integration_test.dart';
 
-import 'desktop/document/document_test_runner.dart' as document_test_runner;
+import 'desktop/document/document_test_runner_1.dart' as document_test_runner;
 import 'desktop/uncategorized/empty_test.dart' as first_test;
 import 'desktop/uncategorized/switch_folder_test.dart' as switch_folder_test;
 
@@ -15,7 +15,7 @@ Future<void> runIntegration1OnDesktop() async {
   first_test.main();
 
   switch_folder_test.main();
-  document_test_runner.startTesting();
+  document_test_runner.main();
 
-  // DON'T add more tests here. This is the first test runner for desktop.
+  // DON'T add more tests here.
 }

frontend/appflowy_flutter/integration_test/desktop_runner_3.dart

@@ -3,16 +3,12 @@ import 'package:integration_test/integration_test.dart';
 import 'desktop/board/board_test_runner.dart' as board_test_runner;
 import 'desktop/database/database_row_cover_test.dart'
     as database_row_cover_test;
-import 'desktop/document/document_title_test.dart' as document_title_test;
-import 'desktop/document/document_app_lifecycle_test.dart'
-    as document_app_lifecycle_test;
-import 'desktop/document/document_sub_page_test.dart' as document_sub_page_test;
+import 'desktop/grid/grid_edit_row_test.dart' as grid_edit_row_test_runner;
 import 'desktop/grid/grid_filter_and_sort_test.dart'
     as grid_filter_and_sort_test_runner;
 import 'desktop/grid/grid_reopen_test.dart' as grid_reopen_test_runner;
 import 'desktop/grid/grid_reorder_row_test.dart'
     as grid_reorder_row_test_runner;
-import 'desktop/grid/grid_edit_row_test.dart' as grid_edit_row_test_runner;
 import 'desktop/grid/grid_row_test.dart' as grid_create_row_test_runner;
 import 'desktop/settings/settings_runner.dart' as settings_test_runner;
 import 'desktop/sidebar/sidebar_test_runner.dart' as sidebar_test_runner;
@@ -51,7 +47,6 @@ Future<void> runIntegration3OnDesktop() async {
   grid_filter_and_sort_test_runner.main();
   grid_edit_row_test_runner.main();
   zoom_in_out_test.main();
-  document_title_test.main();
-  document_sub_page_test.main();
-  document_app_lifecycle_test.main();
+
+  // DON'T add more tests here. Add them to desktop_runner_4.dart
 }

frontend/appflowy_flutter/integration_test/desktop_runner_4.dart

@@ -0,0 +1,17 @@
+import 'package:integration_test/integration_test.dart';
+
+import 'desktop/document/document_test_runner_2.dart' as document_test_runner_2;
+import 'desktop/uncategorized/empty_test.dart' as first_test;
+
+Future<void> main() async {
+  await runIntegration4OnDesktop();
+}
+
+Future<void> runIntegration4OnDesktop() async {
+  IntegrationTestWidgetsFlutterBinding.ensureInitialized();
+
+  // This test must be run first, otherwise the CI will fail.
+  first_test.main();
+
+  document_test_runner_2.main();
+}

frontend/appflowy_flutter/integration_test/mobile/document/document_test_runner.dart

@@ -0,0 +1,12 @@
+import 'package:integration_test/integration_test.dart';
+
+import 'page_style_test.dart' as page_style_test;
+import 'title_test.dart' as title_test;
+
+void main() {
+  IntegrationTestWidgetsFlutterBinding.ensureInitialized();
+
+  // Document integration tests
+  title_test.main();
+  page_style_test.main();
+}

frontend/appflowy_flutter/integration_test/mobile/document/title_test.dart

@@ -0,0 +1,76 @@
+// ignore_for_file: unused_import
+
+import 'dart:io';
+
+import 'package:appflowy/env/cloud_env.dart';
+import 'package:appflowy/generated/flowy_svgs.g.dart';
+import 'package:appflowy/generated/locale_keys.g.dart';
+import 'package:appflowy/mobile/application/page_style/document_page_style_bloc.dart';
+import 'package:appflowy/mobile/presentation/base/app_bar/app_bar_actions.dart';
+import 'package:appflowy/mobile/presentation/base/view_page/app_bar_buttons.dart';
+import 'package:appflowy/mobile/presentation/bottom_sheet/bottom_sheet_buttons.dart';
+import 'package:appflowy/mobile/presentation/home/home.dart';
+import 'package:appflowy/mobile/presentation/home/section_folder/mobile_home_section_folder_header.dart';
+import 'package:appflowy/mobile/presentation/presentation.dart';
+import 'package:appflowy/plugins/document/presentation/editor_page.dart';
+import 'package:appflowy/plugins/document/presentation/editor_plugins/cover/document_immersive_cover.dart';
+import 'package:appflowy/plugins/document/presentation/editor_plugins/cover/document_immersive_cover_bloc.dart';
+import 'package:appflowy/plugins/document/presentation/editor_plugins/page_style/_page_style_layout.dart';
+import 'package:appflowy/startup/startup.dart';
+import 'package:appflowy/user/application/auth/af_cloud_mock_auth_service.dart';
+import 'package:appflowy/user/application/auth/auth_service.dart';
+import 'package:appflowy/user/presentation/screens/sign_in_screen/widgets/widgets.dart';
+import 'package:appflowy/workspace/application/settings/prelude.dart';
+import 'package:appflowy/workspace/application/view/view_ext.dart';
+import 'package:appflowy/workspace/presentation/settings/widgets/setting_appflowy_cloud.dart';
+import 'package:appflowy_backend/protobuf/flowy-folder/view.pb.dart';
+import 'package:appflowy_editor/appflowy_editor.dart';
+import 'package:easy_localization/easy_localization.dart';
+import 'package:flowy_infra/uuid.dart';
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:integration_test/integration_test.dart';
+import 'package:path/path.dart' as p;
+
+import '../../shared/dir.dart';
+import '../../shared/mock/mock_file_picker.dart';
+import '../../shared/util.dart';
+
+void main() {
+  IntegrationTestWidgetsFlutterBinding.ensureInitialized();
+
+  group('document title:', () {
+    testWidgets('create a new page, the title should be empty', (tester) async {
+      await tester.launchInAnonymousMode();
+
+      final createPageButton = find.byKey(
+        BottomNavigationBarItemType.add.valueKey,
+      );
+      await tester.tapButton(createPageButton);
+      expect(find.byType(MobileDocumentScreen), findsOneWidget);
+
+      final title = tester.editor.findDocumentTitle('');
+      expect(title, findsOneWidget);
+      final textField = tester.widget<TextField>(title);
+      expect(textField.focusNode!.hasFocus, isTrue);
+
+      // input new name and press done button
+      const name = 'test document';
+      await tester.enterText(title, name);
+      await tester.testTextInput.receiveAction(TextInputAction.done);
+      await tester.pumpAndSettle();
+      final newTitle = tester.editor.findDocumentTitle(name);
+      expect(newTitle, findsOneWidget);
+      expect(textField.controller!.text, name);
+
+      // the document should get focus
+      final editor = tester.widget<AppFlowyEditorPage>(
+        find.byType(AppFlowyEditorPage),
+      );
+      expect(
+        editor.editorState.selection,
+        Selection.collapsed(Position(path: [0])),
+      );
+    });
+  });
+}