fix: potential ai_repository not init (#6388)

* fix: potential ai_repository not init

* fix: assertion when deleting block

* chore: remove the rule

* test: add smart edit bloc test

* test: add delete block test

* chore: remove unused_import

* fix: paste image integration test

Author: LucasXu0

frontend/appflowy_flutter/integration_test/cloud/appflowy_cloud_auth_test.dart

@@ -86,17 +86,21 @@ void main() {
       // Open the setting page and sign out
       await tester.openSettings();
       await tester.openSettingsPage(SettingsPage.cloud);
+      await tester.pumpAndSettle();
 
       // the switch should be on by default
       tester.assertAppFlowyCloudEnableSyncSwitchValue(true);
       await tester.toggleEnableSync(AppFlowyCloudEnableSync);
+      // wait for the switch animation
+      await tester.wait(250);
 
       // the switch should be off
       tester.assertAppFlowyCloudEnableSyncSwitchValue(false);
 
       // the switch should be on after toggling
       await tester.toggleEnableSync(AppFlowyCloudEnableSync);
       tester.assertAppFlowyCloudEnableSyncSwitchValue(true);
+      await tester.wait(250);
     });
   });
 }

frontend/appflowy_flutter/integration_test/cloud/document/document_delete_block_test.dart

@@ -0,0 +1,60 @@
+import 'package:appflowy/env/cloud_env.dart';
+import 'package:appflowy/generated/locale_keys.g.dart';
+import 'package:appflowy/plugins/document/presentation/editor_plugins/actions/drag_to_reorder/draggable_option_button.dart';
+import 'package:appflowy_editor/appflowy_editor.dart';
+import 'package:easy_localization/easy_localization.dart';
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:integration_test/integration_test.dart';
+
+import '../../shared/constants.dart';
+import '../../shared/util.dart';
+
+void main() {
+  IntegrationTestWidgetsFlutterBinding.ensureInitialized();
+
+  group('document delete block: ', () {
+    testWidgets('hover on the block and delete it', (tester) async {
+      await tester.initializeAppFlowy(
+        cloudType: AuthenticatorType.appflowyCloudSelfHost,
+      );
+      await tester.tapGoogleLoginInButton();
+      await tester.expectToSeeHomePageWithGetStartedPage();
+
+      // open getting started page
+      await tester.openPage(Constants.gettingStartedPageName);
+
+      // before delete
+      final path = [1];
+      final beforeDeletedBlock = tester.editor.getNodeAtPath(path);
+
+      // hover on the block and delete it
+      final optionButton = find.byWidgetPredicate(
+        (widget) =>
+            widget is DraggableOptionButton &&
+            widget.blockComponentContext.node.path.equals(path),
+      );
+
+      await tester.hoverOnWidget(
+        optionButton,
+        onHover: () async {
+          // click the delete button
+          await tester.tapButton(optionButton);
+        },
+      );
+      await tester.pumpAndSettle(Durations.short1);
+
+      // click the delete button
+      final deleteButton =
+          find.findTextInFlowyText(LocaleKeys.button_delete.tr());
+      await tester.tapButton(deleteButton);
+
+      // wait for the deletion
+      await tester.pumpAndSettle(Durations.short1);
+
+      // check if the block is deleted
+      final afterDeletedBlock = tester.editor.getNodeAtPath([1]);
+      expect(afterDeletedBlock.id, isNot(equals(beforeDeletedBlock.id)));
+    });
+  });
+}

frontend/appflowy_flutter/integration_test/cloud/document/document_drag_block_test.dart

@@ -1,33 +1,9 @@
-// ignore_for_file: unused_import
-
-import 'dart:io';
-
 import 'package:appflowy/env/cloud_env.dart';
-import 'package:appflowy/generated/locale_keys.g.dart';
-import 'package:appflowy/plugins/document/presentation/editor_plugins/openai/widgets/loading.dart';
-import 'package:appflowy/shared/feature_flags.dart';
-import 'package:appflowy/startup/startup.dart';
-import 'package:appflowy/user/application/auth/af_cloud_mock_auth_service.dart';
-import 'package:appflowy/user/application/auth/auth_service.dart';
-import 'package:appflowy/workspace/application/settings/prelude.dart';
-import 'package:appflowy/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_actions.dart';
-import 'package:appflowy/workspace/presentation/home/menu/sidebar/workspace/_sidebar_workspace_menu.dart';
-import 'package:appflowy/workspace/presentation/home/menu/sidebar/workspace/sidebar_workspace.dart';
-import 'package:appflowy/workspace/presentation/settings/widgets/setting_appflowy_cloud.dart';
-import 'package:appflowy/workspace/presentation/widgets/user_avatar.dart';
-import 'package:appflowy_backend/protobuf/flowy-folder/view.pb.dart';
-import 'package:easy_localization/easy_localization.dart';
-import 'package:flowy_infra/uuid.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:integration_test/integration_test.dart';
-import 'package:path/path.dart' as p;
 
 import '../../shared/constants.dart';
-import '../../shared/database_test_op.dart';
-import '../../shared/dir.dart';
-import '../../shared/emoji.dart';
-import '../../shared/mock/mock_file_picker.dart';
 import '../../shared/util.dart';
 
 void main() {

frontend/appflowy_flutter/integration_test/desktop/document/document_copy_and_paste_test.dart

@@ -207,7 +207,7 @@ void main() {
     final image = await rootBundle.load('assets/test/images/sample.png');
     final bytes = image.buffer.asUint8List();
     await tester.pasteContent(image: ('png', bytes), (editorState) {
-      expect(editorState.document.root.children.length, 2);
+      expect(editorState.document.root.children.length, 1);
       final node = editorState.getNodeAtPath([0])!;
       expect(node.type, ImageBlockKeys.type);
       expect(node.attributes[ImageBlockKeys.url], isNotNull);
@@ -218,7 +218,7 @@ void main() {
     final image = await rootBundle.load('assets/test/images/sample.jpeg');
     final bytes = image.buffer.asUint8List();
     await tester.pasteContent(image: ('jpeg', bytes), (editorState) {
-      expect(editorState.document.root.children.length, 2);
+      expect(editorState.document.root.children.length, 1);
       final node = editorState.getNodeAtPath([0])!;
       expect(node.type, ImageBlockKeys.type);
       expect(node.attributes[ImageBlockKeys.url], isNotNull);
@@ -280,7 +280,7 @@ void main() {
         html: html,
         image: ('png', bytes),
         (editorState) {
-          expect(editorState.document.root.children.length, 2);
+          expect(editorState.document.root.children.length, 1);
           final node = editorState.getNodeAtPath([0])!;
           expect(node.type, ImageBlockKeys.type);
         },
@@ -313,6 +313,7 @@ void main() {
     (tester) async {
       const url = 'https://appflowy.io';
       await tester.pasteContent(plainText: url, (editorState) {
+        // the second one is the paragraph node
         expect(editorState.document.root.children.length, 2);
         final node = editorState.getNodeAtPath([0])!;
         expect(node.type, LinkPreviewBlockKeys.type);

frontend/appflowy_flutter/lib/plugins/document/application/document_bloc.dart

@@ -238,12 +238,24 @@ class DocumentBloc extends Bloc<DocumentEvent, DocumentState> {
           return;
         }
 
+        if (enableDocumentInternalLog) {
+          Log.debug(
+            '[TransactionAdapter] 1. transaction before apply: ${transaction.hashCode}',
+          );
+        }
+
         // apply transaction to backend
         await _transactionAdapter.apply(transaction, editorState);
 
         // check if the document is empty.
         await _applyRules();
 
+        if (enableDocumentInternalLog) {
+          Log.debug(
+            '[TransactionAdapter] 4. transaction after apply: ${transaction.hashCode}',
+          );
+        }
+
         if (!isClosed) {
           // ignore: invalid_use_of_visible_for_testing_member
           emit(state.copyWith(isDocumentEmpty: editorState.document.isEmpty));
@@ -270,25 +282,9 @@ class DocumentBloc extends Bloc<DocumentEvent, DocumentState> {
   Future<void> _applyRules() async {
     await Future.wait([
       _ensureAtLeastOneParagraphExists(),
-      _ensureLastNodeIsEditable(),
     ]);
   }
 
-  Future<void> _ensureLastNodeIsEditable() async {
-    final editorState = state.editorState;
-    if (editorState == null) {
-      return;
-    }
-    final document = editorState.document;
-    final lastNode = document.root.children.lastOrNull;
-    if (lastNode == null || lastNode.delta == null) {
-      final transaction = editorState.transaction;
-      transaction.insertNode([document.root.children.length], paragraphNode());
-      transaction.afterSelection = transaction.beforeSelection;
-      await editorState.apply(transaction);
-    }
-  }
-
   Future<void> _ensureAtLeastOneParagraphExists() async {
     final editorState = state.editorState;
     if (editorState == null) {

frontend/appflowy_flutter/lib/plugins/document/application/editor_transaction_adapter.dart

@@ -22,7 +22,6 @@ import 'package:appflowy_editor/appflowy_editor.dart'
         blockComponentDelta;
 import 'package:collection/collection.dart';
 import 'package:nanoid/nanoid.dart';
-import 'package:synchronized/synchronized.dart';
 
 const _kExternalTextType = 'text';
 
@@ -39,27 +38,20 @@ class TransactionAdapter {
   final DocumentService documentService;
   final String documentId;
 
-  // Controls the apply transaction flow
-  //
-  // Ensures transactions are applied in the correct order when dependencies exist.
-  // Example: If transaction B depends on transaction A, A must be applied first.
-  final Lock _applyLock = Lock();
-
   Future<void> apply(Transaction transaction, EditorState editorState) async {
-    await _applyLock.synchronized(
-      () async {
-        if (enableDocumentInternalLog) {
-          Log.debug('apply transaction begin ${transaction.hashCode}');
-        }
+    if (enableDocumentInternalLog) {
+      Log.debug(
+        '[TransactionAdapter] 2. apply transaction begin ${transaction.hashCode} in $hashCode',
+      );
+    }
 
-        await _applyInternal(transaction, editorState);
+    await _applyInternal(transaction, editorState);
 
-        if (enableDocumentInternalLog) {
-          Log.debug('apply transaction end ${transaction.hashCode}');
-        }
-      },
-      timeout: const Duration(seconds: 5),
-    );
+    if (enableDocumentInternalLog) {
+      Log.debug(
+        '[TransactionAdapter] 3. apply transaction end ${transaction.hashCode} in $hashCode',
+      );
+    }
   }
 
   Future<void> _applyInternal(

frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/actions/block_action_option_button.dart

@@ -68,6 +68,9 @@ class _BlockOptionButtonState extends State<BlockOptionButton> {
       },
       onClosed: () {
         WidgetsBinding.instance.addPostFrameCallback((timeStamp) {
+          if (!mounted) {
+            return;
+          }
           widget.editorState.selectionType = null;
           widget.editorState.selection = null;
           widget.blockComponentState.alwaysShowActions = false;

frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/copy_and_paste/paste_from_image.dart

@@ -8,6 +8,7 @@ import 'package:appflowy/plugins/document/presentation/editor_plugins/image/cust
 import 'package:appflowy/plugins/document/presentation/editor_plugins/image/image_util.dart';
 import 'package:appflowy/shared/patterns/file_type_patterns.dart';
 import 'package:appflowy/startup/startup.dart';
+import 'package:appflowy/util/default_extensions.dart';
 import 'package:appflowy/workspace/application/settings/application_data_storage.dart';
 import 'package:appflowy/workspace/presentation/widgets/dialogs.dart';
 import 'package:appflowy_backend/log.dart';
@@ -20,13 +21,6 @@ import 'package:provider/provider.dart';
 import 'package:universal_platform/universal_platform.dart';
 
 extension PasteFromImage on EditorState {
-  static final supportedImageFormats = [
-    'png',
-    'jpeg',
-    'gif',
-    'webp',
-  ];
-
   Future<void> dropImages(
     Node dropNode,
     List<XFile> files,
@@ -75,7 +69,7 @@ extension PasteFromImage on EditorState {
       return false;
     }
 
-    if (!supportedImageFormats.contains(format)) {
+    if (!defaultImageExtensions.contains(format)) {
       Log.info('unsupported format: $format');
       if (UniversalPlatform.isMobile) {
         showToastNotification(
@@ -129,7 +123,6 @@ extension PasteFromImage on EditorState {
         await insertImageNode(path, selection: selection);
       }
 
-      await File(copyToPath).delete();
       return true;
     } catch (e) {
       Log.error('cannot copy image file', e);