Merge branch 'main' into enable_ci_on_windows_linux_2

Author: LucasXu0

CHANGELOG.md

@@ -1,4 +1,15 @@
 # Release Notes
+## Version 0.8.8 - 01/04/2025
+### New Features
+- Added support for selecting AI models in AI writer
+- Revamped link menu in toolbar
+- Added support for using ":" to add emojis in documents
+- Passed the history of past AI prompts and responses to AI writer
+### Bug Fixes
+- Improved AI writer scrolling user experience
+- Fixed issue where checklist items would disappear during reordering
+- Fixed numbered lists generated by AI to maintain the same index as the input
+
 ## Version 0.8.7 - 18/03/2025
 ### New Features
 - Made local AI free and integrated with Ollama

frontend/appflowy_flutter/integration_test/desktop/document/document_toolbar_test.dart

@@ -184,6 +184,45 @@ void main() {
         3,
       );
     });
+
+    testWidgets('toolbar will not rebuild after click item', (tester) async {
+      const text = 'Test rebuilding';
+      await prepareForToolbar(tester, text);
+      Finder toolbar = find.byType(DesktopFloatingToolbar);
+      Element toolbarElement = toolbar.evaluate().first;
+      final elementHashcode = toolbarElement.hashCode;
+      final boldButton = find.byFlowySvg(FlowySvgs.toolbar_bold_m),
+          underlineButton = find.byFlowySvg(FlowySvgs.toolbar_underline_m),
+          italicButton = find.byFlowySvg(FlowySvgs.toolbar_inline_italic_m);
+
+      /// tap format buttons
+      await tester.tapButton(boldButton);
+      await tester.tapButton(underlineButton);
+      await tester.tapButton(italicButton);
+      toolbar = find.byType(DesktopFloatingToolbar);
+      toolbarElement = toolbar.evaluate().first;
+
+      /// check if the toolbar is not rebuilt
+      expect(elementHashcode, toolbarElement.hashCode);
+      final editorState = tester.editor.getCurrentEditorState();
+
+      /// check text formats
+      expect(
+        editorState
+            .getDeltaAttributeValueInSelection(AppFlowyRichTextKeys.bold),
+        true,
+      );
+      expect(
+        editorState
+            .getDeltaAttributeValueInSelection(AppFlowyRichTextKeys.italic),
+        true,
+      );
+      expect(
+        editorState
+            .getDeltaAttributeValueInSelection(AppFlowyRichTextKeys.underline),
+        true,
+      );
+    });
   });
 
   group('document toolbar: link', () {
@@ -228,6 +267,7 @@ void main() {
       expect(toolbar, findsNothing);
 
       /// show toolbar again
+      await tester.editor.tapLineOfEditorAt(0);
       await selectText(tester, text);
       await tester.tapButton(linkButton);
 

frontend/appflowy_flutter/integration_test/shared/document_test_operations.dart

@@ -307,9 +307,11 @@ class EditorOperations {
   Future<void> openTurnIntoMenu(Path path) async {
     await hoverAndClickOptionMenuButton(path);
     await tester.tapButton(
-      find.findTextInFlowyText(
-        LocaleKeys.document_plugins_optionAction_turnInto.tr(),
-      ),
+      find
+          .findTextInFlowyText(
+            LocaleKeys.document_plugins_optionAction_turnInto.tr(),
+          )
+          .first,
     );
     await tester.pumpUntilFound(find.byType(TurnIntoOptionMenu));
   }

frontend/appflowy_flutter/lib/mobile/presentation/home/setting/settings_popup_menu.dart

@@ -16,6 +16,7 @@ enum _MobileSettingsPopupMenuItem {
   members,
   trash,
   help,
+  helpAndDocumentation,
 }
 
 class HomePageSettingsPopupMenu extends StatelessWidget {
@@ -62,10 +63,16 @@ class HomePageSettingsPopupMenu extends StatelessWidget {
           text: LocaleKeys.settings_popupMenuItem_trash.tr(),
         ),
         const PopupMenuDivider(height: 0.5),
+        _buildItem(
+          value: _MobileSettingsPopupMenuItem.helpAndDocumentation,
+          svg: FlowySvgs.help_and_documentation_s,
+          text: LocaleKeys.settings_popupMenuItem_helpAndDocumentation.tr(),
+        ),
+        const PopupMenuDivider(height: 0.5),
         _buildItem(
           value: _MobileSettingsPopupMenuItem.help,
           svg: FlowySvgs.message_support_s,
-          text: LocaleKeys.settings_popupMenuItem_helpAndSupport.tr(),
+          text: LocaleKeys.settings_popupMenuItem_getSupport.tr(),
         ),
       ],
       onSelected: (_MobileSettingsPopupMenuItem value) {
@@ -82,6 +89,9 @@ class HomePageSettingsPopupMenu extends StatelessWidget {
           case _MobileSettingsPopupMenuItem.help:
             _openHelpPage(context);
             break;
+          case _MobileSettingsPopupMenuItem.helpAndDocumentation:
+            _openHelpAndDocumentationPage(context);
+            break;
         }
       },
       child: const Padding(
@@ -123,6 +133,10 @@ class HomePageSettingsPopupMenu extends StatelessWidget {
   void _openSettingsPage(BuildContext context) {
     context.push(MobileHomeSettingPage.routeName);
   }
+
+  void _openHelpAndDocumentationPage(BuildContext context) {
+    afLaunchUrlString('https://appflowy.com/guide');
+  }
 }
 
 class _PopupButton extends StatelessWidget {

frontend/appflowy_flutter/lib/plugins/document/presentation/editor_page.dart

@@ -459,7 +459,7 @@ class _AppFlowyEditorPageState extends State<AppFlowyEditorPage>
             child: DesktopFloatingToolbar(
               editorState: editorState,
               onDismiss: onDismiss,
-              enableAnimation: false,
+              enableAnimation: !isMetricsChanged,
               child: child,
             ),
           ),

frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_hover_menu.dart

@@ -221,7 +221,7 @@ class _LinkHoverTriggerState extends State<LinkHoverTrigger> {
     if (isPage) {
       final viewId = href.split('/').lastOrNull ?? '';
       if (viewId.isEmpty) {
-        await afLaunchUrlString(href);
+        await afLaunchUrlString(href, addingHttpSchemeWhenFailed: true);
       } else {
         final (view, isInTrash, isDeleted) =
             await ViewBackendService.getMentionPageStatus(viewId);
@@ -230,7 +230,7 @@ class _LinkHoverTriggerState extends State<LinkHoverTrigger> {
         }
       }
     } else {
-      await afLaunchUrlString(href);
+      await afLaunchUrlString(href, addingHttpSchemeWhenFailed: true);
     }
   }
 
@@ -486,8 +486,7 @@ class LinkHoverTriggers {
 
   void call(HoverTriggerKey key) {
     final callbacks = _map[key] ?? {};
-    for (final callback in callbacks) {
-      callback.call();
-    }
+    if (callbacks.isEmpty) return;
+    callbacks.first.call();
   }
 }

frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_styles.dart

@@ -9,7 +9,7 @@ class LinkStyle {
   static const textPrimary = Color(0xFF1F2329);
 
   static Color borderColor(BuildContext context) =>
-      Theme.of(context).isLightMode ? Color(0xFFE8ECF3) : Color(0xffbdbdbd);
+      Theme.of(context).isLightMode ? Color(0xFFE8ECF3) : Color(0x64BDBDBD);
 
   static InputDecoration buildLinkTextFieldInputDecoration(
     String hintText,
@@ -18,9 +18,7 @@ class LinkStyle {
   }) {
     final border = OutlineInputBorder(
       borderRadius: BorderRadius.all(Radius.circular(8.0)),
-      borderSide: BorderSide(
-        color: borderColor(context),
-      ),
+      borderSide: BorderSide(color: borderColor(context)),
     );
     final enableBorder = border.copyWith(
       borderSide: BorderSide(

frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/toolbar_item/text_suggestions_toolbar_item.dart

@@ -84,12 +84,14 @@ class _SuggestionsActionListState extends State<SuggestionsActionList> {
   void initState() {
     super.initState();
     refreshSuggestions();
+    editorState.selectionNotifier.addListener(refreshSuggestions);
   }
 
   @override
   void dispose() {
-    super.dispose();
+    editorState.selectionNotifier.removeListener(refreshSuggestions);
     popoverController.close();
+    super.dispose();
   }
 
   @override
@@ -290,6 +292,7 @@ class _SuggestionsActionListState extends State<SuggestionsActionList> {
     }
     currentSuggestionItem =
         suggestions.where((item) => item.type == suggestionType).first;
+    if (mounted) setState(() {});
   }
 }