Skip to content

Commit 85b69bd

Browse files
authored
chore: cancel button not visible in [Reset to Default] for shortcuts(#7171) (#7257)
1 parent dd812d0 commit 85b69bd

File tree

2 files changed

+27
-27
lines changed

2 files changed

+27
-27
lines changed

frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_shortcuts_view.dart

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import 'package:appflowy/plugins/document/presentation/editor_plugins/copy_and_p
88
import 'package:appflowy/plugins/document/presentation/editor_plugins/toggle/toggle_block_shortcuts.dart';
99
import 'package:appflowy/workspace/application/settings/shortcuts/settings_shortcuts_cubit.dart';
1010
import 'package:appflowy/workspace/application/settings/shortcuts/settings_shortcuts_service.dart';
11+
import 'package:appflowy/workspace/presentation/home/menu/sidebar/space/shared_widget.dart';
1112
import 'package:appflowy/workspace/presentation/settings/shared/settings_alert_dialog.dart';
1213
import 'package:appflowy/workspace/presentation/settings/shared/settings_body.dart';
1314
import 'package:appflowy/workspace/presentation/settings/widgets/emoji_picker/emoji_shortcut_event.dart';
@@ -55,21 +56,24 @@ class _SettingsShortcutsViewState extends State<SettingsShortcutsView> {
5556
),
5657
const HSpace(10),
5758
_ResetButton(
58-
onReset: () => SettingsAlertDialog(
59-
isDangerous: true,
60-
title: LocaleKeys.settings_shortcutsPage_resetDialog_title
61-
.tr(),
62-
subtitle: LocaleKeys
63-
.settings_shortcutsPage_resetDialog_description
64-
.tr(),
65-
confirmLabel: LocaleKeys
66-
.settings_shortcutsPage_resetDialog_buttonLabel
67-
.tr(),
68-
confirm: () {
69-
Navigator.of(context).pop();
70-
context.read<ShortcutsCubit>().resetToDefault();
71-
},
72-
).show(context),
59+
onReset: () {
60+
showConfirmDialog(
61+
context: context,
62+
title: LocaleKeys.settings_shortcutsPage_resetDialog_title
63+
.tr(),
64+
description: LocaleKeys
65+
.settings_shortcutsPage_resetDialog_description
66+
.tr(),
67+
confirmLabel: LocaleKeys
68+
.settings_shortcutsPage_resetDialog_buttonLabel
69+
.tr(),
70+
onConfirm: () {
71+
context.read<ShortcutsCubit>().resetToDefault();
72+
Navigator.of(context).pop();
73+
},
74+
style: ConfirmPopupStyle.cancelAndOk,
75+
);
76+
},
7377
),
7478
],
7579
),

frontend/appflowy_flutter/lib/workspace/presentation/settings/shared/settings_alert_dialog.dart

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
1-
import 'package:flutter/material.dart';
2-
31
import 'package:appflowy/generated/flowy_svgs.g.dart';
42
import 'package:appflowy/generated/locale_keys.g.dart';
53
import 'package:easy_localization/easy_localization.dart';
64
import 'package:flowy_infra/size.dart';
7-
import 'package:flowy_infra/theme_extension.dart';
85
import 'package:flowy_infra_ui/flowy_infra_ui.dart';
96
import 'package:flowy_infra_ui/widget/dialog/styled_dialogs.dart';
7+
import 'package:flutter/material.dart';
108

119
class SettingsAlertDialog extends StatefulWidget {
1210
const SettingsAlertDialog({
@@ -201,18 +199,16 @@ class _Actions extends StatelessWidget {
201199
children: [
202200
if (!hideCancelButton) ...[
203201
SizedBox(
204-
height: 24,
205-
child: FlowyTextButton(
206-
LocaleKeys.button_cancel.tr(),
207-
padding: const EdgeInsets.symmetric(
202+
height: 48,
203+
child: PrimaryRoundedButton(
204+
text: LocaleKeys.button_cancel.tr(),
205+
margin: const EdgeInsets.symmetric(
208206
horizontal: 24,
209207
vertical: 12,
210208
),
211-
fontColor: AFThemeExtension.of(context).textColor,
212-
fillColor: Colors.transparent,
213-
hoverColor: Colors.transparent,
214-
radius: Corners.s12Border,
215-
onPressed: () {
209+
fontWeight: FontWeight.w600,
210+
radius: 12.0,
211+
onTap: () {
216212
cancel?.call();
217213
Navigator.of(context).pop();
218214
},

0 commit comments

Comments
 (0)