Skip to content

Commit 8970350

Browse files
authored
Merge pull request #528 from AppFlowy-IO/fix/grid_expand_column
fix: expand the list width after field's width changed
2 parents e2778ae + 2342a9b commit 8970350

File tree

2 files changed

+30
-12
lines changed

2 files changed

+30
-12
lines changed

frontend/app_flowy/lib/workspace/application/grid/grid_bloc.dart

Lines changed: 28 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import 'dart:async';
22
import 'package:dartz/dartz.dart';
3+
import 'package:equatable/equatable.dart';
34
import 'package:flowy_sdk/protobuf/flowy-error/errors.pb.dart';
45
import 'package:flowy_sdk/protobuf/flowy-folder-data-model/view.pb.dart';
56
import 'package:flowy_sdk/protobuf/flowy-grid-data-model/protobuf.dart';
@@ -8,6 +9,7 @@ import 'package:freezed_annotation/freezed_annotation.dart';
89
import 'cell/cell_service/cell_service.dart';
910
import 'grid_service.dart';
1011
import 'row/row_service.dart';
12+
import 'dart:collection';
1113

1214
part 'grid_bloc.freezed.dart';
1315

@@ -33,19 +35,19 @@ class GridBloc extends Bloc<GridEvent, GridState> {
3335

3436
on<GridEvent>(
3537
(event, emit) async {
36-
await event.map(
37-
initial: (InitialGrid value) async {
38+
await event.when(
39+
initial: () async {
3840
_startListening();
3941
await _loadGrid(emit);
4042
},
41-
createRow: (_CreateRow value) {
43+
createRow: () {
4244
_gridService.createRow();
4345
},
44-
didReceiveRowUpdate: (_DidReceiveRowUpdate value) {
45-
emit(state.copyWith(rows: value.rows, listState: value.listState));
46+
didReceiveRowUpdate: (rows, listState) {
47+
emit(state.copyWith(rows: rows, listState: listState));
4648
},
47-
didReceiveFieldUpdate: (_DidReceiveFieldUpdate value) {
48-
emit(state.copyWith(rows: rowCache.clonedRows, fields: value.fields));
49+
didReceiveFieldUpdate: (fields) {
50+
emit(state.copyWith(rows: rowCache.clonedRows, fields: GridFieldEquatable(fields)));
4951
},
5052
);
5153
},
@@ -93,7 +95,7 @@ class GridBloc extends Bloc<GridEvent, GridState> {
9395

9496
emit(state.copyWith(
9597
grid: Some(grid),
96-
fields: fieldCache.fields,
98+
fields: GridFieldEquatable(fieldCache.fields),
9799
rows: rowCache.clonedRows,
98100
loadingState: GridLoadingState.finish(left(unit)),
99101
));
@@ -117,14 +119,14 @@ class GridState with _$GridState {
117119
const factory GridState({
118120
required String gridId,
119121
required Option<Grid> grid,
120-
required List<Field> fields,
122+
required GridFieldEquatable fields,
121123
required List<GridRow> rows,
122124
required GridLoadingState loadingState,
123125
required GridRowChangeReason listState,
124126
}) = _GridState;
125127

126128
factory GridState.initial(String gridId) => GridState(
127-
fields: [],
129+
fields: const GridFieldEquatable([]),
128130
rows: [],
129131
grid: none(),
130132
gridId: gridId,
@@ -138,3 +140,19 @@ class GridLoadingState with _$GridLoadingState {
138140
const factory GridLoadingState.loading() = _Loading;
139141
const factory GridLoadingState.finish(Either<Unit, FlowyError> successOrFail) = _Finish;
140142
}
143+
144+
class GridFieldEquatable extends Equatable {
145+
final List<Field> _fields;
146+
147+
const GridFieldEquatable(List<Field> fields) : _fields = fields;
148+
149+
@override
150+
List<Object?> get props {
151+
return [
152+
_fields.length,
153+
_fields.map((field) => field.width).reduce((value, element) => value + element),
154+
];
155+
}
156+
157+
UnmodifiableListView<Field> get value => UnmodifiableListView(_fields);
158+
}

frontend/app_flowy/lib/workspace/presentation/plugins/grid/src/grid_page.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@ class _FlowyGridState extends State<FlowyGrid> {
9191
@override
9292
Widget build(BuildContext context) {
9393
return BlocBuilder<GridBloc, GridState>(
94-
buildWhen: (previous, current) => previous.fields.length != current.fields.length,
94+
buildWhen: (previous, current) => previous.fields != current.fields,
9595
builder: (context, state) {
96-
final contentWidth = GridLayout.headerWidth(state.fields);
96+
final contentWidth = GridLayout.headerWidth(state.fields.value);
9797
final child = _wrapScrollView(
9898
contentWidth,
9999
[

0 commit comments

Comments
 (0)