Skip to content

Commit aa5f052

Browse files
authored
Refactor/crate directory (#1621)
* chore: fix wanrings * chore: remove protobuf ref in flowy-error-code * chore: remove protobuf ref in lib-ws * refactor: remove protobuf trait in flowy http model * refactor: remove flowy-error-code crate Co-authored-by: nathan <[email protected]>
1 parent aae8259 commit aa5f052

File tree

167 files changed

+655
-923
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

167 files changed

+655
-923
lines changed

frontend/Makefile.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ CRATE_TYPE = "staticlib"
4343
LIB_EXT = "a"
4444
APP_ENVIRONMENT = "local"
4545
FLUTTER_FLOWY_SDK_PATH = "app_flowy/packages/flowy_sdk"
46-
PROTOBUF_DERIVE_CACHE = "../shared-lib/flowy-derive/src/derive_cache/derive_cache.rs"
4746
# Test default config
4847
TEST_CRATE_TYPE = "cdylib"
4948
TEST_LIB_EXT = "dylib"

frontend/app_flowy/lib/plugins/grid/application/cell/date_cal_bloc.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import 'package:app_flowy/plugins/grid/application/field/field_service.dart';
33
import 'package:easy_localization/easy_localization.dart'
44
show StringTranslateExtension;
55
import 'package:flowy_sdk/log.dart';
6-
import 'package:flowy_sdk/protobuf/flowy-error-code/code.pb.dart';
6+
import 'package:flowy_sdk/protobuf/flowy-error/code.pb.dart';
77
import 'package:flowy_sdk/protobuf/flowy-error/errors.pb.dart';
88
import 'package:flowy_sdk/protobuf/flowy-grid/date_type_option.pb.dart';
99
import 'package:flowy_sdk/protobuf/flowy-grid/date_type_option_entities.pb.dart';

frontend/app_flowy/lib/user/application/sign_in_bloc.dart

Lines changed: 28 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import 'package:app_flowy/user/application/auth_service.dart';
22
import 'package:dartz/dartz.dart';
3-
import 'package:flowy_sdk/protobuf/flowy-error-code/code.pb.dart';
3+
import 'package:flowy_sdk/protobuf/flowy-error/code.pb.dart';
44
import 'package:flowy_sdk/protobuf/flowy-error/errors.pb.dart';
55
import 'package:flowy_sdk/protobuf/flowy-user/protobuf.dart' show UserProfilePB;
66
import 'package:freezed_annotation/freezed_annotation.dart';
@@ -20,43 +20,61 @@ class SignInBloc extends Bloc<SignInEvent, SignInState> {
2020
);
2121
},
2222
emailChanged: (EmailChanged value) async {
23-
emit(state.copyWith(email: value.email, emailError: none(), successOrFail: none()));
23+
emit(state.copyWith(
24+
email: value.email, emailError: none(), successOrFail: none()));
2425
},
2526
passwordChanged: (PasswordChanged value) async {
26-
emit(state.copyWith(password: value.password, passwordError: none(), successOrFail: none()));
27+
emit(state.copyWith(
28+
password: value.password,
29+
passwordError: none(),
30+
successOrFail: none()));
2731
},
2832
);
2933
});
3034
}
3135

32-
Future<void> _performActionOnSignIn(SignInState state, Emitter<SignInState> emit) async {
33-
emit(state.copyWith(isSubmitting: true, emailError: none(), passwordError: none(), successOrFail: none()));
36+
Future<void> _performActionOnSignIn(
37+
SignInState state, Emitter<SignInState> emit) async {
38+
emit(state.copyWith(
39+
isSubmitting: true,
40+
emailError: none(),
41+
passwordError: none(),
42+
successOrFail: none()));
3443

3544
final result = await authService.signIn(
3645
email: state.email,
3746
password: state.password,
3847
);
3948
emit(result.fold(
40-
(userProfile) => state.copyWith(isSubmitting: false, successOrFail: some(left(userProfile))),
49+
(userProfile) => state.copyWith(
50+
isSubmitting: false, successOrFail: some(left(userProfile))),
4151
(error) => stateFromCode(error),
4252
));
4353
}
4454

4555
SignInState stateFromCode(FlowyError error) {
4656
switch (ErrorCode.valueOf(error.code)!) {
4757
case ErrorCode.EmailFormatInvalid:
48-
return state.copyWith(isSubmitting: false, emailError: some(error.msg), passwordError: none());
58+
return state.copyWith(
59+
isSubmitting: false,
60+
emailError: some(error.msg),
61+
passwordError: none());
4962
case ErrorCode.PasswordFormatInvalid:
50-
return state.copyWith(isSubmitting: false, passwordError: some(error.msg), emailError: none());
63+
return state.copyWith(
64+
isSubmitting: false,
65+
passwordError: some(error.msg),
66+
emailError: none());
5167
default:
52-
return state.copyWith(isSubmitting: false, successOrFail: some(right(error)));
68+
return state.copyWith(
69+
isSubmitting: false, successOrFail: some(right(error)));
5370
}
5471
}
5572
}
5673

5774
@freezed
5875
class SignInEvent with _$SignInEvent {
59-
const factory SignInEvent.signedInWithUserEmailAndPassword() = SignedInWithUserEmailAndPassword;
76+
const factory SignInEvent.signedInWithUserEmailAndPassword() =
77+
SignedInWithUserEmailAndPassword;
6078
const factory SignInEvent.emailChanged(String email) = EmailChanged;
6179
const factory SignInEvent.passwordChanged(String password) = PasswordChanged;
6280
}

frontend/app_flowy/lib/user/application/sign_up_bloc.dart

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'package:app_flowy/user/application/auth_service.dart';
22
import 'package:dartz/dartz.dart';
33
import 'package:easy_localization/easy_localization.dart';
4-
import 'package:flowy_sdk/protobuf/flowy-error-code/code.pb.dart';
4+
import 'package:flowy_sdk/protobuf/flowy-error/code.pb.dart';
55
import 'package:flowy_sdk/protobuf/flowy-user/protobuf.dart' show UserProfilePB;
66
import 'package:flowy_sdk/protobuf/flowy-error/errors.pb.dart';
77
import 'package:freezed_annotation/freezed_annotation.dart';
@@ -17,11 +17,18 @@ class SignUpBloc extends Bloc<SignUpEvent, SignUpState> {
1717
await event.map(signUpWithUserEmailAndPassword: (e) async {
1818
await _performActionOnSignUp(emit);
1919
}, emailChanged: (_EmailChanged value) async {
20-
emit(state.copyWith(email: value.email, emailError: none(), successOrFail: none()));
20+
emit(state.copyWith(
21+
email: value.email, emailError: none(), successOrFail: none()));
2122
}, passwordChanged: (_PasswordChanged value) async {
22-
emit(state.copyWith(password: value.password, passwordError: none(), successOrFail: none()));
23+
emit(state.copyWith(
24+
password: value.password,
25+
passwordError: none(),
26+
successOrFail: none()));
2327
}, repeatPasswordChanged: (_RepeatPasswordChanged value) async {
24-
emit(state.copyWith(repeatedPassword: value.password, repeatPasswordError: none(), successOrFail: none()));
28+
emit(state.copyWith(
29+
repeatedPassword: value.password,
30+
repeatPasswordError: none(),
31+
successOrFail: none()));
2532
});
2633
});
2734
}
@@ -45,15 +52,17 @@ class SignUpBloc extends Bloc<SignUpEvent, SignUpState> {
4552
if (repeatedPassword == null) {
4653
emit(state.copyWith(
4754
isSubmitting: false,
48-
repeatPasswordError: some(LocaleKeys.signUp_repeatPasswordEmptyError.tr()),
55+
repeatPasswordError:
56+
some(LocaleKeys.signUp_repeatPasswordEmptyError.tr()),
4957
));
5058
return;
5159
}
5260

5361
if (password != repeatedPassword) {
5462
emit(state.copyWith(
5563
isSubmitting: false,
56-
repeatPasswordError: some(LocaleKeys.signUp_unmatchedPasswordError.tr()),
64+
repeatPasswordError:
65+
some(LocaleKeys.signUp_unmatchedPasswordError.tr()),
5766
));
5867
return;
5968
}
@@ -97,17 +106,20 @@ class SignUpBloc extends Bloc<SignUpEvent, SignUpState> {
97106
successOrFail: none(),
98107
);
99108
default:
100-
return state.copyWith(isSubmitting: false, successOrFail: some(right(error)));
109+
return state.copyWith(
110+
isSubmitting: false, successOrFail: some(right(error)));
101111
}
102112
}
103113
}
104114

105115
@freezed
106116
class SignUpEvent with _$SignUpEvent {
107-
const factory SignUpEvent.signUpWithUserEmailAndPassword() = SignUpWithUserEmailAndPassword;
117+
const factory SignUpEvent.signUpWithUserEmailAndPassword() =
118+
SignUpWithUserEmailAndPassword;
108119
const factory SignUpEvent.emailChanged(String email) = _EmailChanged;
109120
const factory SignUpEvent.passwordChanged(String password) = _PasswordChanged;
110-
const factory SignUpEvent.repeatPasswordChanged(String password) = _RepeatPasswordChanged;
121+
const factory SignUpEvent.repeatPasswordChanged(String password) =
122+
_RepeatPasswordChanged;
111123
}
112124

113125
@freezed

frontend/app_flowy/lib/user/application/user_listener.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import 'dart:async';
22
import 'package:app_flowy/core/folder_notification.dart';
33
import 'package:app_flowy/core/user_notification.dart';
44
import 'package:dartz/dartz.dart';
5-
import 'package:flowy_sdk/protobuf/flowy-error-code/code.pb.dart';
5+
import 'package:flowy_sdk/protobuf/flowy-error/code.pb.dart';
66
import 'package:flowy_sdk/protobuf/flowy-folder/workspace.pb.dart';
77
import 'package:flowy_sdk/protobuf/flowy-error/errors.pb.dart';
88
import 'dart:typed_data';

frontend/app_flowy/lib/user/presentation/splash_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import 'package:flowy_sdk/dispatch/dispatch.dart';
22
import 'package:flowy_sdk/log.dart';
3-
import 'package:flowy_sdk/protobuf/flowy-error-code/code.pb.dart';
3+
import 'package:flowy_sdk/protobuf/flowy-error/code.pb.dart';
44
import 'package:flutter/material.dart';
55
import 'package:flutter_bloc/flutter_bloc.dart';
66

frontend/app_flowy/lib/workspace/application/home/home_bloc.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'package:app_flowy/user/application/user_listener.dart';
22
import 'package:flowy_infra/time/duration.dart';
33
import 'package:flowy_sdk/log.dart';
4-
import 'package:flowy_sdk/protobuf/flowy-error-code/code.pb.dart';
4+
import 'package:flowy_sdk/protobuf/flowy-error/code.pb.dart';
55
import 'package:flowy_sdk/protobuf/flowy-error/errors.pb.dart';
66
import 'package:flowy_sdk/protobuf/flowy-folder/view.pb.dart';
77
import 'package:flowy_sdk/protobuf/flowy-folder/workspace.pb.dart'

frontend/rust-lib/Cargo.lock

Lines changed: 32 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frontend/rust-lib/Cargo.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ members = [
1616
"flowy-revision",
1717
"flowy-grid",
1818
"flowy-task",
19+
"flowy-sync",
20+
"flowy-derive",
21+
"flowy-ast",
22+
"flowy-codegen",
1923
]
2024

2125
[profile.dev]

frontend/rust-lib/dart-ffi/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ parking_lot = "0.12.1"
2828
lib-dispatch = { path = "../lib-dispatch" }
2929
flowy-sdk = { path = "../flowy-sdk" }
3030
dart-notify = { path = "../dart-notify" }
31-
flowy-derive = { path = "../../../shared-lib/flowy-derive" }
31+
flowy-derive = { path = "../flowy-derive" }
3232

3333
[features]
3434
default = ["flowy-sdk/dart", "dart-notify/dart", "flutter"]
@@ -37,7 +37,7 @@ http_sync = ["flowy-sdk/http_sync", "flowy-sdk/use_bunyan"]
3737
openssl_vendored = ["flowy-sdk/openssl_vendored"]
3838

3939
[build-dependencies]
40-
flowy-codegen= { path = "../../../shared-lib/flowy-codegen", features = [
40+
flowy-codegen = { path = "../flowy-codegen", features = [
4141
"dart",
4242
]}
4343

0 commit comments

Comments
 (0)