Skip to content

Commit b25db83

Browse files
authored
ci: support linux dart_unit_test (#1653)
Co-authored-by: nathan <[email protected]>
1 parent c181f91 commit b25db83

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

.github/workflows/flutter_ci.yaml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,4 @@ jobs:
104104
- name: Run Flutter unit tests
105105
working-directory: frontend
106106
run: |
107-
if [ "$RUNNER_OS" == "macOS" ]; then
108-
cargo make dart_unit_test
109-
elif [ "$RUNNER_OS" == "Windows" ]; then
110-
cargo make dart_unit_test
111-
fi
112-
shell: bash
107+
cargo make dart_unit_test

frontend/app_flowy/test/bloc_test/grid_test/filter/filter_util.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,6 @@ Future<void> editCells(GridTestContext context) async {
3838
final controller1 = await context.makeTextCellController(1);
3939

4040
controller0.saveCellData('A');
41+
await gridResponseFuture();
4142
controller1.saveCellData('B');
4243
}

frontend/rust-lib/flowy-grid/src/services/block_editor.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ impl GridBlockRevisionEditor {
119119

120120
pub async fn get_row_rev(&self, row_id: &str) -> FlowyResult<Option<(usize, Arc<RowRevision>)>> {
121121
if self.pad.try_read().is_err() {
122-
tracing::error!("Required GridBlockRevisionPad's read lock failed");
122+
tracing::error!("Required grid block read lock failed");
123123
Ok(None)
124124
} else {
125125
let row_rev = self.pad.read().await.get_row_rev(row_id);

frontend/scripts/makefile/tests.toml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
[tasks.dart_unit_test]
33
script = '''
4-
cargo make dart_unit_test_inner
4+
cargo make --profile test-macos dart_unit_test_inner
55
'''
66
script_runner = "@shell"
77

@@ -11,6 +11,12 @@ cargo make --profile test-windows dart_unit_test_inner
1111
'''
1212
script_runner = "@shell"
1313

14+
[tasks.dart_unit_test.linux]
15+
script = '''
16+
cargo make --profile test-linux dart_unit_test_inner
17+
'''
18+
script_runner = "@shell"
19+
1420
[tasks.dart_unit_test_inner]
1521
dependencies = ["build-test-lib"]
1622
description = "Run flutter unit tests"

0 commit comments

Comments
 (0)