Skip to content

Commit b7ba189

Browse files
authored
Feat/sort UI (#1642)
* feat: implement sort UI * chore: config sort listener * chore: config sort ui * chore: config sort ui * feat: support ascending & descending * fix: reorder rows bugs * chore: add tests Co-authored-by: nathan <[email protected]>
1 parent 92baa57 commit b7ba189

File tree

77 files changed

+2803
-411
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

77 files changed

+2803
-411
lines changed

frontend/app_flowy/assets/translations/en.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@
193193
"grid": {
194194
"settings": {
195195
"filter": "Filter",
196+
"sort": "Sort",
196197
"sortBy": "Sort by",
197198
"Properties": "Properties",
198199
"group": "Group",
@@ -273,6 +274,12 @@
273274
"newColumn": "New column",
274275
"deleteFieldPromptMessage": "Are you sure? This property will be deleted"
275276
},
277+
"sort": {
278+
"ascending": "Ascending",
279+
"descending": "Descending",
280+
"deleteSort": "Delete sort",
281+
"addSort": "Add sort"
282+
},
276283
"row": {
277284
"duplicate": "Duplicate",
278285
"delete": "Delete",

frontend/app_flowy/lib/plugins/board/application/board_data_controller.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ class BoardDataController {
132132
}
133133

134134
Future<void> dispose() async {
135+
await _viewCache.dispose();
135136
await _gridFFIService.closeGrid();
136137
await fieldController.dispose();
137138
}

0 commit comments

Comments
 (0)