chore: update data & time format

Author: appflowy

frontend/app_flowy/lib/workspace/application/grid/cell/cell_service/context_builder.dart

@@ -27,7 +27,7 @@ class GridCellContextBuilder {
           gridCell: _gridCell,
           cellCache: _cellCache,
           cellDataLoader: DateCellDataLoader(gridCell: _gridCell),
-          cellDataPersistence: NumberCellDataPersistence(gridCell: _gridCell),
+          cellDataPersistence: DateCellDataPersistence(gridCell: _gridCell),
         );
       case FieldType.Number:
         return GridCellContext(
@@ -120,7 +120,7 @@ class _GridCellContext<T, D> extends Equatable {
       _onFieldChangedFn = () {
         _loadData();
       };
-      cellCache.addListener(_cacheKey, _onFieldChangedFn!);
+      cellCache.addFieldListener(_cacheKey, _onFieldChangedFn!);
     }
 
     onCellChangedFn() {
@@ -172,7 +172,7 @@ class _GridCellContext<T, D> extends Equatable {
     _delayOperation?.cancel();
 
     if (_onFieldChangedFn != null) {
-      cellCache.removeListener(_cacheKey, _onFieldChangedFn!);
+      cellCache.removeFieldListener(_cacheKey, _onFieldChangedFn!);
       _onFieldChangedFn = null;
     }
   }

frontend/app_flowy/lib/workspace/application/grid/cell/cell_service/data_cache.dart

@@ -30,7 +30,7 @@ class GridCellCache {
   final GridCellFieldDelegate fieldDelegate;
 
   /// fieldId: {objectId: callback}
-  final Map<String, Map<String, List<VoidCallback>>> _listenerByFieldId = {};
+  final Map<String, Map<String, List<VoidCallback>>> _fieldListenerByFieldId = {};
 
   /// fieldId: {cacheKey: cacheData}
   final Map<String, Map<String, dynamic>> _cellDataByFieldId = {};
@@ -40,7 +40,7 @@ class GridCellCache {
   }) {
     fieldDelegate.onFieldChanged((fieldId) {
       _cellDataByFieldId.remove(fieldId);
-      final map = _listenerByFieldId[fieldId];
+      final map = _fieldListenerByFieldId[fieldId];
       if (map != null) {
         for (final callbacks in map.values) {
           for (final callback in callbacks) {
@@ -51,24 +51,24 @@ class GridCellCache {
     });
   }
 
-  void addListener(GridCellCacheKey cacheKey, VoidCallback callback) {
-    var map = _listenerByFieldId[cacheKey.fieldId];
+  void addFieldListener(GridCellCacheKey cacheKey, VoidCallback onFieldChanged) {
+    var map = _fieldListenerByFieldId[cacheKey.fieldId];
     if (map == null) {
-      _listenerByFieldId[cacheKey.fieldId] = {};
-      map = _listenerByFieldId[cacheKey.fieldId];
-      map![cacheKey.objectId] = [callback];
+      _fieldListenerByFieldId[cacheKey.fieldId] = {};
+      map = _fieldListenerByFieldId[cacheKey.fieldId];
+      map![cacheKey.objectId] = [onFieldChanged];
     } else {
       var objects = map[cacheKey.objectId];
       if (objects == null) {
-        map[cacheKey.objectId] = [callback];
+        map[cacheKey.objectId] = [onFieldChanged];
       } else {
-        objects.add(callback);
+        objects.add(onFieldChanged);
       }
     }
   }
 
-  void removeListener(GridCellCacheKey cacheKey, VoidCallback fn) {
-    var callbacks = _listenerByFieldId[cacheKey.fieldId]?[cacheKey.objectId];
+  void removeFieldListener(GridCellCacheKey cacheKey, VoidCallback fn) {
+    var callbacks = _fieldListenerByFieldId[cacheKey.fieldId]?[cacheKey.objectId];
     final index = callbacks?.indexWhere((callback) => callback == fn);
     if (index != null && index != -1) {
       callbacks?.removeAt(index);

frontend/app_flowy/lib/workspace/application/grid/cell/cell_service/data_loader.dart

@@ -61,12 +61,13 @@ class CellDataLoader extends _GridCellDataLoader<Cell> {
 
 class DateCellDataLoader extends _GridCellDataLoader<DateCellData> {
   final GridCell gridCell;
+  final GridCellDataConfig _config;
   DateCellDataLoader({
     required this.gridCell,
-  });
+  }) : _config = DefaultCellDataConfig(reloadOnFieldChanged: true);
 
   @override
-  GridCellDataConfig get config => DefaultCellDataConfig();
+  GridCellDataConfig get config => _config;
 
   @override
   Future<DateCellData?> loadData() {

frontend/app_flowy/lib/workspace/application/grid/cell/cell_service/data_persistence.dart

@@ -35,9 +35,9 @@ class DateCellPersistenceData with _$DateCellPersistenceData {
   const factory DateCellPersistenceData({required DateTime date, String? time}) = _DateCellPersistenceData;
 }
 
-class NumberCellDataPersistence implements _GridCellDataPersistence<DateCellPersistenceData> {
+class DateCellDataPersistence implements _GridCellDataPersistence<DateCellPersistenceData> {
   final GridCell gridCell;
-  NumberCellDataPersistence({
+  DateCellDataPersistence({
     required this.gridCell,
   });
 
@@ -47,10 +47,7 @@ class NumberCellDataPersistence implements _GridCellDataPersistence<DateCellPers
 
     final date = (data.date.millisecondsSinceEpoch ~/ 1000).toString();
     payload.date = date;
-
-    if (data.time != null) {
-      payload.time = data.time!;
-    }
+    payload.time = data.time ?? "";
 
     return GridEventUpdateDateCell(payload).send().then((result) {
       return result.fold(

frontend/app_flowy/lib/workspace/application/grid/cell/date_cal_bloc.dart

@@ -1,6 +1,6 @@
 import 'package:app_flowy/workspace/application/grid/field/field_service.dart';
 import 'package:flowy_sdk/log.dart';
-import 'package:flowy_sdk/protobuf/flowy-error/errors.pb.dart';
+import 'package:flowy_sdk/protobuf/flowy-error-code/code.pb.dart';
 import 'package:flowy_sdk/protobuf/flowy-grid/date_type_option.pb.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:freezed_annotation/freezed_annotation.dart';
@@ -25,8 +25,8 @@ class DateCalBloc extends Bloc<DateCalEvent, DateCalState> {
       (event, emit) async {
         await event.when(
           initial: () async => _startListening(),
-          selectDay: (date) {
-            _updateDateData(emit, date: date);
+          selectDay: (date) async {
+            await _updateDateData(emit, date: date, time: state.time);
           },
           setCalFormat: (format) {
             emit(state.copyWith(format: format));
@@ -44,22 +44,19 @@ class DateCalBloc extends Bloc<DateCalEvent, DateCalState> {
           setTimeFormat: (timeFormat) async {
             await _updateTypeOption(emit, timeFormat: timeFormat);
           },
-          setTime: (time) {
-            _updateDateData(emit, time: time);
+          setTime: (time) async {
+            await _updateDateData(emit, time: time);
           },
         );
       },
     );
   }
 
-  void _updateDateData(Emitter<DateCalState> emit, {DateTime? date, String? time}) {
-    state.dateData.fold(
+  Future<void> _updateDateData(Emitter<DateCalState> emit, {DateTime? date, String? time}) {
+    final DateCellPersistenceData newDateData = state.dateData.fold(
       () {
         var newDateData = DateCellPersistenceData(date: date ?? DateTime.now());
-        if (time != null) {
-          newDateData = newDateData.copyWith(time: time);
-        }
-        emit(state.copyWith(dateData: Some(newDateData)));
+        return newDateData.copyWith(time: time);
       },
       (dateData) {
         var newDateData = dateData;
@@ -70,9 +67,34 @@ class DateCalBloc extends Bloc<DateCalEvent, DateCalState> {
         if (newDateData.time != time) {
           newDateData = newDateData.copyWith(time: time);
         }
+        return newDateData;
+      },
+    );
 
-        if (newDateData != dateData) {
-          emit(state.copyWith(dateData: Some(newDateData)));
+    return _saveDateData(emit, newDateData);
+  }
+
+  Future<void> _saveDateData(Emitter<DateCalState> emit, DateCellPersistenceData newDateData) async {
+    if (state.dateData == Some(newDateData)) {
+      return;
+    }
+
+    final result = await cellContext.saveCellData(newDateData);
+    result.fold(
+      () => emit(state.copyWith(
+        dateData: Some(newDateData),
+        timeFormatError: none(),
+      )),
+      (err) {
+        switch (ErrorCode.valueOf(err.code)!) {
+          case ErrorCode.InvalidDateTimeFormat:
+            emit(state.copyWith(
+              dateData: Some(newDateData),
+              timeFormatError: Some(err.toString()),
+            ));
+            break;
+          default:
+            Log.error(err);
         }
       },
     );
@@ -152,7 +174,7 @@ class DateCalState with _$DateCalState {
     required CalendarFormat format,
     required DateTime focusedDay,
     required String time,
-    required Option<FlowyError> inputTimeError,
+    required Option<String> timeFormatError,
     required Option<DateCellPersistenceData> dateData,
   }) = _DateCalState;
 
@@ -175,7 +197,7 @@ class DateCalState with _$DateCalState {
       focusedDay: DateTime.now(),
       dateData: dateData,
       time: time,
-      inputTimeError: none(),
+      timeFormatError: none(),
     );
   }
 }

frontend/app_flowy/lib/workspace/application/grid/cell/date_cell_bloc.dart

@@ -16,7 +16,6 @@ class DateCellBloc extends Bloc<DateCellEvent, DateCellState> {
       (event, emit) async {
         event.when(
           initial: () => _startListening(),
-          selectDate: (DateCellPersistenceData value) => cellContext.saveCellData(value),
           didReceiveCellUpdate: (DateCellData value) => emit(state.copyWith(data: Some(value))),
           didReceiveFieldUpdate: (Field value) => emit(state.copyWith(field: value)),
         );
@@ -48,7 +47,6 @@ class DateCellBloc extends Bloc<DateCellEvent, DateCellState> {
 @freezed
 class DateCellEvent with _$DateCellEvent {
   const factory DateCellEvent.initial() = _InitialCell;
-  const factory DateCellEvent.selectDate(DateCellPersistenceData data) = _SelectDay;
   const factory DateCellEvent.didReceiveCellUpdate(DateCellData data) = _DidReceiveCellUpdate;
   const factory DateCellEvent.didReceiveFieldUpdate(Field field) = _DidReceiveFieldUpdate;
 }