fix: some launch review issues

Author: asjqkkkk

frontend/appflowy_flutter/integration_test/mobile/document/slash_menu_test.dart

@@ -1,3 +1,4 @@
+import 'package:appflowy/mobile/presentation/selection_menu/mobile_selection_menu_item.dart';
 import 'package:appflowy/mobile/presentation/selection_menu/mobile_selection_menu_item_widget.dart';
 import 'package:appflowy/mobile/presentation/selection_menu/mobile_selection_menu_widget.dart';
 import 'package:appflowy/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items/mobile_items.dart';
@@ -36,8 +37,16 @@ void main() {
       await tester.ime.insertText(searchText);
       final itemWidgets = find.byType(MobileSelectionMenuItemWidget);
       int number = 0;
-      for (final mobileItem in mobileItems) {
-        for (final item in mobileItem.children) {
+      for (final item in mobileItems) {
+        if (item is MobileSelectionMenuItem) {
+          for (final childItem in item.children) {
+            if (childItem.name
+                .toLowerCase()
+                .contains(searchText.toLowerCase())) {
+              number++;
+            }
+          }
+        } else {
           if (item.name.toLowerCase().contains(searchText.toLowerCase())) {
             number++;
           }
@@ -55,6 +64,7 @@ void main() {
         matching: find.byType(ListView),
       );
       for (final item in mobileItems) {
+        if (item is! MobileSelectionMenuItem) continue;
         await tester.editor.showSlashMenu();
         await tester.scrollUntilVisible(
           find.text(item.name),

frontend/appflowy_flutter/lib/mobile/presentation/base/mobile_view_page.dart

@@ -304,11 +304,13 @@ class _MobileViewPageState extends State<MobileViewPage> {
                 ),
                 const HSpace(4),
               ],
-              FlowyText.medium(
-                widget.fixedTitle ?? view?.name ?? widget.title ?? '',
-                fontSize: 15.0,
-                overflow: TextOverflow.ellipsis,
-                figmaLineHeight: 18.0,
+              Flexible(
+                child: FlowyText.medium(
+                  widget.fixedTitle ?? view?.name ?? widget.title ?? ' ',
+                  fontSize: 15.0,
+                  overflow: TextOverflow.ellipsis,
+                  figmaLineHeight: 18.0,
+                ),
               ),
               const HSpace(4.0),
               _buildLockStatusIcon(context, view),

frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu.dart

@@ -1,4 +1,5 @@
 import 'dart:async';
+import 'dart:math';
 
 import 'package:appflowy/mobile/presentation/selection_menu/mobile_selection_menu_item.dart';
 import 'package:appflowy_editor/appflowy_editor.dart';
@@ -172,7 +173,7 @@ class MobileSelectionMenu extends SelectionMenuService {
     // Workaround: We can customize the padding through the [EditorStyle],
     // but the coordinates of overlay are not properly converted currently.
     // Just subtract the padding here as a result.
-    const menuHeight = 192.0;
+    const menuHeight = 192.0, menuWidth = 240.0 + 10;
     const menuOffset = Offset(0, 10);
     final editorOffset =
         editorState.renderBox?.localToGlobal(Offset.zero) ?? Offset.zero;
@@ -194,8 +195,9 @@ class MobileSelectionMenu extends SelectionMenuService {
       offset = topRight - menuOffset;
       _alignment = Alignment.bottomLeft;
 
+      final limitX = editorWidth - menuWidth;
       _offset = Offset(
-        offset.dx,
+        min(offset.dx, limitX),
         MediaQuery.of(context).size.height - offset.dy,
       );
     }
@@ -206,8 +208,10 @@ class MobileSelectionMenu extends SelectionMenuService {
           ? Alignment.topRight
           : Alignment.bottomRight;
 
+      final x = editorWidth - _offset.dx + editorOffset.dx;
+      final limitX = editorWidth - menuWidth + editorOffset.dx;
       _offset = Offset(
-        editorWidth - _offset.dx + editorOffset.dx,
+        min(x, limitX),
         _offset.dy,
       );
     }

frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu_item_widget.dart

@@ -58,7 +58,7 @@ class MobileSelectionMenuItemWidget extends StatelessWidget {
               Spacer(),
               Icon(
                 Icons.keyboard_arrow_right_rounded,
-                color: Color(0xff1E2022).withValues(alpha: 0.3),
+                color: style.selectionMenuItemTextColor.withValues(alpha: 0.3),
               ),
             ],
           ],

frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items/mobile_items.dart

@@ -7,24 +7,24 @@ import 'package:easy_localization/easy_localization.dart';
 
 import 'slash_menu_items.dart';
 
-final List<MobileSelectionMenuItem> mobileItems = [
+final List<SelectionMenuItem> mobileItems = [
   textStyleMobileSlashMenuItem,
   listMobileSlashMenuItem,
   toggleListMobileSlashMenuItem,
   fileOrMediaMobileSlashMenuItem,
   decorationsMobileSlashMenuItem,
-  tableMobileSlashMenuItem,
-  dateOrReminderMobileSlashMenuItem,
+  tableSlashMenuItem,
+  dateOrReminderSlashMenuItem,
   advancedMobileSlashMenuItem,
 ];
 
-final List<MobileSelectionMenuItem> mobileItemsInTale = [
+final List<SelectionMenuItem> mobileItemsInTale = [
   textStyleMobileSlashMenuItem,
   listMobileSlashMenuItem,
   toggleListMobileSlashMenuItem,
   fileOrMediaMobileSlashMenuItem,
   decorationsMobileSlashMenuItem,
-  dateOrReminderMobileSlashMenuItem,
+  dateOrReminderSlashMenuItem,
   advancedMobileSlashMenuItem,
 ];
 
@@ -113,31 +113,6 @@ MobileSelectionMenuItem decorationsMobileSlashMenuItem =
   ],
 );
 
-MobileSelectionMenuItem tableMobileSlashMenuItem = MobileSelectionMenuItem(
-  getName: LocaleKeys.document_slashMenu_name_table.tr,
-  handler: _handler,
-  icon: (_, isSelected, style) => SelectableSvgWidget(
-    data: FlowySvgs.slash_menu_icon_simple_table_s,
-    isSelected: isSelected,
-    style: style,
-  ),
-  nameBuilder: slashMenuItemNameBuilder,
-  children: [tableSlashMenuItem],
-);
-
-MobileSelectionMenuItem dateOrReminderMobileSlashMenuItem =
-    MobileSelectionMenuItem(
-  getName: LocaleKeys.document_slashMenu_name_dateOrReminder.tr,
-  handler: _handler,
-  icon: (_, isSelected, style) => SelectableSvgWidget(
-    data: FlowySvgs.slash_menu_icon_date_or_reminder_s,
-    isSelected: isSelected,
-    style: style,
-  ),
-  nameBuilder: slashMenuItemNameBuilder,
-  children: [dateOrReminderSlashMenuItem],
-);
-
 MobileSelectionMenuItem advancedMobileSlashMenuItem = MobileSelectionMenuItem(
   getName: LocaleKeys.document_slashMenu_name_advanced.tr,
   handler: _handler,

frontend/appflowy_flutter/lib/plugins/inline_actions/handlers/inline_page_reference.dart

@@ -236,7 +236,7 @@ class InlinePageReferenceService extends InlineActionsDelegate {
         keywords: [view.nameOrDefault.toLowerCase()],
         label: view.nameOrDefault,
         icon: (onSelected) => view.icon.value.isNotEmpty
-            ? EmojiIconWidget(
+            ? RawEmojiIconWidget(
                 emoji: view.icon.toEmojiIconData(),
                 emojiSize: 14,
               )

frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_menu_group.dart

@@ -92,18 +92,27 @@ class InlineActionsWidget extends StatefulWidget {
 class _InlineActionsWidgetState extends State<InlineActionsWidget> {
   @override
   Widget build(BuildContext context) {
+    final icon = widget.item.icon;
+    final hasIcon = icon != null;
     return Padding(
       padding: const EdgeInsets.symmetric(vertical: 2),
       child: SizedBox(
         width: kInlineMenuWidth,
         child: FlowyButton(
           expand: true,
           isSelected: widget.isSelected,
-          leftIcon: widget.item.icon?.call(widget.isSelected),
-          text: FlowyText.regular(
-            widget.item.label,
-            figmaLineHeight: 18,
-            overflow: TextOverflow.ellipsis,
+          text: Row(
+            children: [
+              if (hasIcon) ...[
+                icon.call(widget.isSelected),
+                SizedBox(width: 12),
+              ],
+              FlowyText.regular(
+                widget.item.label,
+                figmaLineHeight: 18,
+                overflow: TextOverflow.ellipsis,
+              ),
+            ],
           ),
           onTap: _onPressed,
         ),