Skip to content

Commit fad02eb

Browse files
fix: remove useless onTap
1 parent 8f1752a commit fad02eb

File tree

3 files changed

+0
-15
lines changed

3 files changed

+0
-15
lines changed

frontend/app_flowy/lib/plugins/grid/presentation/widgets/common/text_field.dart

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ class InputTextField extends StatefulWidget {
99
final void Function(String)? onDone;
1010
final void Function(String)? onChanged;
1111
final void Function() onCanceled;
12-
final void Function()? onTap;
1312
final bool autoClearWhenDone;
1413
final String text;
1514
final int? maxLength;
@@ -20,7 +19,6 @@ class InputTextField extends StatefulWidget {
2019
this.onDone,
2120
required this.onCanceled,
2221
this.onChanged,
23-
this.onTap,
2422
this.autoClearWhenDone = false,
2523
this.maxLength,
2624
this.focusNode,
@@ -75,11 +73,6 @@ class _InputTextFieldState extends State<InputTextField> {
7573
_controller.text = "";
7674
}
7775
},
78-
onTap: () {
79-
if (widget.onTap != null) {
80-
widget.onTap!();
81-
}
82-
},
8376
);
8477
}
8578

frontend/app_flowy/lib/plugins/grid/presentation/widgets/header/type_option/select_option.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,6 @@ class _AddOptionButton extends StatelessWidget {
256256
fontSize: 12),
257257
hoverColor: theme.hover,
258258
onTap: () {
259-
popoverMutex?.close();
260259
context
261260
.read<SelectOptionTypeOptionBloc>()
262261
.add(const SelectOptionTypeOptionEvent.addingOption());

frontend/app_flowy/packages/flowy_infra_ui/lib/widget/rounded_input_field.dart

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ class RoundedInputField extends StatefulWidget {
1919
final TextStyle style;
2020
final ValueChanged<String>? onChanged;
2121
final Function(String)? onEditingComplete;
22-
final Function()? onTap;
2322
final String? initialValue;
2423
final EdgeInsets margin;
2524
final EdgeInsets padding;
@@ -40,7 +39,6 @@ class RoundedInputField extends StatefulWidget {
4039
this.obscureHideIcon,
4140
this.onChanged,
4241
this.onEditingComplete,
43-
this.onTap,
4442
this.normalBorderColor = Colors.transparent,
4543
this.errorBorderColor = Colors.transparent,
4644
this.focusBorderColor,
@@ -111,11 +109,6 @@ class _RoundedInputFieldState extends State<RoundedInputField> {
111109
widget.onEditingComplete!(inputText);
112110
}
113111
},
114-
onTap: () {
115-
if (widget.onTap != null) {
116-
widget.onTap!();
117-
}
118-
},
119112
cursorColor: widget.cursorColor,
120113
obscureText: obscuteText,
121114
style: widget.style,

0 commit comments

Comments
 (0)