Replace popen and fork/exec with GIO subprocessing

TheAssassin · TheAssassin · commit 054e547560b5 · 2022-07-12T12:08:34.000+02:00
Should help make the code more robust, reap child process correctly, etc., and saves a few lines.
diff --git a/cmake/dependencies.cmake b/cmake/dependencies.cmake
@@ -12,6 +12,7 @@ import_pkgconfig_target(TARGET_NAME libfuse PKGCONFIG_TARGET fuse)
 # openssl is required for optional tools only, and doesn't need to be enforced
 # FIXME: remove dependency to openssl by implementing own SHA hashes in libappimage_hashlib
 import_pkgconfig_target(TARGET_NAME libssl PKGCONFIG_TARGET openssl OPTIONAL)
+import_pkgconfig_target(TARGET_NAME libgio PKGCONFIG_TARGET gio OPTIONAL)
 
 
 if(USE_CCACHE)
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -35,6 +35,7 @@ target_link_libraries(appimagetool
     xdg-basedir
     libappimage_shared
     libglib
+    libgio
     libzlib
     xz
 )
diff --git a/src/appimagetool.c b/src/appimagetool.c

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ target_link_libraries(appimagetool`
`35`	`35`	`xdg-basedir`
`36`	`36`	`libappimage_shared`
`37`	`37`	`libglib`
	`38`	`+ libgio`
`38`	`39`	`libzlib`
`39`	`40`	`xz`
`40`	`41`	`)`