Fix unnecessary leaking of compile flag

TheAssassin · TheAssassin · commit fee0413210fd · 2024-11-26T04:54:31.000+01:00
Fixes inconsistency in type declarations across tools, causing link errors on 32-bit systems.

In the long term, we want to build everything with 64-bit types.
diff --git a/src/signing/CMakeLists.txt b/src/signing/CMakeLists.txt
@@ -18,6 +18,6 @@ if(CMAKE_SIZEOF_VOID_P EQUAL 4)
     # https://www.gnupg.org/documentation/manuals/gpgme/Largefile-Support-_0028LFS_0029.html
     message(WARNING "Building on 32-bit system, adding special gpgme definitions")
     target_compile_definitions(signing
-        PUBLIC -D_FILE_OFFSET_BITS=64 -DLARGEFILE_SOURCE
+        PRIVATE -D_FILE_OFFSET_BITS=64 -DLARGEFILE_SOURCE
     )
 endif()
diff --git a/src/signing/signaturevalidator.h b/src/signing/signaturevalidator.h
@@ -5,7 +5,7 @@
 #include <filesystem>
 
 // library headers
-#include <gpgme.h>
+#include <gpg-error.h>
 
 // local headers
 #include "util/updatableappimage.h"

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,6 @@ if(CMAKE_SIZEOF_VOID_P EQUAL 4)`
`18`	`18`	`# https://www.gnupg.org/documentation/manuals/gpgme/Largefile-Support-_0028LFS_0029.html`
`19`	`19`	`message(WARNING "Building on 32-bit system, adding special gpgme definitions")`
`20`	`20`	`target_compile_definitions(signing`
`21`		`- PUBLIC -D_FILE_OFFSET_BITS=64 -DLARGEFILE_SOURCE`
	`21`	`+ PRIVATE -D_FILE_OFFSET_BITS=64 -DLARGEFILE_SOURCE`
`22`	`22`	`)`
`23`	`23`	`endif()`