fix: Fix lint (#1965)

Author: saikrishna321

.eslintignore

@@ -1,3 +1,4 @@
 /node_modules/*
 /lib/*
-/ui/*
+/ui/*
+/test/*

dashboard-frontend

@@ -118,8 +118,8 @@ export async function iOSCapabilities(
       delete caps.firstMatch[0]['appium:wdaLocalPort'];
     }
   }
-  if(!freeDevice.realDevice) {
-    caps.firstMatch[0]['appium:derivedDataPath'] =`${freeDevice.derivedDataPath}`;
+  if (!freeDevice.realDevice) {
+    caps.firstMatch[0]['appium:derivedDataPath'] = `${freeDevice.derivedDataPath}`;
   }
 
   const deleteMatch = [

src/CapabilityManager.ts

@@ -13,7 +13,7 @@ import { registerAuthenticationRoutes } from '../auth/routers';
 import { userService } from '../auth/services/user.service';
 import { IPluginArgs } from '../interfaces/IPluginArgs';
 
-let dashboardPluginUrl: any = null;
+const dashboardPluginUrl: any = null;
 
 const ASYNC_LOCK = new AsyncLock();
 

src/app/index.ts

@@ -34,7 +34,7 @@ async function getSavedDevices(request: Request, response: Response) {
 async function getDevices(request: Request, response: Response) {
   const { user } = request as AuthenticatedRequest;
   const filterOptions = user?.role === 'admin' ? {} : { userId: user?.userId };
-  let devices = await getAllDevices(filterOptions as any);
+  const devices = await getAllDevices(filterOptions as any);
   const { sessionId } = request.query;
   if (sessionId) {
     return response.json(devices.find((value) => value.session_id === sessionId));

src/app/routers/grid.ts

@@ -21,7 +21,7 @@ function getDeviceFarmHome() {
 
 export function getServerMetadata() {
   const metaFile = path.join(getDeviceFarmHome(), 'metadata.json');
-  let defaultMetadata = {
+  const defaultMetadata = {
     id: uuid(),
   };
   if (fs.existsSync(metaFile)) {

src/config.ts

@@ -63,7 +63,7 @@ export class NodeService {
     }
   }
 
-  static async getAllNodes(secure: boolean = true) {
+  static async getAllNodes(secure = true) {
     return prisma.node.findMany({
       select: {
         id: true,

src/data-service/node-service.ts

@@ -1,19 +1,19 @@
 /* eslint-disable no-prototype-builtins */
-import os from 'os';
-import path from 'path';
-import tcpPortUsed from 'tcp-port-used';
-import getPort from 'get-port';
 import AsyncLock from 'async-lock';
-import { IDevice } from './interfaces/IDevice';
+import asyncWait from 'async-wait-until';
+import axios from 'axios';
+import getPort from 'get-port';
 import _ from 'lodash';
-import log from './logger';
-import Cloud from './enums/Cloud';
 import normalizeUrl from 'normalize-url';
 import ora from 'ora';
-import asyncWait from 'async-wait-until';
-import axios from 'axios';
+import os from 'os';
+import path from 'path';
+import tcpPortUsed from 'tcp-port-used';
+import Cloud from './enums/Cloud';
 import { FakeModuleLoader } from './fake-module-loader';
+import { IDevice } from './interfaces/IDevice';
 import { IExternalModuleLoader } from './interfaces/IExternalModule';
+import log from './logger';
 
 const APPIUM_VENDOR_PREFIX = 'appium:';
 
@@ -35,8 +35,8 @@ class PortManager {
    */
   async getAndAllocateFreePort(portRange?: string): Promise<number> {
     return this.lock.acquire('port-allocation', async () => {
+      // eslint-disable-next-line no-constant-condition
       while (true) {
-        let port: number;
         let portOptions: number[] | undefined;
 
         // Determine which ports to try
@@ -59,7 +59,7 @@ class PortManager {
         }
 
         // Get a free port from the system
-        port = portOptions ? await getPort({ port: portOptions }) : await getPort();
+        const port = portOptions ? await getPort({ port: portOptions }) : await getPort();
 
         // Atomically allocate it (we're in the lock, so this is safe)
         if (!this.allocatedPorts.has(port)) {

src/helpers.ts

@@ -587,7 +587,9 @@ class DevicePlugin extends BasePlugin {
       let jwt = '';
       if (this.pluginArgs.enableAuthentication) {
         const user = await getUserFromCapabilities(mergedCapabilites);
-        jwt = await generateTokenForNode(device.nodeId!, user?.id!);
+        if (user) {
+          jwt = await generateTokenForNode(device.nodeId!, user.id);
+        }
       }
       if (capabilitiesToCreateSession.capabilities.alwaysMatch) {
         capabilitiesToCreateSession.capabilities.alwaysMatch['df:udid'] = device.udid;