Skip to content

Commit c4b8ef0

Browse files
fix: ios port forwarding for real device (#1539)
* fix: ios port forwarding for real device * update package lock
1 parent 810141d commit c4b8ef0

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/modules

src/plugin.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -354,20 +354,25 @@ class DevicePlugin extends BasePlugin {
354354
await EventBus.fire(
355355
new BeforeSessionCreatedEvent({ device, sessionType: sessionType, caps }),
356356
);
357-
358-
if (device.platform === 'ios' && device.realDevice) {
357+
358+
session = await next();
359+
360+
if (
361+
device.platform === 'ios' &&
362+
device.realDevice &&
363+
device.nodeId === DevicePlugin.NODE_ID
364+
) {
359365
log.info(`📱 Forwarding ios port to real device ${device.udid} for manual interaction`);
360366
try {
361367
await DEVICE_CONNECTIONS_FACTORY.requestConnection(device.udid, device.mjpegServerPort, {
362368
usePortForwarding: true,
363369
devicePort: device.mjpegServerPort,
364370
});
365-
} catch(err){
371+
} catch (err) {
366372
/* Not required for now as the port forwarding is handled by xcuitest river itself */
367373
log.warn(`Error while forwarding ios port to real device ${device.udid}. Error: ${err}`);
368374
}
369375
}
370-
session = await next();
371376

372377
debugLog(`📱 Session response: ${JSON.stringify(session)}`);
373378
}

0 commit comments

Comments
 (0)