CraftingCPULogic::executeCrafting() logic error gives infinite co-processor behavior when two exit conditions collide.

[HaphLife]

Describe the bug

CraftingCPULogic's lines 236 - 243 has two conditions to check exit conditions to skip the rest of that iteration of the loop:

if (task.getValue().value <= 0) {
    it.remove();
    continue taskLoop;
}

if (pushedPatterns == maxPatterns) {
    break taskLoop;
}

However, if the first condition (that the last copy of a particular recipe is executed) is coincident with the second condition (that we hit the limit of patterns which can be pushed this tick), the second condition is skipped.

Skipping the second condition causes the loop to both not break this iteration (incorrect behavior) and not break on any subsequent iteration (unless it overflows and loops all the way back around through every integer value), behaving as if the CPU cluster had "infinite" co-processors for a tick.

How to reproduce the bug

This behavior can occur in-game whenever those two conditions coincide, which is particularly easily to cause if executing a crafting plan with many different recipes each executed once.

Expected behavior

I would expect that when both conditions are true, the task gets removed and the loop breaks, rather than continuing.

Additional details

A simple fix for this bug would be to just add a copy of the pushedPatterns==maxPatterns check between the remove() and the continue.

Which minecraft version are you using?

1.21

On which mod loaders does it happen?

Forge

Crash log

n/a

[HaphLife]

More specific reproduction steps:
The bug is caused when the two exit conditions happen in the same pass of the loop.
One trivial way to do that is to create a crafting plan that involves many recipes issued once.

For example, create a crafting plan for one of item F on a network with these 5 processing patterns:
A -> B
A -> C
A -> D
A -> E
B, C, D, E -> F
And only item A available as ingredients.
(note that whether these patterns are real recipes is irrelevant, it's just about when the crafting CPU decides to push patterns, feel free to use any 6 items in your tests)

This crafting plan will result in pushing all of the first 4 patterns in the same tick, even if the CPU pushing items has no co-processors.

Indeed, this can be scaled, with an arbitrarily high number of patterns being pushed in the same tick, as long as each pattern is scheduled to be completed once, it will push all of them.

Here's an image of the network I used for testing: