Skip to content

Commit dd8bdf4

Browse files
committed
refactor: 프록시 객체의 경우 Id기반 삭제로 리팩토링
1 parent 4386f8c commit dd8bdf4

File tree

5 files changed

+13
-8
lines changed

5 files changed

+13
-8
lines changed

src/main/java/apptive/team5/jwt/repository/RefreshTokenRepository.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@ public interface RefreshTokenRepository extends JpaRepository<RefreshToken,Strin
1515
@Query("delete from RefreshToken r where r.user = :user")
1616
void deleteByUser(UserEntity user);
1717

18-
@Query("select r from RefreshToken r where r.user.identifier = :identifier")
19-
Optional<RefreshToken> findByUserIdentifier(String identifier);
18+
@Modifying(clearAutomatically = true)
19+
@Query("delete from RefreshToken r where r.user.id = :userId")
20+
void deleteByUserId(Long userId);
21+
2022

2123
@Modifying(clearAutomatically = true)
2224
@Query("delete from RefreshToken r where r.createdDate < :date")
@@ -25,4 +27,5 @@ public interface RefreshTokenRepository extends JpaRepository<RefreshToken,Strin
2527
@Query("select r from RefreshToken r where r.user.id = :userId")
2628
Optional<RefreshToken> findByUserId(Long userId);
2729

30+
Long user(UserEntity user);
2831
}

src/main/java/apptive/team5/jwt/service/JwtLowService.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ public void deleteByUser(UserEntity user) {
2828
refreshTokenRepository.deleteByUser(user);
2929
}
3030

31+
public void deleteByUserId(Long userId) {
32+
refreshTokenRepository.deleteByUserId(userId);
33+
}
34+
3135
public RefreshToken save(RefreshToken refreshToken) {
3236
return refreshTokenRepository.save(refreshToken);
3337
}

src/main/java/apptive/team5/jwt/service/JwtService.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@ public TokenResponse exchangeToken(String oldRefreshToken) {
6363
}
6464

6565
public void deleteRefreshTokenByUserId(Long userId) {
66-
UserEntity findUser = userLowService.getReferenceById(userId);
67-
jwtLowService.deleteByUser(findUser);
66+
jwtLowService.deleteByUserId(userId);
6867
}
6968

7069
public void deleteExpiredRefreshTokens() {

src/main/java/apptive/team5/user/service/UserLowService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ public UserEntity save(UserEntity userEntity) {
4545
return userRepository.save(userEntity);
4646
}
4747

48-
public void deleteByUser(UserEntity userEntity) {
49-
userRepository.delete(userEntity);
48+
public void deleteByUserId(Long userId) {
49+
userRepository.deleteById(userId);
5050
}
5151

5252
@Transactional(readOnly = true)

src/main/java/apptive/team5/user/service/UserService.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,9 @@ public UserResponse getUserInfo(Long userId) {
6666
}
6767

6868
public void deleteUser(Long userId) {
69-
UserEntity userEntity = userLowService.getReferenceById(userId);
7069
subscribeLowService.deleteByUserId(userId);
7170
diaryLowService.deleteByUserId(userId);
72-
userLowService.deleteByUser(userEntity);
71+
userLowService.deleteByUserId(userId);
7372

7473
}
7574

0 commit comments

Comments
 (0)