misc cleanup

Author: marcustyphoon

src/features/quote_replies.js

@@ -14,7 +14,7 @@ import { timelineObject } from '../utils/react_props.js';
 
 const storageKey = 'quote_replies.draftLocation';
 const buttonClass = 'xkit-quote-replies';
-const meatballButtonId = 'quote_replies';
+const meatballButtonId = 'quote-replies';
 const dropdownButtonClass = 'xkit-quote-replies-dropdown';
 
 const originalPostTagStorageKey = 'quick_tags.preferences.originalPostTag';
@@ -72,10 +72,16 @@ const quoteReply = async (tumblelogName, notificationProps) => {
   if (!reply) throw new Error('No replies found on target post.');
   if (Math.floor(reply.timestamp) !== timestamp) throw new Error('Reply not found.');
 
-  const replyingBlogName = reply.blog.name;
-  const replyingBlogUuid = reply.blog.uuid;
-
-  openQuoteReplyPost({ type, replyingBlogName, replyingBlogUuid, reply, postSummary: targetPostSummary, postUrl, targetBlogUuid: uuid, targetBlogName: tumblelogName });
+  openQuoteReplyPost({
+    type,
+    replyingBlogName: reply.blog.name,
+    replyingBlogUuid: reply.blog.uuid,
+    reply,
+    postSummary: targetPostSummary,
+    postUrl,
+    targetBlogUuid: uuid,
+    targetBlogName: tumblelogName
+  });
 };
 
 const openQuoteReplyPost = async ({ type, replyingBlogName, replyingBlogUuid, postSummary, postUrl, reply, targetBlogUuid, targetBlogName }) => {
@@ -133,8 +139,8 @@ const processNoteProps = ([noteProps, parentNoteProps]) => {
       targetBlogName: noteProps.blog.name
     };
   }
-  for (const { formatting } of noteProps.note.content) {
-    for (const { type, blog } of formatting ?? []) {
+  for (const { formatting = [] } of noteProps.note.content) {
+    for (const { type, blog } of formatting) {
       if (type === 'mention' && userBlogNames.includes(blog.name)) {
         return {
           type: 'note_mention',

src/main_world/test_parent_element.js

@@ -1,7 +1,7 @@
 export default function testParentElement (selector) {
-  const menuElement = this;
-  const reactKey = Object.keys(menuElement).find(key => key.startsWith('__reactFiber'));
-  let fiber = menuElement[reactKey];
+  const element = this;
+  const reactKey = Object.keys(element).find(key => key.startsWith('__reactFiber'));
+  let fiber = element[reactKey];
 
   while (fiber !== null) {
     if (fiber.stateNode?.matches?.(selector)) {

src/main_world/unbury_note_props.js

@@ -3,14 +3,15 @@ export default function unburyNoteProps () {
   const reactKey = Object.keys(noteElement).find(key => key.startsWith('__reactFiber'));
   let fiber = noteElement[reactKey];
 
-  const results = {};
+  const resultsByReplyId = {};
   while (fiber !== null) {
     const props = fiber.memoizedProps || {};
     if (typeof props?.note?.replyId === 'string') {
-      // returns the last set of props corresponding to each replyId, which contains the most information
-      results[props.note.replyId] = props;
+      // multiple sets of props correspond to each replyId;
+      // prefer the last set, as it contains the most information
+      resultsByReplyId[props.note.replyId] = props;
     }
     fiber = fiber.return;
   }
-  return Object.values(results);
+  return Object.values(resultsByReplyId);
 }