fix: Trim Reblogs: Update/clarify warning about trimming reblogs#2154
Closed
JiwaniZakir wants to merge 1 commit intoAprilSylph:masterfrom
Closed
fix: Trim Reblogs: Update/clarify warning about trimming reblogs#2154JiwaniZakir wants to merge 1 commit intoAprilSylph:masterfrom
JiwaniZakir wants to merge 1 commit intoAprilSylph:masterfrom
Conversation
Repository owner
locked as spam and limited conversation to collaborators
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2048
Updates the ask warning modal in
onButtonClicked(src/features/trim_reblogs/index.js) to use past tense, reflecting that trimming asks no longer consistently causes broken appearances on custom themes. The original warning overstated the certainty of breakage with "will result in", which was inaccurate given changes to how Tumblr handles asks. Changes the phrasing to "has resulted in... in the past" and adds "completely" to the second sentence to clarify that leaving the ask intact remains the safest option without implying trimming is guaranteed to break. Verified by reviewing the modal message strings inindex.jsagainst the issue report.