Adds tests for ArangoDB 3.12 (#499)

* Add tests for ArangoDB 3.12

fix #498

* Update older tests to run against latest minor.

* Mark PostTransactionAsync as deprecated since ArangoDB 3.12

* Use enum values for error code assertions in GraphApiClientTest.

* Handle ArangoDB 3.12 breaking change for error code assertions in GraphApiClientTest.

* Fix test failures for RenameCollectionAsync since ArangoDB 3.12

Author: DiscoPYF

.circleci/config.yml

@@ -29,6 +29,9 @@ workflows:
       - "test-arangodb-3_11":
           requires:
             - build
+      - "test-arangodb-3_12":
+          requires:
+            - build
 
 jobs:
   build:
@@ -55,9 +58,9 @@ jobs:
     docker:
       - image: mcr.microsoft.com/dotnet/sdk:8.0
         environment:
-          ARANGO_HOST: adb3_4_9
-      - image: arangodb:3.4.9
-        name: adb3_4_9
+          ARANGO_HOST: adb3_4
+      - image: arangodb:3.4
+        name: adb3_4
         environment:
           ARANGO_ROOT_PASSWORD: root
     steps:
@@ -74,9 +77,9 @@ jobs:
     docker:
       - image: mcr.microsoft.com/dotnet/sdk:8.0
         environment:
-          ARANGO_HOST: adb3_5_5
-      - image: arangodb:3.5.5
-        name: adb3_5_5
+          ARANGO_HOST: adb3_5
+      - image: arangodb:3.5
+        name: adb3_5
         environment:
           ARANGO_ROOT_PASSWORD: root
     steps:
@@ -93,9 +96,9 @@ jobs:
     docker:
       - image: mcr.microsoft.com/dotnet/sdk:8.0
         environment:
-          ARANGO_HOST: adb3_6_8
-      - image: arangodb/arangodb:3.6.8
-        name: adb3_6_8
+          ARANGO_HOST: adb3_6
+      - image: arangodb:3.6
+        name: adb3_6
         environment:
           ARANGO_ROOT_PASSWORD: root
     steps:
@@ -112,9 +115,9 @@ jobs:
     docker:
       - image: mcr.microsoft.com/dotnet/sdk:8.0
         environment:
-          ARANGO_HOST: adb3_7_17
-      - image: arangodb/arangodb:3.7.17
-        name: adb3_7_17
+          ARANGO_HOST: adb3_7
+      - image: arangodb:3.7
+        name: adb3_7
         environment:
           ARANGO_ROOT_PASSWORD: root
     steps:
@@ -131,9 +134,9 @@ jobs:
     docker:
       - image: mcr.microsoft.com/dotnet/sdk:8.0
         environment:
-          ARANGO_HOST: adb3_8_6
-      - image: arangodb/arangodb:3.8.6
-        name: adb3_8_6
+          ARANGO_HOST: adb3_8
+      - image: arangodb:3.8
+        name: adb3_8
         environment:
           ARANGO_ROOT_PASSWORD: root
     steps:
@@ -150,9 +153,9 @@ jobs:
     docker:
       - image: mcr.microsoft.com/dotnet/sdk:8.0
         environment:
-          ARANGO_HOST: adb3_9_1
-      - image: arangodb/arangodb:3.9.1
-        name: adb3_9_1
+          ARANGO_HOST: adb3_9
+      - image: arangodb:3.9
+        name: adb3_9
         environment:
           ARANGO_ROOT_PASSWORD: root
     steps:
@@ -168,9 +171,9 @@ jobs:
     docker:
       - image: mcr.microsoft.com/dotnet/sdk:8.0
         environment:
-          ARANGO_HOST: adb3_10_0
+          ARANGO_HOST: adb3_10
       - image: arangodb:3.10
-        name: adb3_10_0
+        name: adb3_10
         environment:
           ARANGO_ROOT_PASSWORD: root
     steps:
@@ -186,9 +189,27 @@ jobs:
     docker:
       - image: mcr.microsoft.com/dotnet/sdk:8.0
         environment:
-          ARANGO_HOST: adb3_11_0
+          ARANGO_HOST: adb3_11
       - image: arangodb:3.11
-        name: adb3_11_0
+        name: adb3_11
+        environment:
+          ARANGO_ROOT_PASSWORD: root
+    steps:
+      - attach_workspace:
+          # Must be absolute path or relative path from working_directory
+          at: ~/
+      - run:
+          name: Test
+          command: dotnet test -c Release --filter RunningMode!=Cluster
+
+  "test-arangodb-3_12":
+    working_directory: ~/arangodb-net-standard
+    docker:
+      - image: mcr.microsoft.com/dotnet/sdk:8.0
+        environment:
+          ARANGO_HOST: adb3_12
+      - image: arangodb:3.12
+        name: adb3_12
         environment:
           ARANGO_ROOT_PASSWORD: root
     steps:

arangodb-net-standard.Test/CollectionApi/CollectionApiClientTest.cs

@@ -206,7 +206,8 @@ public async Task PostCollectionAsync_ShouldThrow_WhenCollectionNameInvalid()
         {
             var request = new PostCollectionBody
             {
-                Name = "My collection name with spaces"
+                // A collection name that starts with a number is invalid.
+                Name = "80 invalid collection name"
             };
             var ex = await Assert.ThrowsAsync<ApiErrorException>(async () =>
             {
@@ -377,25 +378,12 @@ public async Task RenameCollectionAsync_ShouldThrow_WhenNameInvalid()
             {
                 await _collectionApi.RenameCollectionAsync(_testCollection, new RenameCollectionBody
                 {
-                    Name = "Bad Collection Name"
+                    Name = "80 Bad Collection Name"
                 });
             });
             Assert.Equal(1208, exception.ApiError.ErrorNum); // Arango Illegal Name
         }
 
-        [Fact]
-        public async Task RenameCollectionAsync_ShouldThrow_WhenCollectionInvalid()
-        {
-            var exception = await Assert.ThrowsAsync<ApiErrorException>(async () =>
-            {
-                await _collectionApi.RenameCollectionAsync("Bad Collection Name", new RenameCollectionBody
-                {
-                    Name = "testingCollection"
-                });
-            });
-            Assert.Equal(1203, exception.ApiError.ErrorNum); // Arango Data Source Not Found
-        }
-
         [Fact]
         public async Task GetCollectionRevisionAsync_ShouldSucceed()
         {