fix db creation in tests

Author: rashtao

src/main/java/com/arangodb/tinkerpop/gremlin/client/ArangoDBGraphClient.java

@@ -131,66 +131,24 @@ public static ArangoDBGraphException getNamingConventionError(String cause, Stri
     private final ArangoDBGraph graph;
 
     /**
-     * Create a simple graph client and connect to the provided db. If the DB does not exist, the driver will try to
-     * create one.
+     * Create a simple graph client and connect to the provided db.
      *
      * @param graph      the ArangoDB graph that uses this client
      * @param properties the ArangoDB configuration properties
      * @param dbname     the ArangoDB name to connect to or create
      * @throws ArangoDBGraphException If the db does not exist and cannot be created
      */
-
-    public ArangoDBGraphClient(ArangoDBGraph graph, Properties properties, String dbname) {
-        this(graph, properties, dbname, false);
-    }
-
-    /**
-     * Create a simple graph client and connect to the provided db. The create flag controls what is the
-     * behaviour if the db is not found
-     *
-     * @param graph          the ArangoDB graph that uses this client
-     * @param properties     the ArangoDB configuration properties
-     * @param dbname         the ArangoDB name to connect to or create
-     * @param createDatabase if true, the driver will attempt to crate the DB if it does not exist
-     * @throws ArangoDBGraphException If the db does not exist and cannot be created
-     */
-
     public ArangoDBGraphClient(
             ArangoDBGraph graph,
             Properties properties,
-            String dbname,
-            boolean createDatabase)
+            String dbname)
             throws ArangoDBGraphException {
         logger.debug("Initiating the ArangoDb Client");
         this.graph = graph;
         db = new ArangoDB.Builder()
                 .loadProperties(ArangoConfigProperties.fromProperties(properties))
                 .build()
                 .db(dbname);
-        if (createDatabase) {
-            if (!db.exists()) {
-                logger.debug("DB not found, attemtping to create it.");
-                try {
-                    if (!db.create()) {
-                        throw new ArangoDBGraphException("Unable to crate the database " + dbname);
-                    }
-                } catch (ArangoDBException ex) {
-                    throw ArangoDBExceptions.getArangoDBException(ex);
-                }
-            }
-        } else {
-            boolean exists = false;
-            try {
-                exists = db.exists();
-            } catch (ArangoDBException ex) {
-                // Pass
-            }
-            if (!exists) {
-                logger.error("Database does not exist, or the user has no access");
-                throw new ArangoDBGraphException(String.format("DB not found or user has no access: %s@%s",
-                        properties.getProperty("arangodb.user"), dbname));
-            }
-        }
     }
 
     /**

src/main/java/com/arangodb/tinkerpop/gremlin/structure/ArangoDBGraph.java

@@ -534,7 +534,7 @@ public ArangoDBGraph(Configuration configuration) {
         shouldPrefixCollectionNames = arangoConfig.getBoolean(PROPERTY_KEY_SHOULD_PREFIX_COLLECTION_NAMES, true);
 
         Properties arangoProperties = ConfigurationConverter.getProperties(arangoConfig);
-        client = new ArangoDBGraphClient(this, arangoProperties, arangoConfig.getString(PROPERTY_KEY_DB_NAME), shouldPrefixCollectionNames);
+        client = new ArangoDBGraphClient(this, arangoProperties, arangoConfig.getString(PROPERTY_KEY_DB_NAME));
 
         ArangoGraph graph = client.getArangoGraph();
         GraphCreateOptions options = new GraphCreateOptions();

src/test/java/com/arangodb/tinkerpop/gremlin/util/TestGraphClient.java

@@ -10,7 +10,12 @@
 public class TestGraphClient extends ArangoDBGraphClient {
 
     public TestGraphClient(Properties properties, String dbname) throws ArangoDBGraphException {
-        super(null, properties, dbname, false);
+        super(null, properties, dbname);
+        if (!db.exists()) {
+            if (!db.create()) {
+                throw new ArangoDBGraphException("Unable to crate the database " + dbname);
+            }
+        }
     }
 
     public void deleteGraph(String name) {