tests fixes

Author: rashtao

src/main/java/com/arangodb/tinkerpop/gremlin/utils/ArangoDBUtil.java

@@ -592,6 +592,7 @@ public static Optional<String> extractLabel(final String id, final String label)
         return Optional.ofNullable(label);
     }
 
+    // FIXME: DE-996
     public static String getId(Graph.Features.ElementFeatures features, String label, Object... keyValues) {
         Optional<Object> optionalId = ElementHelper.getIdValue(keyValues);
         if (!optionalId.isPresent()) {

src/test/java/com/arangodb/tinkerpop/gremlin/TestGraph.java

@@ -13,19 +13,19 @@
 @Graph.OptOut(
         test = "org.apache.tinkerpop.gremlin.structure.GraphTest",
         method = "shouldAddVertexWithUserSuppliedStringId",
-        reason = "FIXME")
+        reason = "FIXME: DE-996")
 @Graph.OptOut(
         test = "org.apache.tinkerpop.gremlin.structure.GraphTest",
         method = "shouldRemoveVertices",
-        reason = "Test creates vertices with random labels, which does not work with our schema-based approach.")
+        reason = "FIXME: DE-998")
 @Graph.OptOut(
         test = "org.apache.tinkerpop.gremlin.structure.GraphTest",
         method = "shouldRemoveEdges",
-        reason = "Test creates edges with random labels, which does not work with our schema-based approach.")
+        reason = "FIXME: DE-998")
 @Graph.OptOut(
         test = "org.apache.tinkerpop.gremlin.structure.GraphTest",
         method = "shouldEvaluateConnectivityPatterns",
-        reason = "FIXME")
+        reason = "FIXME: DE-996")
 @Graph.OptOut(
         test = "org.apache.tinkerpop.gremlin.structure.util.star.StarGraphTest",
         method = "shouldAttachWithCreateMethod",

src/test/java/com/arangodb/tinkerpop/gremlin/structure/StructureGraphProvider.java

@@ -19,7 +19,7 @@ public Configuration newGraphConfiguration(String graphName, Class<?> test, Stri
         conf.setProperty(Graph.GRAPH, TestGraph.class.getName());
         return conf;
     }
-    
+
     @Override
     protected void configure(ArangoDBConfigurationBuilder builder, Class<?> test, String testMethodName) {
         if (testMethodName.startsWith("shouldProcessVerticesEdges")
@@ -84,7 +84,7 @@ protected void configure(ArangoDBConfigurationBuilder builder, Class<?> test, St
                     break;
                 case "shouldEvaluateConnectivityPatterns":
                     builder.withEdgeCollection("knows");
-                    builder.withEdgeCollection("knows");
+                    builder.withEdgeCollection("hates");
                     break;
                 case "shouldRemoveEdgesWithoutConcurrentModificationException":
                     builder.withEdgeCollection("link");

src/test/java/com/arangodb/tinkerpop/gremlin/util/BaseGraphProvider.java

@@ -148,6 +148,7 @@ public Map<String, Object> getBaseConfiguration(String graphName, Class<?> test,
         return null;
     }
 
+    // FIXME: DE-997
     @Override
     public Object convertId(Object id, Class<? extends Element> c) {
         return id.toString();