Skip to content

Commit 02bd5e1

Browse files
committed
cmake: : link shec_utils against legacy-option-headers
in c24a6ff, we tried to link all target dependent on legacy option headers against legacy-option-headers, but we missed some of them. in our CI, we spotted build failure like: ``` In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/ErasureCode.cc:26: In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/osd_types.h:41: In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/ceph_context.h:41: In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config_proxy.h:6: In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config.h:27: In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config_values.h:59: /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/options/legacy_config_opts.h:1:10: fatal error: 'global_legacy_options.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. ``` so in this change, we link the shec_utils to `legacy-option-headers` as well to fulfill the build dependency. Signed-off-by: Kefu Chai <[email protected]>
1 parent de7b8ac commit 02bd5e1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/erasure-code/shec/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ set(shec_utils_srcs
1010
determinant.c)
1111

1212
add_library(shec_utils OBJECT ${shec_utils_srcs})
13+
target_link_libraries(shec_utils
14+
PRIVATE legacy-option-headers)
1315

1416
set(ec_shec_objs
1517
$<TARGET_OBJECTS:gf-complete_objs>

0 commit comments

Comments
 (0)