Skip to content

Commit 0345083

Browse files
authored
Merge pull request ceph#51530 from rhcs-dashboard/fix-61213-main
mgr/dashboard: Rename Cluster > Monitoring to Alerts and change Cluster>Users to Cluster>Ceph Users Reviewed-by: Avan Thakkar <[email protected]> Reviewed-by: Nizamudeen A <[email protected]> Reviewed-by: Avan Thakkar <[email protected]> Reviewed-by: Nizamudeen A <[email protected]>
2 parents b8b6af8 + 31b692f commit 0345083

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

src/pybind/mgr/dashboard/frontend/cypress/integration/cluster/users.e2e-spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { UsersPageHelper } from './users.po';
22

3-
describe('Cluster Users', () => {
3+
describe('Cluster Ceph Users', () => {
44
const users = new UsersPageHelper();
55

66
beforeEach(() => {
@@ -11,7 +11,7 @@ describe('Cluster Users', () => {
1111

1212
describe('breadcrumb and tab tests', () => {
1313
it('should open and show breadcrumb', () => {
14-
users.expectBreadcrumbText('Users');
14+
users.expectBreadcrumbText('Ceph Users');
1515
});
1616
});
1717

src/pybind/mgr/dashboard/frontend/cypress/integration/ui/navigation.po.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ export class NavigationPageHelper extends PageHelper {
2727
{ menu: 'Configuration', component: 'cd-configuration' },
2828
{ menu: 'CRUSH map', component: 'cd-crushmap' },
2929
{ menu: 'Manager Modules', component: 'cd-mgr-module-list' },
30-
{ menu: 'Users', component: 'cd-crud-table' },
30+
{ menu: 'Ceph Users', component: 'cd-crud-table' },
3131
{ menu: 'Logs', component: 'cd-logs' },
32-
{ menu: 'Monitoring', component: 'cd-prometheus-tabs' }
32+
{ menu: 'Alerts', component: 'cd-prometheus-tabs' }
3333
]
3434
},
3535
{ menu: 'Pools', component: 'cd-pool-list' },

src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,31 +121,31 @@ const routes: Routes = [
121121
path: 'ceph-users',
122122
component: CRUDTableComponent,
123123
data: {
124-
breadcrumbs: 'Cluster/Users',
124+
breadcrumbs: 'Cluster/Ceph Users',
125125
resource: '[email protected]'
126126
}
127127
},
128128
{
129129
path: 'cluster/user/create',
130130
component: CrudFormComponent,
131131
data: {
132-
breadcrumbs: 'Cluster/Users',
132+
breadcrumbs: 'Cluster/Ceph Users/Create',
133133
resource: '[email protected]'
134134
}
135135
},
136136
{
137137
path: 'cluster/user/import',
138138
component: CrudFormComponent,
139139
data: {
140-
breadcrumbs: 'Cluster/Users',
140+
breadcrumbs: 'Cluster/Ceph Users/Import',
141141
resource: '[email protected]'
142142
}
143143
},
144144
{
145145
path: 'cluster/user/edit',
146146
component: CrudFormComponent,
147147
data: {
148-
breadcrumbs: 'Cluster/Users',
148+
breadcrumbs: 'Cluster/Ceph Users/Edit',
149149
resource: '[email protected]'
150150
}
151151
},
@@ -237,7 +237,7 @@ const routes: Routes = [
237237
},
238238
{
239239
path: 'monitoring',
240-
data: { breadcrumbs: 'Cluster/Monitoring' },
240+
data: { breadcrumbs: 'Cluster/Alerts' },
241241
children: [
242242
{ path: '', redirectTo: 'active-alerts', pathMatch: 'full' },
243243
{

src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@
155155
class="tc_submenuitem tc_submenuitem_users"
156156
*ngIf="permissions.configOpt.read">
157157
<a i18n
158-
routerLink="/ceph-users">Users</a>
158+
routerLink="/ceph-users">Ceph Users</a>
159159
</li>
160160
<li routerLinkActive="active"
161161
class="tc_submenuitem tc_submenuitem_log"
@@ -167,7 +167,7 @@
167167
class="tc_submenuitem tc_submenuitem_monitoring"
168168
*ngIf="permissions.prometheus.read">
169169
<a routerLink="/monitoring">
170-
<ng-container i18n>Monitoring</ng-container>
170+
<ng-container i18n>Alerts</ng-container>
171171
<small *ngIf="prometheusAlertService.activeCriticalAlerts > 0"
172172
class="badge badge-danger ms-1">{{ prometheusAlertService.activeCriticalAlerts }}</small>
173173
<small *ngIf="prometheusAlertService.activeWarningAlerts > 0"

0 commit comments

Comments
 (0)