Skip to content

Commit 0419a1a

Browse files
Tomer HaskalovitchHezko
authored andcommitted
mgr/dashboard: ns list now support not passing nqn param
Signed-off-by: Tomer Haskalovitch <[email protected]>
1 parent 588d831 commit 0419a1a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/pybind/mgr/dashboard/controllers/nvmeof.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -379,14 +379,14 @@ class NVMeoFNamespace(RESTController):
379379
@EndpointDoc(
380380
"List all NVMeoF namespaces in a subsystem",
381381
parameters={
382-
"nqn": Param(str, "NVMeoF subsystem NQN"),
382+
"nqn": Param(str, "NVMeoF subsystem NQN", True, None),
383383
"nsid": Param(str, "NVMeoF Namespace ID to filter by", True, None),
384384
"gw_group": Param(str, "NVMeoF gateway group", True, None),
385385
},
386386
)
387387
@convert_to_model(model.NamespaceList)
388388
@handle_nvmeof_error
389-
def list(self, nqn: str, nsid: Optional[str] = None,
389+
def list(self, nqn: Optional[str] = None, nsid: Optional[str] = None,
390390
gw_group: Optional[str] = None, traddr: Optional[str] = None):
391391
return NVMeoFClient(gw_group=gw_group, traddr=traddr).stub.list_namespaces(
392392
NVMeoFClient.pb2.list_namespaces_req(subsystem=nqn,

src/pybind/mgr/dashboard/openapi.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9295,10 +9295,10 @@ paths:
92959295
/api/nvmeof/subsystem/{nqn}/namespace:
92969296
get:
92979297
parameters:
9298-
- description: NVMeoF subsystem NQN
9298+
- allowEmptyValue: true
9299+
description: NVMeoF subsystem NQN
92999300
in: path
93009301
name: nqn
9301-
required: true
93029302
schema:
93039303
type: string
93049304
- allowEmptyValue: true

0 commit comments

Comments
 (0)