Merge pull request ceph#64626 from xxhdx1985126/wip-72173

crimson/os/seastore: add support for OP_SPLIT_COLLECTION2

Reviewed-by: Samuel Just <[email protected]>

Author: Matan-B

src/crimson/os/seastore/seastore.cc

@@ -1648,6 +1648,15 @@ SeaStore::Shard::_do_transaction_step(
       i.decode_bl(hint);
       return tm_iertr::now();
     }
+    case Transaction::OP_SPLIT_COLLECTION2:
+    {
+      uint32_t bits = op->split_bits;
+      coll_t cid = i.get_cid(op->cid);
+      coll_t dest_cid = i.get_cid(op->dest_cid);
+      DEBUGT("op OP_SPLIT_COLLECTION2, cid={}, dest_cid={}, bits={}",
+	*ctx.transaction, cid, dest_cid, bits);
+      return _split_collection(ctx, cid, bits);
+    }
   }
 
   using onode_iertr = OnodeManager::get_onode_iertr::extend<
@@ -2226,6 +2235,40 @@ SeaStore::Shard::_rmattrs(
     onode);
 }
 
+SeaStore::Shard::tm_ret
+SeaStore::Shard::_split_collection(
+  internal_context_t &ctx,
+  const coll_t &cid,
+  int bits)
+{
+  return transaction_manager->read_collection_root(
+    *ctx.transaction
+  ).si_then([=, this, &ctx](auto _cmroot) {
+    return seastar::do_with(
+      _cmroot,
+      [=, this, &ctx](auto &cmroot) {
+        return collection_manager->update(
+          cmroot,
+          *ctx.transaction,
+          cid,
+          bits
+        ).si_then([this, &ctx, &cmroot] {
+          if (cmroot.must_update()) {
+            transaction_manager->write_collection_root(
+              *ctx.transaction,
+              cmroot);
+          }
+        });
+      }
+    );
+  }).handle_error_interruptible(
+    tm_iertr::pass_further{},
+    crimson::ct_error::assert_all{
+      "Invalid error in SeaStoreS::_create_collection"
+    }
+  );
+}
+
 SeaStore::Shard::tm_ret
 SeaStore::Shard::_create_collection(
   internal_context_t &ctx,

src/crimson/os/seastore/seastore.h

@@ -435,6 +435,9 @@ class SeaStore final : public FuturizedStore {
     tm_ret _create_collection(
       internal_context_t &ctx,
       const coll_t& cid, int bits);
+    tm_ret _split_collection(
+      internal_context_t &ctx,
+      const coll_t& cid, int bits);
     tm_ret _remove_collection(
       internal_context_t &ctx,
       const coll_t& cid);

src/test/crimson/seastore/test_seastore.cc

@@ -700,6 +700,28 @@ TEST_P(seastore_test_t, collection_create_list_remove)
   });
 }
 
+TEST_P(seastore_test_t, collection_split)
+{
+  run_async([this] {
+    coll_t test_coll{spg_t{pg_t{1, 0}}};
+    {
+      sharded_seastore->create_new_collection(test_coll).get();
+      {
+	CTransaction t;
+	t.create_collection(test_coll, 4);
+	do_transaction(std::move(t));
+      }
+      {
+	coll_t test_coll2{spg_t{pg_t{17, 0}}};
+	sharded_seastore->create_new_collection(test_coll2).get();
+	CTransaction t;
+	t.split_collection(test_coll, 5, 5, test_coll2);
+	do_transaction(std::move(t));
+      }
+    }
+  });
+}
+
 TEST_P(seastore_test_t, meta) {
   run_async([this] {
     set_meta("key1", "value1");