Skip to content

Commit 09e4117

Browse files
authored
Merge pull request ceph#51393 from adk3798/fix-related-service-logging
mgr/cephadm: lower log level when logging about related services Reviewed-by: Redouane Kachach <[email protected]>
2 parents 8a94605 + 3693544 commit 09e4117

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

src/pybind/mgr/cephadm/inventory.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1113,14 +1113,14 @@ def get_related_service_daemons(self, service_spec: ServiceSpec) -> Optional[Lis
11131113
if service_spec.service_type == 'ingress':
11141114
dds = list(dd for dd in self._get_daemons() if dd.service_name() == cast(IngressSpec, service_spec).backend_service)
11151115
dds += list(dd for dd in self._get_tmp_daemons() if dd.service_name() == cast(IngressSpec, service_spec).backend_service)
1116-
logger.info(f'Found related daemons {dds} for service {service_spec.service_name()}')
1116+
logger.debug(f'Found related daemons {dds} for service {service_spec.service_name()}')
11171117
return dds
11181118
else:
11191119
for ingress_spec in [cast(IngressSpec, s) for s in self.mgr.spec_store.active_specs.values() if s.service_type == 'ingress']:
11201120
if ingress_spec.backend_service == service_spec.service_name():
11211121
dds = list(dd for dd in self._get_daemons() if dd.service_name() == ingress_spec.service_name())
11221122
dds += list(dd for dd in self._get_tmp_daemons() if dd.service_name() == ingress_spec.service_name())
1123-
logger.info(f'Found related daemons {dds} for service {service_spec.service_name()}')
1123+
logger.debug(f'Found related daemons {dds} for service {service_spec.service_name()}')
11241124
return dds
11251125
return None
11261126

src/pybind/mgr/cephadm/schedule.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -258,11 +258,6 @@ def place(self):
258258

259259
self.validate()
260260

261-
if self.related_service_daemons:
262-
logger.info(f'Service {self.service_name} has related daemons already placed: {self.related_service_daemons}')
263-
else:
264-
logger.info(f'Service {self.service_name} has no related daemon already placed.')
265-
266261
count = self.spec.placement.count
267262

268263
# get candidate hosts based on [hosts, label, host_pattern]
@@ -362,7 +357,7 @@ def expand_candidates(ls: List[DaemonPlacement], num: int) -> List[DaemonPlaceme
362357
if need <= 0:
363358
break
364359
if dp.hostname in related_service_hosts and dp.hostname not in [h.hostname for h in self.unreachable_hosts]:
365-
logger.info(f'Preferring {dp.hostname} for service {self.service_name} as related daemons have been placed there')
360+
logger.debug(f'Preferring {dp.hostname} for service {self.service_name} as related daemons have been placed there')
366361
to_add.append(dp)
367362
need -= 1 # this is last use of need so it can work as a counter
368363
# at this point, we've either met our placement quota entirely using hosts with related

0 commit comments

Comments
 (0)