Skip to content

Commit 0a32f55

Browse files
committed
osd/TrackedOp: Fix TrackedOp event order
Header_read time is recv_stap, throttled time is throttle_stamp. Throttled event is in front of header_read event currently, but throttle_stamp is behind recv_stamp. Initiated time should be recv_stap, instead of throttle_stamp. Fixes: https://tracker.ceph.com/issues/61388 Signed-off-by: YiteGu <[email protected]>
1 parent 5852e5a commit 0a32f55

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/common/TrackedOp.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,8 @@ class OpTracker {
206206
typename T::Ref retval(new T(params, this));
207207
retval->tracking_start();
208208
if (is_tracking()) {
209-
retval->mark_event("throttled", params->get_throttle_stamp());
210209
retval->mark_event("header_read", params->get_recv_stamp());
210+
retval->mark_event("throttled", params->get_throttle_stamp());
211211
retval->mark_event("all_read", params->get_recv_complete_stamp());
212212
retval->mark_event("dispatched", params->get_dispatch_stamp());
213213
}

src/osd/OpRequest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ using std::stringstream;
3131
using ceph::Formatter;
3232

3333
OpRequest::OpRequest(Message* req, OpTracker* tracker)
34-
: TrackedOp(tracker, req->get_throttle_stamp()),
34+
: TrackedOp(tracker, req->get_recv_stamp()),
3535
request(req),
3636
hit_flag_points(0),
3737
latest_flag_point(0),

0 commit comments

Comments
 (0)