crimson/common/smp_helpers: rename reactor_map_seq

Signed-off-by: Matan Breizman <[email protected]>

Author: Matan-B

src/crimson/admin/osd_admin.cc

@@ -341,7 +341,7 @@ class DumpMetricsHook : public AdminSocketHook {
     cmd_getval(cmdmap, "group", prefix);
     fref->open_object_section("metrics");
     fref->open_array_section("metrics");
-    co_await crimson::reactor_map_seq([f = fref.get(), &prefix] {
+    co_await crimson::invoke_on_all_seq([f = fref.get(), &prefix] {
       for (const auto& [full_name, metric_family]: seastar::scollectd::get_value_map()) {
         if (!prefix.empty() && full_name.compare(0, prefix.size(), prefix) != 0) {
           continue;

src/crimson/common/smp_helpers.h

@@ -47,14 +47,14 @@ auto proxy_method_on_core(
 }
 
 /**
- * reactor_map_seq
+ * invoke_on_all_seq
  *
  * Invokes f on each reactor sequentially, Caller may assume that
  * f will not be invoked concurrently on multiple cores.
  * f is copied here and is kept alive due to coroutine parameter copying.
  */
 template <typename F>
-auto reactor_map_seq(F f) -> decltype(seastar::futurize_invoke(f)) {
+auto invoke_on_all_seq(F f) -> decltype(seastar::futurize_invoke(f)) {
   for (auto core: seastar::smp::all_cpus()) {
     using ret_type = decltype(f());
     if constexpr (is_errorated_future_v<ret_type>) {
@@ -73,7 +73,7 @@ auto reactor_map_seq(F f) -> decltype(seastar::futurize_invoke(f)) {
  */
 template <typename T, typename F>
 auto sharded_map_seq(T &t, F &&f) {
-  return reactor_map_seq(
+  return invoke_on_all_seq(
     [&t, f=std::forward<F>(f)]() mutable {
       return std::invoke(f, t.local());
     });