Skip to content

Commit 0faf48c

Browse files
authored
Merge pull request ceph#46150 from dang/wip-dang-bucket-owner
RGW - Replace set_owner workaround with new fix Reviewed-by: Matt Benjamin <[email protected]>
2 parents c2bd611 + ca350b1 commit 0faf48c

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

src/rgw/rgw_lc.cc

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -528,25 +528,16 @@ static int remove_expired_obj(
528528
obj_key.instance = "null";
529529
}
530530

531+
std::unique_ptr<rgw::sal::User> user;
531532
std::unique_ptr<rgw::sal::Bucket> bucket;
532533
std::unique_ptr<rgw::sal::Object> obj;
533534

534-
ret = driver->get_bucket(nullptr, bucket_info, &bucket);
535+
user = driver->get_user(bucket_info.owner);
536+
ret = driver->get_bucket(user.get(), bucket_info, &bucket);
535537
if (ret < 0) {
536538
return ret;
537539
}
538540

539-
// XXXX currently, rgw::sal::Bucket.owner is always null here
540-
std::unique_ptr<rgw::sal::User> user;
541-
if (! bucket->get_owner()) {
542-
auto& bucket_info = bucket->get_info();
543-
user = driver->get_user(bucket_info.owner);
544-
// forgive me, lord
545-
if (user) {
546-
bucket->set_owner(user.get());
547-
}
548-
}
549-
550541
obj = bucket->get_object(obj_key);
551542
std::unique_ptr<rgw::sal::Object::DeleteOp> del_op
552543
= obj->get_delete_op();

0 commit comments

Comments
 (0)